Summoning Companions Via script

[Aurorablade]

Been using the tried and true
local numPets = GetNumCompanions("CRITTER")

for i=1,numPets do

_, cName, _, _, active,_ = GetCompanionInfo("CRITTER", i)

etc etc summon pet based on cName in a comparison.

Not working on mop beta, what has changed that i can't seem to figure out?

[Xrystal]

Considering you can now fight other critters with them I would say a lot has changed. You might want to read through the beta thread as there are quite a few pet specific posts in there if I remember right.

[semlar]

The CallCompanion function appears to throw the error "You do not have a pet" for critters, I don't know if this is just a bug or if you won't be able to use that function any more. In fact, it does the same thing if I try to summon it using /cast <Pet Name>.

I'm not sure exactly what you're trying to do, but I've written a function which will, for the moment, summon a pet by name on the beta. These functions seem like they might be subject to change.

function CallPetByName(petName)
    local _,myPets = C_PetJournal.GetNumPets(false)
    for i=1,myPets do
        local petID, speciesID, isOwned, customName, level, favorite, isRevoked, name, icon, petType, creatureID, sourceText, description, isWildPet, canBattle, tradable, unique = C_PetJournal.GetPetInfoByIndex(i, false)
        if name:lower() == petName:lower() then
            return C_PetJournal.SummonPetByID(petID)
        end
    end
    print('Pet "'..petName..'" not found')
end

I've included what I believe to be an accurate list of the variables returned by GetPetInfoByIndex, even though you're only using 2 of them for this.

[endx7]

Fun thing, filters affect the results from C_PetJournal.GetPetInfoByIndex

[semlar]

Good grief. Alright, well as far as I can tell "C_PetJournal.SummonPetByID" is the only function currently working that will actually summon a companion, and the ID it uses appears to only be obtainable through the pet journal functions.

However.. the pet journal itself isn't loaded until the frame is opened in-game (shift+p) and calling some of the pet journal functions before it loads has managed to fatally crash my client several times.

Apparently calling C_PetJournal.SetSearchFilter in a way that returns no results twice in a row like

/run C_PetJournal.SetSearchFilter('xx');C_PetJournal.SetSearchFilter('xx')

will just immediately crash the game, but only if you haven't loaded the pet journal yet.

Calling C_PetJournal.ClearSearchFilter() in between seems to prevent this from happening, and even though setting the search filter isn't strictly necessary, it does leave fewer things to iterate over.

Here's my second crack at the function, and I haven't managed to break this one but you never know.

function CallPetByName(petName)
    C_PetJournal.SetFlagFilter(LE_PET_JOURNAL_FLAG_COLLECTED, true) -- displays pets we do have
    C_PetJournal.SetFlagFilter(LE_PET_JOURNAL_FLAG_NOT_COLLECTED, false) -- ignores pets we don't have
    C_PetJournal.ClearSearchFilter() -- prevents the game from crashing
    C_PetJournal.SetSearchFilter(petName) -- filter by name
    local numPets = C_PetJournal.GetNumPets(false)
    for i=1,numPets do
        local petID, _, _, _, _, _, _, name = C_PetJournal.GetPetInfoByIndex(i, false)
        if name and name:lower() == petName:lower() and C_PetJournal.PetIsSummonable(petID) and petID ~= C_PetJournal.GetSummonedPetID() then
            return C_PetJournal.SummonPetByID(petID)
        end
    end
    print('Failed to summon '..petName)
end

I'm not really sure why you would need to summon a pet based on its name though, it seems like an odd request.

[Kharthus]

You also need to reset the Type and Source filters.

C_PetJournal.AddAllPetTypesFilter()
C_PetJournal.AddAllPetSourcesFilter()

If these get unchecked, the search will return no results.