artifact xp bar

[SDPhantom]

The derArtifactBar itself isn't recreated constantly, but a dynamic container frame with just a FontString on it. This creates one FontString attached directly to derArtifactBar. I also made a few optimizations.

local AXP_COLOR = { r = 0.6, g = 0.2, b = 0.1 }
 
local derArtifactBar = CreateFrame("Statusbar", "derArtifactBar",artifactFrame)
derArtifactBar:SetPoint("CENTER", 0, 0)
derArtifactBar:SetHeight(18)
derArtifactBar:SetWidth(artifactFrame:GetWidth() * .968)
derArtifactBar:SetStatusBarTexture("Interface\\AddOns\\_Deranjata\\media\\cast\\Waterline")
derArtifactBar:SetStatusBarColor(AXP_COLOR.r, AXP_COLOR.g, AXP_COLOR.b, 0.5)
derArtifactBar:SetBackdrop({
    bgFile =  "Interface\\AddOns\\_Deranjata\\media\\cast\\Lines",
    insets = { left = 1, right = 1, top = 1, bottom = 1 }
})
derArtifactBar:SetBackdropColor(0.1, 0.1, 0.1)
derArtifactBar:SetBackdropBorderColor(0.6, 0.6, 0.6)
 
derArtifactBar.Text=derArtifactBar:CreateFontString(nil, "OVERLAY", "GameFontNormal")
derArtifactBar.Text:SetPoint("CENTER")      
 
derArtifactBar:RegisterEvent("PLAYER_ENTERING_WORLD")
derArtifactBar:RegisterEvent("ARTIFACT_XP_UPDATE")
derArtifactBar:RegisterEvent("UNIT_INVENTORY_CHANGED")
derArtifactBar:SetScript("OnEvent", function(self, event, ...)
    if not HasArtifactEquipped() then self:Hide() return end
    self:Show()
 
    local itemID, altItemID, name, icon, totalXP, pointsSpent = C_ArtifactUI.GetEquippedArtifactInfo()
    local numPoints, artifactXP, xpForNextPoint = MainMenuBar_GetNumArtifactTraitsPurchasableFromXP(pointsSpent, totalXP)
    self:SetMinMaxValues(0,xpForNextPoint)
    self:SetValue(artifactXP)
 
    self.Text:SetFormattedText("Artifact XP: %d / %d ",artifactXP,xpForNextPoint)
end)

[Uitat]

All i want to do is update the bar and text when the events happen

[Uitat]

Originally Posted by SDPhantom The derArtifactBar itself isn't recreated constantly, but a dynamic container frame with just a FontString on it. This creates one FontString attached directly to derArtifactBar. I also made a few optimizations.

ok i see what you did here you cleaned up the has artifact query, then altered the local bar and local text to be self initiated rather then being"seperate varibles" that cause a "statusbar taint essentially"...

is this correct?

sorry i am self teaching as i go and much of my code is probably this dirty

[SDPhantom]

More like you were creating new FontStrings on top of the previous ones each time the function was run and setting the text in them instead of just creating one when you make your bar and change the text in that. The code I posted does the later for you.

As far as cleaning up the event handler, nothing happens if you call frame:Show() on a frame that's already shown. The same could be said for frame:Hide() on a frame that isn't shown. Also, if you're only going to use the return of a function once, there isn't much sense to store it in a local and then use it. You can use function calls and other expressions directly in an if statement.

[Uitat]

Originally Posted by SDPhantom More like you were creating new FontStrings on top of the previous ones each time the function was run and setting the text in them instead of just creating one when you make your bar and change the text in that. The code I posted does the later for you.

I appreciate the help. Like i said... learning as i go so its a little precarious sometimes. More like smash face on wall difficult but hey whatever

[SDPhantom]

Like me sometimes when I run into a lot of Blizzard-induced bugs.