Buff Statusbars

Joker119 · 08-27-16, 09:58 AM

I've been attempting to add statusbars to my buffs and debuffs.
The frames and button skinning is handled by 2 of zork's addons rBuffFrame and rButtonTemplate, I've been able to get as far as adding the statusbars to the buttons, however, I'm not able to get them to update the min/max value or value based on duration or expirationTime, using the code below:

After the rButtonTemplate styles it's aura buttons, I have this hook function to add the statusbars:

Lua Code:

hooksecurefunc("AuraButton_Update", function(self, index, filter)
local buffButtonIndex = 0
    for i = buffButtonIndex, BUFF_MAX_DISPLAY do
        local button = _G["BuffButton"..i]
        BuffStatusBar = CreateFrame("StatusBar", nil, button)
        BuffStatusBar:SetFrameStrata("HIGH")
        BuffStatusBar:SetSize(32, 6)
        BuffStatusBar:SetPoint("BOTTOM", button, 0, -8)
        BuffStatusBar:SetStatusBarTexture("Interface\\AddOns\\Roth_UI\\media\\statusbar3")
        BuffStatusBar:SetStatusBarColor(0,1,0)
        
        local _, _, _, _, _, dur, exps = UnitAura(PlayerFrame.unit, index, filter)
        BuffStatusBar:SetMinMaxValues(dur - exps, exps)
    end
end)

However I get this error:

Code:

30x ...rfaceRoth_UI\embeds\rButtonTemplate\core.lua:335: attempt to perform arithmetic on local 'dur' (a nil value)
...rfaceRoth_UI\embeds\rButtonTemplate\core.lua:335: in function <...rfaceRoth_UI\embeds\rButtonTemplate\core.lua:323>
[C]: in function `AuraButton_Update'
FrameXML\BuffFrame.lua:90: in function `BuffFrame_Update'
FrameXML\PlayerFrame.lua:452: in function `PlayerFrame_ToPlayerArt'
FrameXML\PlayerFrame.lua:213: in function `OnEvent'
FrameXML\UnitFrame.lua:917: in function <FrameXML\UnitFrame.lua:915>

Locals:
self = "BuffButton"
index = 1
filter = "HELPFUL"
buffButtonIndex = 0
(for index) = 0
(for limit) = 32
(for step) = 1
i = 0
button = nil
_ = nil
_ = nil
_ = nil
_ = nil
_ = nil
dur = nil
exps = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'dur' (a nil value)"

Entire addon here:

Lua Code:

-- rButtonTemplate: core
-- zork, 2016
 
-----------------------------
-- Variables
-----------------------------
local ns = ...
local A, L = ...
 
-----------------------------
-- rButtonTemplate Global
-----------------------------
 
rButtonTemplate = {}
rButtonTemplate.addonName = A
 
-----------------------------
-- Init
-----------------------------
 
local function CallButtonFunctionByName(button, func, ...)
  if button and func and button[func] then
    button[func](button, ...)
  end
end
 
local function ResetNormalTexture(self, file)
  if not self.__normalTextureFile then return end
  if file == self.__normalTextureFile then return end
  self:SetNormalTexture(self.__normalTextureFile)
end
 
local function ResetTexture(self, file)
  if not self.__textureFile then return end
  if file == self.__textureFile then return end
  self:SetTexture(self.__textureFile)
end
 
local function ResetVertexColor(self,r,g,b,a)
  if not self.__vertexColor then return end
  local r2,g2,b2,a2 = unpack(self.__vertexColor)
  if not a2 then a2 = 1 end
  if r ~= r2 or g ~= g2 or b ~= b2 or a ~= a2 then
    self:SetVertexColor(r2,g2,b2,a2)
  end
end
 
local function ApplyPoints(self, points)
  if not points then return end
  self:ClearAllPoints()
  for i, point in next, points do
    self:SetPoint(unpack(point))
  end
end
 
local function ApplyTexCoord(texture,texCoord)
  if not texCoord then return end
  texture:SetTexCoord(unpack(texCoord))
end
 
local function ApplyVertexColor(texture,color)
  if not color then return end
  texture.__vertexColor = color
  texture:SetVertexColor(unpack(color))
  hooksecurefunc(texture, "SetVertexColor", ResetVertexColor)
end
 
local function ApplyAlpha(region,alpha)
  if not alpha then return end
  region:SetAlpha(alpha)
end
 
local function ApplyFont(fontString,font)
  if not font then return end
  fontString:SetFont(unpack(font))
end
 
local function ApplyTexture(texture,file)
  if not file then return end
  texture.__textureFile = file
  texture:SetTexture(file)
  hooksecurefunc(texture, "SetTexture", ResetTexture)
end
 
local function ApplyNormalTexture(button,file)
  if not file then return end
  button.__normalTextureFile = file
  button:SetNormalTexture(file)
  hooksecurefunc(button, "SetNormalTexture", ResetNormalTexture)
end
 
local function SetupTexture(texture,cfg,func,button)
  if not texture or not cfg then return end
  ApplyTexCoord(texture,cfg.texCoord)
  ApplyPoints(texture,cfg.points)
  ApplyVertexColor(texture,cfg.color)
  ApplyAlpha(texture,cfg.alpha)
  if func == "SetTexture" then
    ApplyTexture(texture,cfg.file)
  elseif func == "SetNormalTexture" then
    ApplyNormalTexture(button,cfg.file)
  elseif cfg.file then
    CallButtonFunctionByName(button,func,cfg.file)
  end
end
 
local function SetupFontString(fontString,cfg)
  if not fontString or not cfg then return end
  ApplyPoints(fontString, cfg.points)
  ApplyFont(fontString,cfg.font)
  ApplyAlpha(fontString,cfg.alpha)
end
 
local function SetupCooldown(cooldown,cfg)
  if not cooldown or not cfg then return end
  ApplyPoints(cooldown, cfg.points)
end
 
local function SetupBackdrop(button,backdrop)
  if not backdrop then return end
  local bg = CreateFrame("Frame", nil, button)
  ApplyPoints(bg, backdrop.points)
  bg:SetFrameLevel(button:GetFrameLevel()-1)
  bg:SetBackdrop(backdrop)
  if backdrop.backgroundColor then
    bg:SetBackdropColor(unpack(backdrop.backgroundColor))
  end
  if backdrop.borderColor then
    bg:SetBackdropBorderColor(unpack(backdrop.borderColor))
  end
end
 
function rButtonTemplate:StyleActionButton(button, cfg)
  if not button then return end
  if button.__styled then return end
 
  local buttonName = button:GetName()
  local icon = _G[buttonName.."Icon"]
  local flash = _G[buttonName.."Flash"]
  local flyoutBorder = _G[buttonName.."FlyoutBorder"]
  local flyoutBorderShadow = _G[buttonName.."FlyoutBorderShadow"]
  local flyoutArrow = _G[buttonName.."FlyoutArrow"]
  local hotkey = _G[buttonName.."HotKey"]
  local count = _G[buttonName.."Count"]
  local name = _G[buttonName.."Name"]
  local border = _G[buttonName.."Border"]
  local NewActionTexture = button.NewActionTexture
  local cooldown = _G[buttonName.."Cooldown"]
  local normalTexture = button:GetNormalTexture()
  local pushedTexture = button:GetPushedTexture()
  local highlightTexture = button:GetHighlightTexture()
  local checkedTexture = button:GetCheckedTexture()
  local floatingBG = _G[buttonName.."FloatingBG"]
 
  --hide stuff
  if floatingBG then floatingBG:Hide() end
 
  --backdrop
  SetupBackdrop(button,cfg.backdrop)
 
  --textures
  SetupTexture(icon,cfg.icon,"SetTexture",icon)
  SetupTexture(flash,cfg.flash,"SetTexture",flash)
  SetupTexture(flyoutBorder,cfg.flyoutBorder,"SetTexture",flyoutBorder)
  SetupTexture(flyoutBorderShadow,cfg.flyoutBorderShadow,"SetTexture",flyoutBorderShadow)
  SetupTexture(border,cfg.border,"SetTexture",border)
  SetupTexture(normalTexture,cfg.normalTexture,"SetNormalTexture",button)
  SetupTexture(pushedTexture,cfg.pushedTexture,"SetPushedTexture",button)
  SetupTexture(highlightTexture,cfg.highlightTexture,"SetHighlightTexture",button)
  SetupTexture(checkedTexture,cfg.checkedTexture,"SetCheckedTexture",button)
 
  --cooldown
  SetupCooldown(cooldown,cfg.cooldown)
 
  --hotkey+count+name
  SetupFontString(hotkey,cfg.hotkey)
  SetupFontString(count,cfg.count)
  SetupFontString(name,cfg.name)
 
  button.__styled = true
end
 
function rButtonTemplate:StyleExtraActionButton(cfg)
 
  local button = ExtraActionButton1
 
  if button.__styled then return end
 
  local buttonName = button:GetName()
 
  local icon = _G[buttonName.."Icon"]
  --local flash = _G[buttonName.."Flash"] --wierd the template has two textures of the same name
  local hotkey = _G[buttonName.."HotKey"]
  local count = _G[buttonName.."Count"]
  local buttonstyle = button.style --artwork around the button
  local cooldown = _G[buttonName.."Cooldown"]
 
  local normalTexture = button:GetNormalTexture()
  local pushedTexture = button:GetPushedTexture()
  local highlightTexture = button:GetHighlightTexture()
  local checkedTexture = button:GetCheckedTexture()
 
  --backdrop
  SetupBackdrop(button,cfg.backdrop)
 
  --textures
  SetupTexture(icon,cfg.icon,"SetTexture",icon)
  SetupTexture(buttonstyle,cfg.buttonstyle,"SetTexture",buttonstyle)
  SetupTexture(normalTexture,cfg.normalTexture,"SetNormalTexture",button)
  SetupTexture(pushedTexture,cfg.pushedTexture,"SetPushedTexture",button)
  SetupTexture(highlightTexture,cfg.highlightTexture,"SetHighlightTexture",button)
  SetupTexture(checkedTexture,cfg.checkedTexture,"SetCheckedTexture",button)
 
  --cooldown
  SetupCooldown(cooldown,cfg.cooldown)
 
  --hotkey, count
  SetupFontString(hotkey,cfg.hotkey)
  SetupFontString(count,cfg.count)
 
  button.__styled = true
end
 
function rButtonTemplate:StyleItemButton(button,cfg)
 
  if not button then return end
  if button.__styled then return end
 
  local buttonName = button:GetName()
  local icon = _G[buttonName.."IconTexture"]
  local count = _G[buttonName.."Count"]
  local stock = _G[buttonName.."Stock"]
  local searchOverlay = _G[buttonName.."SearchOverlay"]
  local border = button.IconBorder
  local normalTexture = button:GetNormalTexture()
  local pushedTexture = button:GetPushedTexture()
  local highlightTexture = button:GetHighlightTexture()
  local checkedTexture = button:GetCheckedTexture()
 
  --backdrop
  SetupBackdrop(button,cfg.backdrop)
 
  --textures
  SetupTexture(icon,cfg.icon,"SetTexture",icon)
  SetupTexture(searchOverlay,cfg.searchOverlay,"SetTexture",searchOverlay)
  SetupTexture(border,cfg.border,"SetTexture",border)
  SetupTexture(normalTexture,cfg.normalTexture,"SetNormalTexture",button)
  SetupTexture(pushedTexture,cfg.pushedTexture,"SetPushedTexture",button)
  SetupTexture(highlightTexture,cfg.highlightTexture,"SetHighlightTexture",button)
  SetupTexture(checkedTexture,cfg.checkedTexture,"SetCheckedTexture",button)
 
  --count+stock
  SetupFontString(count,cfg.count)
  SetupFontString(stock,cfg.stock)
 
  button.__styled = true
 
end
 
function rButtonTemplate:StyleAllActionButtons(cfg)
  for i = 1, NUM_ACTIONBAR_BUTTONS do
    rButtonTemplate:StyleActionButton(_G["ActionButton"..i],cfg)
    rButtonTemplate:StyleActionButton(_G["MultiBarBottomLeftButton"..i],cfg)
    rButtonTemplate:StyleActionButton(_G["MultiBarBottomRightButton"..i],cfg)
    rButtonTemplate:StyleActionButton(_G["MultiBarRightButton"..i],cfg)
    rButtonTemplate:StyleActionButton(_G["MultiBarLeftButton"..i],cfg)
  end
  for i = 1, 6 do
    rButtonTemplate:StyleActionButton(_G["OverrideActionBarButton"..i],cfg)
  end
  --petbar buttons
  for i=1, NUM_PET_ACTION_SLOTS do
    rButtonTemplate:StyleActionButton(_G["PetActionButton"..i],cfg)
  end
  --stancebar buttons
  for i=1, NUM_STANCE_SLOTS do
    rButtonTemplate:StyleActionButton(_G["StanceButton"..i],cfg)
  end
  --possess buttons
  for i=1, NUM_POSSESS_SLOTS do
    rButtonTemplate:StyleActionButton(_G["PossessButton"..i],cfg)
  end
end
 
function rButtonTemplate:StyleAuraButton(button, cfg)
  if not button then return end
  if button.__styled then return end
 
  local buttonName = button:GetName()
  local icon = _G[buttonName.."Icon"]
  local count = _G[buttonName.."Count"]
  local duration = _G[buttonName.."Duration"]
  local expires = _G[buttonName.."Expires"]
  local border = _G[buttonName.."Border"]
  local symbol = button.symbol
  local timer = 0
 
  --backdrop
  SetupBackdrop(button,cfg.backdrop)
 
  --textures
  SetupTexture(icon,cfg.icon,"SetTexture",icon)
  SetupTexture(border,cfg.border,"SetTexture",border)
 
  --create a normal texture on the aura button
  if cfg.normalTexture and cfg.normalTexture.file then
    button:SetNormalTexture(cfg.normalTexture.file)
    local normalTexture = button:GetNormalTexture()
    SetupTexture(normalTexture,cfg.normalTexture,"SetNormalTexture",button)
  end
    
 
  --count,duration,symbol
  SetupFontString(count,cfg.count)
  SetupFontString(duration,cfg.duration)
  SetupFontString(symbol,cfg.symbol)
 
  button.__styled = true
end
 
 
hooksecurefunc("AuraButton_Update", function(self, index, filter)
local buffButtonIndex = 0
    for i = buffButtonIndex, BUFF_MAX_DISPLAY do
        local button = _G["BuffButton"..i]
        BuffStatusBar = CreateFrame("StatusBar", nil, button)
        BuffStatusBar:SetFrameStrata("HIGH")
        BuffStatusBar:SetSize(32, 6)
        BuffStatusBar:SetPoint("BOTTOM", button, 0, -8)
        BuffStatusBar:SetStatusBarTexture("Interface\\AddOns\\Roth_UI\\media\\statusbar3")
        BuffStatusBar:SetStatusBarColor(0,1,0)
        
        local _, _, _, _, _, dur, exps = UnitAura(PlayerFrame.unit, index, filter)
        BuffStatusBar:SetMinMaxValues(dur - exps, exps)
    end
end)
 
 
 
 
--style player BuffFrame buff buttons
local buffButtonIndex = 1
function rButtonTemplate:StyleBuffButtons(cfg)
  local function UpdateBuffButtons()
    if buffButtonIndex > BUFF_MAX_DISPLAY then return end
    for i = buffButtonIndex, BUFF_MAX_DISPLAY do
      local button = _G["BuffButton"..i]
      if not button then break end
      rButtonTemplate:StyleAuraButton(button, cfg)
      if button.__styled then buffButtonIndex = i+1 end
    end
  end
  hooksecurefunc("BuffFrame_UpdateAllBuffAnchors", UpdateBuffButtons)
end
 
 
 
--style player BuffFrame debuff buttons
function rButtonTemplate:StyleDebuffButtons(cfg)
  local function UpdateDebuffButton(buttonName, i)
    local button = _G["DebuffButton"..i]
    rButtonTemplate:StyleAuraButton(button, cfg)
  end
  hooksecurefunc("DebuffButton_UpdateAnchors", UpdateDebuffButton)
end
 
--style player TempEnchant buttons
function rButtonTemplate:StyleTempEnchants(cfg)
  rButtonTemplate:StyleAuraButton(TempEnchant1, cfg)
  rButtonTemplate:StyleAuraButton(TempEnchant2, cfg)
  rButtonTemplate:StyleAuraButton(TempEnchant3, cfg)
end
 
--style all aura buttons
function rButtonTemplate:StyleAllAuraButtons(cfg)
  rButtonTemplate:StyleBuffButtons(cfg)
  rButtonTemplate:StyleDebuffButtons(cfg)
  rButtonTemplate:StyleTempEnchants(cfg)
end

zork · 08-27-16, 11:58 AM

First and foremost. You can do this in a seperate addon. There is no need to interfere with any other addon. All you need is an addon that hooks the function where aura duration is set.

Secondly you are again making frames (statusbars) without checking if you already created them...in a function that is probably triggered on UNIT_AURA. Don't do that. On top of that I think your statusbar is global?

The error is because the variable "dur" is nil. But my guess is that the buff just does not exist. Make sure that UnitAura(unit, index, filter) actually returns an aura by checking for the name variable.
https://github.com/tomrus88/Blizzard...Frame.lua#L117

I will put together some code. Give me a second.

Lua Code:

local function CreateBar(button)
  local bar = CreateFrame("StatusBar", nil, button)
  bar:SetMinMaxValues(0,1)
  bar:SetValue(0)
  --position/size the bar
  bar:SetPoint("BOTTOMLEFT")
  bar:SetPoint("BOTTOMRIGHT")
  bar:SetHeight(10)
  return bar
end
 
local function UpdateDuration(button, timeleft)
 
  if not button then return end
  button.durationBar = button.durationBar or CreateBar(button)
 
  --set statusbar value
  print(button:GetID(),button.unit,button.filter,button.timeMod,button.expirationTime,timeLeft,GetTime())
  --calculate the value
  --hmm it may be possible that we do need the buff duration, if so we need to get it via unit_aura
  local name, rank, texture, count, debuffType, duration, expirationTime, _, _, _, spellId, _, _, _, _, timeMod = UnitAura(button.unit, button:GetID(), button.filter)
  --exipirationTime-duration = minValue
  --expirationTime = maxValue
  --GetTime() = value
  button.durationBar:SetMinMaxValues(exipirationTime-duration, exipirationTime)
  button.durationBar:SetValue(GetTime())
 
end
 
hooksecurefunc("AuraButton_UpdateDuration", UpdateDuration)

Joker119 · 08-27-16, 12:47 PM

I actually had the idea of doing it as a seperate addon aswell, but wasn't sure where to start.

The reason for not checking if they were created is I assumed doing it in a for i function would only create the statusbar once for each buff on the frame?
Perhaps this still isn't sufficient.

I will get to work applying the code and get it working! thanks!

zork · 08-27-16, 01:11 PM

When you create the bar you can add this script

Lua Code:

button.duration:HookScript("OnShow",bar.Show)
button.duration:HookScript("OnHide",bar.Hide)
bar:Hide()

That way the bar shows/hides itself based on the duration fontstring.
On top of that you can still hide the duration fontstring itself by setting its alpha value to 0 if you want to.

Phanx · 08-28-16, 07:04 AM

The same problem/feature is also addressed in this thread:
https://www.wowinterface.com/forums/...ad.php?t=54269

There may be some useful code in there to get you started.

Joker119 · 08-28-16, 08:01 AM

Originally Posted by Phanx

The same problem/feature is also addressed in this thread:
https://www.wowinterface.com/forums/...ad.php?t=54269

There may be some useful code in there to get you started.

That's originally where I started, infact, but oddly I wasn't able to adapt it, kept having errors with

Code:

local _, _, _, _, _, dur, exps = UnitAura(PlayerFrame.unit, index, filter)
    if dur > 0 and exps then

it kept throwing "attempt to compare number to nil" errors.

I finally settled on embeding ShinyBuffs in place of rBuffFrame and disabling rButtonTemplate's aurabutton styling. (embeded with Seerah's permission, of course)