HELP: An eccho issue with a sound addon

[Duugu]

Keep in mind that path and file names are aware of upper and lower case letters.

[semlar]

Originally Posted by Duugu Keep in mind that path and file names are aware of upper and lower case letters.

No they aren't, the paths should work regardless of the case.

I HAVE seen cases where it required a backslash instead of a forward slash for some reason.

[Duugu]

Originally Posted by semlar No they aren't, the paths should work regardless of the case.

Oh. I was so sure about that. Well. At least I've learned something today. Thank you.

[semlar]

Originally Posted by Nuru0190 You sir, are a genius! It works perfectly. However, i've got one last question: it doesn't trigger the sound file for one spell only: "Flying Serpent Kick". I think it comes from the game that doesn't recognize the spell when typed like this, even though it is the complete name with the right spelling. Would you happen to know how to fix that as well?

Does the print do anything when you use that spell?

Originally Posted by Duugu Oh. I was so sure about that. Well. At least I've learned something today. Thank you.

Yeah, I type my paths almost exclusively in lowercase and it's never an issue.

Forward and backslashes are normally interchangeable, I think the only time I've seen it be a problem was trying to load a font file and it required backslashes.

[Nuru0190]

Yes, it does write:
UNIT_SPELLCAST_SUCCEEDED Flying Serpent Kick

However, no sound plays.

[semlar]

You're sure you have a sound file with that exact name, "Flying Serpent Kick.ogg"?

It's possible the sound file doesn't work?

[Nuru0190]

Yes, here is the copy of the file name: Flying Serpent Kick.ogg
Is it possible to write the spell ID instead of the name to make sure that game recognizes it?

[semlar]

You could try copying one of the other sound files, giving it that name and seeing if it'll play that. That would tell you whether it's a problem with the sound file.

It could be rewritten to use the spellID instead, but it seems like this should work regardless.

local Channeled = { ['Fists of Fury'] = true }
local Instants = {
    ['Blackout Kick'] = true,
    ['Expel Harm'] = true,
    ['Flying Serpent Kick'] = true,
    ['Grapple Weapon'] = true,
    ['Resuscitate'] = true,
    ['Rising Sun Kick'] = true,
    ['Spear Hand Strike'] = true,
    ['Spinning Crane Kick'] = true,
    ['Tiger Palm'] = true,
    ['Touch of Karma'] = true,
    ['Zen Meditation'] = true,
    ['Paralysis'] = true,
    ['Fortifying Brew'] = true,
    ['Touch of Death'] = true,
    ['Tigereye Brew'] = true,
    ['Arcane Shot'] = true,
}
 
local f = CreateFrame('frame')
f:RegisterUnitEvent('UNIT_SPELLCAST_CHANNEL_START', 'player')
f:RegisterUnitEvent('UNIT_SPELLCAST_SUCCEEDED', 'player')
 
f:SetScript('OnEvent', function(self, event, unit, spellName, _, _, spellID)
    if (event == 'UNIT_SPELLCAST_CHANNEL_START' and Channeled[spellID])
    or (event == 'UNIT_SPELLCAST_SUCCEEDED' and Instants[spellID]) then
        print(event, GetSpellInfo(spellID))
        PlaySoundFile("Interface\\AddOns\\HokutoNoMonk\\sounds\\" .. spellID .. ".ogg", "SFX")
    end
end)

Just replace all of the names in the table and the sound files with their spellIDs.

For example flying serpent kick would be like [101545] = true (presumably).

[Nuru0190]

Sure, trying now.
Ok, you were right, it was actually coming from the sound file itself.

You know, you helped me a great deal here! I really spent a lot of time trying to fix this myself, to no avail.
So can i return the favor? I see you are a mod author, can i donate for one of your mods?
It would be my pleasure.

[semlar]

Ah well I don't normally ask for donations but if you'd really like to here's a link to me on pledgie.

I just like helping people out around here.

If you have any other questions don't hesitate to ask!

[Nuru0190]

Truly, you have no idea how long i browsed the net and how long i tried to fix these issues by myself! ^^
You really helped a lot, here.

I just donated 10 bucks for your local coffee house
Hope it helps as much as you helped me!

Thank you very much, sir.

[semlar]

Much appreciated.

[Nuru0190]

I don't know if you're still around, but actually, i got an issue with the "Spinning Crane Kick". This time, it's this spell that has an eccho. It ecchoes 3 times.
All the other spells work perfectly, and i even added more sounds.

I think it's kind of like what you explained at the beginning of the thread, the spell is maybe made of 3 "parts" and the sound file plays once for each part. It ecchoes, even if the Spinning Crane Kick doesn't hit anything.

Could you tell me how to fix it?

[semlar]

If it's channeled you can try moving it to the table with fists of fury (and taking it out of the Instants table), I'm having a hard time identifying whether it's actually channeled from the description.

local Channeled = {
    [113656] = true, -- Fists of Fury
    [101546] = true, -- Spinning Crane Kick
}

[Nuru0190]

I already tried that, but i wrote it like this:

local Channeled = {
['Fists of Fury'] = true,
['Spinning Crane Kick'] = true,
}
(i deleted the Spinning Crane Kick in local instants)

Fists of Fury was still working, but not Spinning Crane Kick. The code you just gave me, however, doesn't work at all, neither for FoF nor SCK. Perhaps the spell is not channeled after all.
In the other code i first pasted in my original post, i didn't have this issue. Is it possible to take from that code to put into your code to make it work?

[semlar]

I'll make a monk on the PTR later so I can check what events actually fire with the different abilities, I won't be home for at least another hour though.

You can type /etrace in-game to see what events are firing but it's probably going to be a little overwhelming.

[Nuru0190]

Ok, thank you much!

[semlar]

I think this should do what you want.

local Channeled = {
    [113656] = 'Fists of Fury',
}
 
local Instants = {
    [100784] = 'Blackout Kick',
    [115072] = 'Expel Harm',
    [101545] = 'Flying Serpent Kick',
    [117368] = 'Grapple Weapon',
    [115178] = 'Resuscitate',
    [107428] = 'Rising Sun Kick',
    [116705] = 'Spear Hand Strike',
    [101546] = 'Spinning Crane Kick',
    [100787] = 'Tiger Palm',
    [122470] = 'Touch of Karma',
    [115176] = 'Zen Meditation',
    [115078] = 'Paralysis',
    [115203] = 'Fortifying Brew',
    [115080] = 'Touch of Death',
    [116740] = 'Tigereye Brew',
}
 
local f = CreateFrame('frame')
f:RegisterUnitEvent('UNIT_SPELLCAST_CHANNEL_START', 'player')
f:RegisterUnitEvent('UNIT_SPELLCAST_SUCCEEDED', 'player')
 
f:SetScript('OnEvent', function(self, event, unit, spellName, _, _, spellID)
    if (event == 'UNIT_SPELLCAST_CHANNEL_START' and Channeled[spellID]) then
        PlaySoundFile("Interface\\AddOns\\HokutoNoMonk\\sounds\\" .. Channeled[spellID] .. ".ogg", "SFX")
    elseif (event == 'UNIT_SPELLCAST_SUCCEEDED' and Instants[spellID]) then
        PlaySoundFile("Interface\\AddOns\\HokutoNoMonk\\sounds\\" .. Instants[spellID] .. ".ogg", "SFX")
    end
end)

Basically, Spinning Crane Kick is firing a UNIT_SPELLCAST_SUCCEEDED event for the spellID 101546 when it's cast, but it also periodically triggers the event with the spellID 107270 after that. The problem with using the spell name is they're all called the same thing.

The simple solution is probably to use the spellID for everything, with the added bonus that it doesn't have to be localized, but you might have to double check that the IDs are accurate because I just went through and pulled the most likely candidates off of wowhead.

[Phanx]

Originally Posted by semlar You can type /etrace in-game to see what events are firing but it's probably going to be a little overwhelming.

After typing "/etrace" do some random stuff -- mouse over players, cast a spell, etc -- and click the "X" button next to each even you don't care about, before you go do your actual test. Even if you can eliminate a few of the spammiest events -- COMBAT_LOG_EVENT_UNFILTERED, SPELLS_CHANGED, CURSOR_UPDATE, etc. -- what's left will be much more usable.

[Nuru0190]

Thanks semlar,
Juste woke up (i live in France), gonna try this right now.

Alright, it works flawlessly!
It's really good because even for spells such as Flying Serpent Kick, i had the voice file triggered twice: once when i use the FSK and a second time when i click the spell again to land for the AoE snare effect. Basically, i had the 2 voice files playing with 1 or 2 seconds delay.
Your new code fixes all.

Since i added new spells since the last time, i'm gonna add them again with their IDs.