Thread Tools Display Modes
01-04-07, 11:23 AM   #1
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jul 2005
Posts: 1,935
Buff Conditions

Okay, we have the following buff conditions. What more would you guys like to see?

Code:
Buffs.conditions = {
	["All"] = function(u,c) return true end,
	["Warrior"] = function(u,c) return c == "WARRIOR" end,
	["Priest"] = function(u,c) return c == "PRIEST" end,
	["Druid"] = function(u,c) return c == "DRUID" end,
	["Paladin"] = function(u,c) return c == "PALADIN" end,
	["Shaman"] = function(u,c) return c == "SHAMAN" end,
	["Hunter"] = function(u,c) return c == "HUNTER" end,
	["Rogue"] = function(u,c) return c == "ROGUE" end,
	["Warlock"] = function(u,c) return c == "WARLOCK" end,
	["Mage"] = function(u,c) return c == "MAGE" end,
	["Mana"] = function(u,c) return c == "DRUID" or c == "PRIEST" or c == "PALADIN" or c == "SHAMAN" or c == "MAGE" or c == "WARLOCK" or c == "HUNTER" end,
	["Caster"] = function(u,c) return c == "MAGE" or c == "WARLOCK" or c == "SHAMAN" or c == "DRUID" end,
	["Melee"] = function(u,c) return c == "WARRIOR" or c == "ROGUE" end,
	["Healer"] = function(u,c) return c == "PRIEST" or c == "SHAMAN" or c == "DRUID" or c == "PALADIN" end,
	["NonTank"] = function(u,c) return c ~= "WARRIOR" end,
}
Someone has already suggested "MyGroup" so they can watch for missing totem buffs on their party. Anyone else have suggestions?
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
  Reply With Quote
01-04-07, 01:11 PM   #2
Kesshi
A Deviate Faerie Dragon
Join Date: Jan 2007
Posts: 11
Code:
["Caster"] = function(u,c) return c == "MAGE" or c == "WARLOCK" or c == "SHAMAN" or c == "DRUID" end,
Why are Priests excluded from Caster?
  Reply With Quote
01-04-07, 01:28 PM   #3
Nahamnessa
A Deviate Faerie Dragon
Join Date: Dec 2006
Posts: 17
Here is a thought....Is melee all those that melee or those that can melee without mana bars? Ret Paladins and DW Shaman (in fact, I don't see why all shaman won't be in melee for the BoW regen) will most likely be in melee range most, if not all the time.

Since your "alternative" trees will be common in raid scenarios. I'd suggest either Pure Melee and All Melee or including Shaman/Paladins within the melee group...though what to do about cats? Druids too?

This might be a scenario where it's too difficult to figure out what belongs in what group. Casters is almost obvious - except that whole cat form which can't be considered a caster.

Since this seems to be a static list - I don't suppose there is a way to dynamically check these? For instances. Casters (assuming you mean DPS) would include Druids in Moonkin form, but no other form.

I dunno...those terms now seem to general and broad to function properly.
  Reply With Quote
01-04-07, 02:41 PM   #4
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jul 2005
Posts: 1,935
Thats why I'm asking. I need to know what classifications are useful. The reason they are included is they are a single test instead of four tests (in the example of healers). Each class was taken with its primary goal in mind, with the exception of Paladins, who as a tauren druid, I hate.

I'm 100% open to suggestions and completely revamping this list, or removing it entirely.
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
  Reply With Quote
01-04-07, 04:06 PM   #5
Itania
A Deviate Faerie Dragon
Join Date: Sep 2006
Posts: 10
Priest must be considered as a caster I think, or druid need to be removed of the list as they have a healing role in raid too.

Last edited by Itania : 01-04-07 at 04:17 PM.
  Reply With Quote
01-04-07, 04:44 PM   #6
Kesshi
A Deviate Faerie Dragon
Join Date: Jan 2007
Posts: 11
Originally Posted by Cladhaire
Each class was taken with its primary goal in mind
With no disrespect intended, that is a pre TBC mindset which may not work out very well post TBC. With many of the new talents introduced each class can now have a different Primary role than pre 2.0.X/TBC.

Look at the NonTanks being anything that is not a Warrior. Come a few weeks, you're going to have Warriors, Druids, and Paladins all being viable tanks.

I believe you already know all of this, Cladhaire.

In my opinion, I think the following would be ideal:

All
The 8 Individual Classes
My Group
Has Mana
Has No Mana
Other: _______


After all, if one want to include all mana users except Hunters, one could easily check all the individual class boxes save the Hunter, Rogue, and Warrior boxes.

The "Other", if possible, would be a customizable box for a singular person. Perhaps for your focus target or main tank. As a Discipline Priest, I like to know if my focus target has PI on them or not. Or perhaps I only want to know if my MT has a Weakened Soul debuff, and I don't care about anyone else with that debuff.

Regardless of what you implement here, I will continue to use PRaid with a smile on my face. (^&
  Reply With Quote
01-04-07, 05:19 PM   #7
Nahamnessa
A Deviate Faerie Dragon
Join Date: Dec 2006
Posts: 17
Yeah, the traditional grouping I don't think is going to work as well as it used to with the hybrid classes coming to fruit, so to speak.

I haven't had the time to check out the code as of yet, but how efficient/possible is it to perform "form" lookups when doing the buff/debuff queries? What I mean is Druid is in Moonkin/Druid/Cat/Bear/ToL form or Priest is in Shadowform. If it's relatively easy, then Mana User group could be all those with mana, except cats/bears.

Healer group could be Priests (not in shadowform, sorry Disc priests :/), Druids in Druid/ToL form, Paladins, Shaman.

I think if the pre-set groups thing is going to work, it's best to include all possibilities and let every user remove the ones they wish to remove because not every raiding group is going to have Ret pallies, moonkins, shadow priests, etc. That could also solve the problem of ignoring form totally and just be a general all inclusive thing?
  Reply With Quote
01-04-07, 06:13 PM   #8
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jul 2005
Posts: 1,935
yes.. i know.
Thats why I said they were a starting point, to see if I could find groupings that would work.
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
  Reply With Quote
01-04-07, 09:31 PM   #9
Nahamnessa
A Deviate Faerie Dragon
Join Date: Dec 2006
Posts: 17
Originally Posted by Cladhaire
yes.. i know.
Thats why I said they were a starting point, to see if I could find groupings that would work.
Yeah, I guess I'm just thinking out loud...Seeing if anything comes of it...especially by those that have been testing the Beta.
  Reply With Quote
01-04-07, 09:52 PM   #10
wind82
An Aku'mai Servant
AddOn Compiler - Click to view compilations
Join Date: Oct 2005
Posts: 39
I dont know if this is far fetched but would it be possible to add like a custom menu..

I am thinking something like

Druid name (x) counts as Melee in this raid (Feral spec Bear/cat form)

It would count kind of like a group override.

Well just an idea since I have no idea how to code lua
  Reply With Quote
01-04-07, 09:54 PM   #11
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jul 2005
Posts: 1,935
Yeah, kinda outside the scope of what we're doing. but you can always just tick "druid" =)
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
  Reply With Quote
01-05-07, 01:01 PM   #12
krinla
A Fallenroot Satyr
 
krinla's Avatar
Join Date: Sep 2006
Posts: 21
I'd like to see check boxes for each group 1-8 to only look at missing buffs from assigned groups.
__________________
Ellianna 70 Priest Lothar
Evie 61 Warlock Lothar
  Reply With Quote
01-12-07, 12:08 AM   #13
Laine
A Murloc Raider
Join Date: Oct 2006
Posts: 9
I'll second Krinla here. A set of 1-8 boxes on the buff/debuff config tab would make raid buffing a snap and would allow a person to change it on the fly from one encounter to the next if necessary. If no box was checked, the default would be to check all groups.
  Reply With Quote
01-12-07, 06:26 AM   #14
Cladhaire
Salad!
 
Cladhaire's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jul 2005
Posts: 1,935
Well it doesn't really work that way, but I've added single groups, as well as a "My Group" checkbox for the latest version.
__________________
"There's only one thing that I know how to do well and I've often been told that you only can do what you know how to do well, and that's be you-- be what you're like-- be like yourself. And so I'm having a wonderful time, but I'd rather be whistling in the dark..."
  Reply With Quote
01-12-07, 10:59 AM   #15
krinla
A Fallenroot Satyr
 
krinla's Avatar
Join Date: Sep 2006
Posts: 21
Originally Posted by Cladhaire
Well it doesn't really work that way, but I've added single groups, as well as a "My Group" checkbox for the latest version.
That's hot - thanks for adding it!
__________________
Ellianna 70 Priest Lothar
Evie 61 Warlock Lothar
  Reply With Quote
01-12-07, 06:51 PM   #16
bacon
A Murloc Raider
Join Date: Dec 2006
Posts: 4
First of all, it isn't my goal to criticize perfectraid with every post I used perfectraid before wow 2.0 and am waiting to tell my guildmates about it when it's ready to go. Thanks Cladhaire for the rewrite and new features in progress.

On to buffing:

I don't know how popular/useful/difficult this would be but in my experience you're usually in charge of buffing your own group, which you have support for. You're typically not in charge of buffing other groups with your class. Groups that don't have a representative of your class are up for grabs, and I think most of the people reading this thread are the ones who buff those groups in the end

I have 3 points:

1. Love the "My Group" idea.

2. It would be great to have an option for "groups without my class in it."

3. For priests, druids, and paladins (not familiar with shaman at all) there are talents that enhance buffs or actually grant the buff. An exclude list would be great for the above "groups without my class in it" selector. For example, your guild shadow priest might have imp fort (follow me here). So, he wouldn't be in fort's exclude list, but would be in spirit's exclude list. Or a druid without improved mark of the wild... let's say you keep getting tells from people in his group that his buff isn't the improved one. Well, add him to the exclude list for MotW and if you're buffing "my group" and "groups without my class in it," you will buff the druid without improved MotW's group. When the raid leader switches groups around, you don't have to do anything.

This option might seem like a lot of work on the user's part, but you know your guild and the people you run with. In TBC, for most folks this will be even less people.
  Reply With Quote

WoWInterface » Featured Projects » Cladhaire's Mods » Buff Conditions

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off