Destro Lock Soul Shard tracking in 7.2.5

[Joker119]

So I just NOW realized the changes to destro locks kinda broke my ouf module for soul shard display for Roth UI, is doesn't show partially filled shards, they are only ever empty or full. This is annoying.

Now that i am aware of the problem, I look back to see how zork handled burning embers, and it was relatively straightforward, however, it relied on an api call for "MAX_POWER_PER_EMBER" but an equivalent for shards doesn't seem to exist, and i can't find any actual documentation of changes to the api in patch 7.2.5

If someone would be able to assist with either helping me check for partially filled shards, or point me to something that shows the diffs between 7.2 and 7.2.5 api's that'd be great.

[lightspark]

To get number of fragments per shard, a.k.a. modifier, you need to use this:

local mod = UnitPowerDisplayMod(7)

Here's a quote of my post from another thread regarding UnitPower and its return.

Originally Posted by lightspark Use UnitPower's 3 arg to get unmodified values. local mod = UnitPowerDisplayMod(8) -- returns 10 local cur_mod = UnitPower("player", 8) -- let's say it returns 15 local cur_unmod = UnitPower("player", 8, true) -- will return 150 You can divide unmodified value by modifier later, when you need to do so.

Just replace 8s w/ 7s or Enum.PowerType.SoulShards.

Everything else is simple maths.

[Joker119]

Thank you very much!

[Joker119]

I've been trying to implement this and I've had great success making the addon determine when there is an extra "half shard" ontop of the shards held (IE a shard is being made but not completed yet)

However, I'm hitting a wall when it comes to implementing it into a usable form.

What I WANT it to do, when a shard is full, the shard icon will be purple, if it is being created, it will be green. However the closest I can get is full shards are purple, and when a shard is being created, it turns all the empty slots green, instead of just the next shard slot.

Here's my code;

if select(2, UnitClass("player")) ~= "WARLOCK" then return end
 
local parent, ns = ...
local oUF = ns.oUF or oUF
 
 
 
local SPELL_POWER_SOUL_SHARDS     = SPELL_POWER_SOUL_SHARDS
 
 
local Update = function(self, event, unit, powerType)
  local bar = self.SoulShardPowerBar
  local mod = UnitPowerDisplayMod(7)
  local cur_unmod = UnitPower("player", 7, true)
  local max_unmod = UnitPowerMax("player", 7, true)
  local cur = UnitPower("player", 7)
  local max = UnitPowerMax("player", 7)
  --adjust the width of the soulshard power frame
  local w = 64*(max+1)
  bar:SetWidth(w)
  for i = 1, bar.maxOrbs do
    local orb = self.SoulShards[i]
    if i > max then
       if orb:IsShown() then orb:Hide() end
    else
      if not orb:IsShown() then orb:Show() end
    end
  end
    for i = 1, bar.maxOrbs do
        local orb = self.SoulShards[i]
        local orb2 = self.SoulShards[i+1]
        local full = cur/max
        if(i <= cur) then
            if full == 1 then
                orb.fill:SetVertexColor(1,0,0)
                orb.glow:SetVertexColor(1,0,0)
            else
                orb.fill:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
                orb.glow:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
            end
            orb.fill:Show()
            orb.glow:Show()
            orb.highlight:Show()
        else
            orb.fill:Hide()
            orb.glow:Hide()
            orb.highlight:Hide()
        end
        if(i > cur) then
            local orb = self.SoulShards[i]
            if cur_unmod/mod > cur then
                orb.fill:SetVertexColor(0,1,0)
                orb.glow:SetVertexColor(0,1,0)
                orb.fill:Show()
                orb.glow:Show()
                orb.highlight:Show()
            end
        end
    end
end
 
local Visibility = function(self, event, unit)
  local element = self.SoulShards
  local bar = self.SoulShardPowerBar
  if UnitHasVehicleUI("player")
    or ((HasVehicleActionBar() and UnitVehicleSkin("player") and UnitVehicleSkin("player") ~= "")
    or (HasOverrideActionBar() and GetOverrideBarSkin() and GetOverrideBarSkin() ~= ""))
  then
    bar:Hide()
  elseif(select(2, UnitClass("player")) == "WARLOCK") then
    bar:Show()
    element.ForceUpdate(element)
  else
    bar:Hide()
  end
end
 
local Path = function(self, ...)
  return (self.SoulShards.Override or Update) (self, ...)
end
 
local ForceUpdate = function(element)
  return Path(element.__owner, "ForceUpdate", element.__owner.unit, "SOUL_SHARDS")
end
 
local function Enable(self, unit)
  local element = self.SoulShards
  if(element and unit == "player") then
    element.__owner = self
    element.ForceUpdate = ForceUpdate
 
    self:RegisterEvent("UNIT_POWER_FREQUENT", Path)
    self:RegisterEvent("UNIT_DISPLAYPOWER", Path)
    self:RegisterEvent("PLAYER_TALENT_UPDATE", Visibility, true)
    self:RegisterEvent("SPELLS_CHANGED", Visibility, true)
    self:RegisterEvent("UPDATE_OVERRIDE_ACTIONBAR", Visibility, true)
    self:RegisterEvent("UNIT_ENTERED_VEHICLE", Visibility)
    self:RegisterEvent("UNIT_EXITED_VEHICLE", Visibility)
 
    local helper = CreateFrame("Frame") --this is needed...adding player_login to the visivility events does not do anything
    helper:RegisterEvent("PLAYER_LOGIN")
    helper:SetScript("OnEvent", function() Visibility(self) end)
 
    return true
  end
end
 
local function Disable(self)
  local element = self.SoulShards
  if(element) then
    self:UnregisterEvent("UNIT_POWER_FREQUENT", Path)
    self:UnregisterEvent("UNIT_DISPLAYPOWER", Path)
    self:UnregisterEvent("PLAYER_TALENT_UPDATE", Visibility)
    self:UnregisterEvent("SPELLS_CHANGED", Visibility)
    self:UnregisterEvent("UPDATE_OVERRIDE_ACTIONBAR", Visibility)
    self:UnregisterEvent("UNIT_ENTERED_VEHICLE", Visibility)
    self:UnregisterEvent("UNIT_EXITED_VEHICLE", Visibility)
  end
end
 
oUF:AddElement("SoulShards", Path, Enable, Disable)

The important part is

for i = 1, bar.maxOrbs do
        local orb = self.SoulShards[i]
        local orb2 = self.SoulShards[i+1]
        local full = cur/max
        if(i <= cur) then
            if full == 1 then
                orb.fill:SetVertexColor(1,0,0)
                orb.glow:SetVertexColor(1,0,0)
            else
                orb.fill:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
                orb.glow:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
            end
            orb.fill:Show()
            orb.glow:Show()
            orb.highlight:Show()
        else
            orb.fill:Hide()
            orb.glow:Hide()
            orb.highlight:Hide()
        end
        if(i > cur) then
            if cur_unmod/mod > cur then
                orb.fill:SetVertexColor(0,1,0)
                orb.glow:SetVertexColor(0,1,0)
                orb.fill:Show()
                orb.glow:Show()
                orb.highlight:Show()
            end
        end
    end
end

I don't know how to make the second if function ( if(i > cur) then ) select the NEXT shard icon only.

The local "orb2" was an attempt at having it select the next shard when it fills the previous, however when I change the second if condition's "orb.fill" with "orb2.fill" it gives me an error saying it's a nil value.
It's been awhile since i've done coding and I just can't figure this one out.
Probably doesn't help I haven't slept in 26hrs ><

[lightspark]

You're clearly using oUF, why don't you use default element? It supports all types of class powers

Also, not being able to see how full is one's shard is kinda bad.

[p3lim]

As lightspark suggested, use the ClassPower element and add this PostUpdate callback:

local function PostUpdateClassPower(element, cur, max, hasMaxChanged, powerType)
    if(powerType == 'SOUL_SHARDS') then
        for i = 1, max do
            if(i <= cur) then
                -- purple
            else
                -- green
            end
        end
    end
end