Quantcast EquipSetManager and icon replacements - WoWInterface
 
Thread Tools Display Modes
08-27-16, 01:52 AM   #1
Stanzilla
An Aku'mai Servant
AddOn Author - Click to view addons
Join Date: Dec 2007
Posts: 34
EquipSetManager and icon replacements

If you are using custom icon replacements, as in putting your own tga files into Interface\ICONS, the EquipmentManager icon selector will fail to set a correct icon path for every spell whose icon you are trying to use and fall back to the question mark icon.

Video: https://dl.dropboxusercontent.com/s/..._09-18-35.webm
(I am using an addon in the video that expands the icon selection screen, but the problem happens without any addons, too)

Example of such a icon pack: http://www.wowinterface.com/download...nPackBlue.html

Last edited by Stanzilla : 08-27-16 at 01:54 AM.
 
08-27-16, 01:58 AM   #2
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 879
I've seen a number of people having this problem

http://us.battle.net/forums/en/wow/topic/20747745286
https://www.wowace.com/addons/larger...ger-selection/

GetEquipmentSetIconInfo() would start returning texture paths with a dot appended (?) after the inventory gear items and in alphabetical order
Same for GetSpellorMacroIconInfo() after the class specific spell icons

With Equipment Manager window open:
Lua Code:
  1. /run for i = 15, 20 do print(i, GetEquipmentSetIconInfo(i)) end
Lua Code:
  1. 15, 133452
  2. 16, 1034142
  3. 17, 1085039
  4. 18, "6BF_Blackrock_Nova."
  5. 19, "6BF_Explosive_Shard."
  6. 20, "6BF_Retched_Blackrock."
That looks like it's from GetLooseMacroItemIcons() and GetLooseMacroIcons()
https://github.com/Gethe/wow-ui-sour...ua#L2040-L2041

(Edit) I was wrong about that part, I'm guessing it's SaveEquipmentSet() only accepting FileDataIDs, while CreateMacro() accepts both FileDataIDs and texture paths (with or without dot)
Lua Code:
  1. CreateMacro("test1", 135953) -- works
  2. CreateMacro("test2", "Spell_Holy_Renew") -- works
  3. CreateMacro("test3", "Spell_Holy_Renew.") -- works
  4.  
  5. SaveEquipmentSet("test1", 135953) -- works
  6. SaveEquipmentSet("test2", "Spell_Holy_Renew") -- does not work (question mark)
  7. SaveEquipmentSet("test3", "Spell_Holy_Renew.") -- does not work (question mark)
  8.  
  9. SetGuildBankTabInfo(1, "test1", 135953) -- works
  10. SetGuildBankTabInfo(1, "test2", "Spell_Holy_Renew") -- works
  11. SetGuildBankTabInfo(1, "test3", "Spell_Holy_Renew.") -- works


Certain (?) custom/skinned iconsthat are not normally macro icons would only work as FileDataIDs
Lua Code:
  1. CreateMacro("test1", 1392922) -- works
  2. CreateMacro("test2", "70_inscription_deck_Hellfire_3") -- does not work (green)
  3. CreateMacro("test3", "70_inscription_deck_Hellfire_3.") -- does not work (green)
  4.  
  5. CreateMacro("test1", 236834) -- works
  6. CreateMacro("test2", "Achievement_Zone_StormPeaks_03") -- works
  7. CreateMacro("test3", "Achievement_Zone_StormPeaks_03.") -- works

Last edited by Ketho : 08-27-16 at 06:50 PM.
 
08-30-16, 04:09 PM   #3
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 879
Preventing them from filling the *_ICON_FILENAMES tables is a workaround at least
Lua Code:
  1. GetLooseMacroItemIcons = function() end
  2. GetLooseMacroIcons = function() end
  • This won't fix custom icons (as in custom icon paths from addons) though, the duplicates(?) just won't show up in the icon selector

(I'd like to post this on the US forums but I'm on EU)

Last edited by Ketho : 09-16-16 at 06:50 PM. Reason: bad wording
 
 

WoWInterface » Site Forums » Archived Beta Forums » Legion Beta archived threads » EquipSetManager and icon replacements

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off