Some PostUpdate parameters don't match the upgrade info thread

[Akkorian]

I just came back to the game and am updating my personal layout, and have noticed a few discrepancies between the oUF 7.0 Upgrade thread and the current code.

The thread says the AlternativePower element's PostUpdate callback should now be sending (unit, cur, min, max) but it's sending (unit, cur, max) with no "min" (additionalpower.lua:125). Hopefully this was just overlooked in the code, and "min" should be added to match the Power element's PostUpdate callback.

The thread says the ClassPower element's PostUpdate callback should be sending (unit, cur, max, hasMaxChanged, powerType) but it's sending (cur, max, hasMaxChanged, powerType) with no "unit" (classpower.lua:158). But, since this element only works on the player unit, the "unit" parameter would always be "player", so this was probably just a mistake in the thread and it isn't supposed to be in the code?

I can make a PR on GitHub, but I didn't know whether it was the code or the info thread that should be updated.

Thanks for all your hard work keeping oUF going!

[lightspark]

ClassPower's unit is a typo in our guide. TY <3

There's no typo in add power though, you confused add power w/ alt power, there's two elements w/ kinda similar names: AdditionalPower and AlternativePower.

[Akkorian]

Thanks!

You're right, I did mix up AdditionalPower and AlternativePower when reading the thread. So it's intended that there's not a "min" in the AdditionalPower callback, to match the Power and AlternativePower callbacks? Also, I'm curious, when would a unit's Power have a non-zero min value? Maybe some vehicles?

[lightspark]

Originally Posted by Akkorian Thanks! You're right, I did mix up AdditionalPower and AlternativePower when reading the thread. So it's intended that there's not a "min" in the AdditionalPower callback, to match the Power and AlternativePower callbacks? Also, I'm curious, when would a unit's Power have a non-zero min value? Maybe some vehicles?

Only when it's used to display altpower too, a bit redundant feature, if you ask me, but it's there.