Thread Tools Display Modes
Prev Previous Post   Next Post Next
07-11-23, 11:56 PM   #1
myrroddin
A Pyroguard Emberseer
 
myrroddin's Avatar
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 1,237
Stumped getting the correct factionID

I am reworking the code chunk in RepByZone that handles getting either Wrathion's or Sabellion's factionID whenever the player's reputation changes. Instead of returning either dragon's factionID, the code is returning the backup of Valdrakken Accord.

What should be happening:
  1. Check the current friendship ranks and return the factionID of the highest rank.
  2. If the ranks are equal, check the progress to the next rank.
  3. If both factions are dead equal or the player hasn't discovered the factionIDs, then return Valdrakken Accord.
I have tested on my main, who is 2 of 6 with Wrathion and 1 of 6 with Sabellion. Each time I visit the Obsidian Throne, RBZ is not switching. The addon is still displaying Valdrakken Accord, and I can't spot the error. I've double-checked the areaID, and the factionIDs, done a few /dump tests, and have run out of ideas.

Here is my latest commit on GitHub: https://github.com/Myrroddin/repbyzone and the buggy code is on lines 444-475 of Core-Retail.lua.
  Reply With Quote
 

WoWInterface » Developer Discussions » Lua/XML Help » Stumped getting the correct factionID

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off