FrameLocks.lua and target taint

[Grimsin]

So i have a taint issue. After going into a pet battle my target frame becomes tainted and any time i change targets in combat after a petbattle it fires taint errors. The problem is with the new FrameLocks.lua

my code hides and locks out the original bliz targetframe. This new framelocks.lua does this...

----------Local helper functions---------------
local function initiateFrame(frame)
    local frameName = frame:GetName();
    if ( not frameName or frameName == "" ) then
        GMError("Frames controlled by FrameLocks must have names.");
    end
 
    if ( BASE_STATES[frameName] ) then
        return;
    end
 
    BASE_STATES[frameName] = frame:IsShown() and "shown" or "hidden";
    assert(frame.originalShow ~= frame.Show); --Make sure we didn't already set up this frame.
    frame.originalShow = frame.Show;
    frame.originalHide = frame.Hide;
    frame.Show = SmartShow;
    frame.Hide = SmartHide;
end
 
local function updateFrameByState(frame)
    initiateFrame(frame);
    local frameName = frame:GetName();
    if ( not frameName or frameName == "" ) then
        GMError("Frames controlled by FrameLocks must have names.");
    end
    for i=1, #FRAMELOCK_STATE_PRIORITIES do
        local lock = FRAMELOCK_STATE_PRIORITIES[i];
        if ( ACTIVE_FRAMELOCKS[lock] ) then
            local desiredState = FRAMELOCK_STATES[lock][frameName];
            if ( desiredState == "hidden" ) then
                frame:originalHide();
                return;
            elseif ( desiredState == "shown" ) then
                frame:originalShow();
                return;
            end
        end
    end
 
    --If we got to here, no lock is in place, so use the base state.
    if ( BASE_STATES[frameName] == "shown" ) then
        frame:originalShow();
    else
        frame:originalHide();
    end
end

I think the taint is created because my addon cancels the orignal hide and show functions via

function addon:HideFrame(reference)
    local frame = type(reference) == 'string' and _G[reference] or reference
    if type(frame) ~= 'table' then return end
    frame.Show = DoNothing
    frame:Hide()
end

and this is the actual hiding of it...

--[[-----------------------------------------------------------------------------
Configure Bliz Target Frame
-------------------------------------------------------------------------------]]
function addon:ConfigureBlizTargetFrame()
    if addon.settings.hideBlizTargetFrame then
        addon:HideFrame('TargetFrame')  -- come back to this and put in unregisters but watch out for buffs :)
    else
        TargetFrame.Show = TargetFrame:Show()
        TargetFrame:RegisterEvent("PLAYER_TARGET_CHANGED")
        TargetFrame:RegisterEvent("UNIT_HEALTH")
        TargetFrame:RegisterEvent("UNIT_LEVEL")
        TargetFrame:RegisterEvent("UNIT_FACTION")
        TargetFrame:RegisterEvent("UNIT_CLASSIFICATION_CHANGED")
        TargetFrame:RegisterEvent("UNIT_AURA")
        TargetFrame:RegisterEvent("PLAYER_FLAGS_CHANGED")
        TargetFrame:RegisterEvent("PLAYER_FOCUS_CHANGED")
        if UnitExists("target") then TargetFrame:Show() end
    end
end
 
addon.RegisterEvent("TargetFrame-Prime", 'PLAYER_LOGIN', function(self, event)
    addon.UnregisterEvent(self, event)
    addon:ConfigureBlizTargetFrame()
end)

Any ideas for turning the framelock.lua off?

[Grimsin]

heres what the taint log produces... Chat frame 11? ummm my chat setup only goes to 8?

9/27 16:05:26.989  Execution tainted by GrimUI while reading ChatFrame11 - Interface\FrameXML\FloatingChatFrame.lua:1105 FCF_OnUpdate()
9/27 16:05:26.989      UIParent:OnUpdate()
9/27 16:05:26.989  An action was blocked in combat because of taint from GrimUI - TargetFrame:originalHide()
9/27 16:05:26.989      Interface\FrameXML\FrameLocks.lua:90 updateFrameByState()
9/27 16:05:26.989      Interface\FrameXML\FrameLocks.lua:101 setBaseState()
9/27 16:05:26.989      Interface\FrameXML\FrameLocks.lua:116 TargetFrame:Hide()
9/27 16:05:26.989      Interface\FrameXML\TargetFrame.lua:99 TargetFrame_Update()
9/27 16:05:26.989      Interface\FrameXML\TargetFrame.lua:150 OnEvent()
9/27 16:05:26.989      Interface\FrameXML\UnitFrame.lua:489

[Grimsin]

Can someone point me to where the pet battle chatframe gets created? is that in chatframes? floatingchatframes? the petbattle ui?

[Phanx]

The problem in your original post is that you are replacing the Show and Hide methods on the frame; this taints the secure frame. If you want to hide the target frame without tainting it, you need to do it without overwriting anything on it. Try this instead:

Hide:

	TargetFrame:UnregisterAllEvents()
	TargetFrame:Hide()

Show:

	TargetFrame:GetScript("OnLoad")(TargetFrame)

Note that these must be run out of combat.

If you want to "hide" the frame based on certain conditions, you can either use a secure state driver that shows or hides the frame based on macro conditionals, or you can change the opacity of the frame to 0% to visually hide it if you want to "hide" it based on conditions that aren't allowed in macros like health.

Without seeing the whole file (what you posted is obviously not it, since there are tons of functions and variables used in the code you posted that are not defined in the code you posted), that's about as specific as I can get.

[Grimsin]

hmm well im not so sure anymore that the targetframe is the initial taint culprit anymore but on the target frame note.. Yes i had thought about dumping the events before and you may have noticed my note to myself in the code that i made months ago to come back and hide the target frame the way you posted but i have two things that rely on the original target frame still functioning... at least to some degree. The target castbar and buffs

i suppose my hope at this point should be that i can leave the events necessary for those to function right intact and ditch the event thats causing it to try to hide/show the original? maybe a simple unregister of the petbattle start and finish events on the target frame? hmm but is the target frame even looking for such events? It did not look like it when i was going through it earlier.

[Phanx]

Ignoring, for the moment, all of your current code and everything it does, what exactly do you actually want to do with the target frame?