Showing a picture :S

Rugguggla · 12-22-11, 03:13 PM

Hi guys!

Ive googled lots of examples on how to create a Frame that contains a texture in xml, then calling it for when i want it to be shown in the lua.

Im using Addon Studio and got the mp3 files to play, but at the same time i want to show a picture for about 5 seconds.

Heres my xml:

Code:

<Ui xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns="http://www.blizzard.com/wow/ui/">
	<Texture name="Texture1" file="Interface\AddOns\Consuela\consuela.png">
		<Size>
			<AbsDimension x="127" y="136" />
		</Size>
		<Anchors>
			<Anchor point="TOPLEFT">
				<Offset x="567" y="-3" />
			</Anchor>
		</Anchors>
	</Texture>
</Ui>

And heres the lua:

Code:

local frame = CreateFrame("FRAME", "combatAddonFrame");
frame:RegisterEvent("PLAYER_REGEN_DISABLED");
local function eventHandler(self, event, ...)
 	PlaySoundFile("Interface\\AddOns\\Consuela\\comeget.mp3");
end
frame:SetScript("OnEvent", eventHandler);

local frame = CreateFrame("FRAME", "deathAddonFrame");
frame:RegisterEvent("PLAYER_DEAD");
local function eventHandler(self, event, ...)
 	PlaySoundFile("Interface\\AddOns\\Consuela\\pledge.mp3");
end
frame:SetScript("OnEvent", eventHandler);

Ive tried to call the Texture1:Show() which should show the texture defined in the xml file?

Any tips?

**Seerah** · 12-22-11, 04:27 PM

Textures cannot exist on their own, they need to belong to a frame. You also have no need to use XML (most addons don't). Finally, you don't need a separate frame for each event you want to register. (And as a sidenote: semi-colons, while harmless, are not needed in Lua.)

lua Code:

local frame = CreateFrame("Frame", nil, UIParent)
     frame:SetPoint("TOPLEFT", 567, -3)
     frame:SetSize(127, 136)     --this is an alias function to frame:SetWidth(127) and frame:SetHeight(136)
local texture = frame:CreateTexture()
     texture:SetTexture("Interface\\AddOns\\Consuela\\consuela")
     texture:SetAllPoints()     --we'll anchor all of the texture's corners to its parent's, the frame above
     texture:Hide()     --we'll hide this for now until you want it shown
 
local function eventHandler(self, event, ...)
     if event == "PLAYER_REGEN_DISABLED" then
          PlaySoundFile("Interface\\AddOns\\Consuela\\comeget.mp3")
     else
          PlaySoundFile("Interface\\AddOns\\Consuela\\pledge.mp3")
     end
end

Oh yeah, and frames don't need to be named, unless you wish to reference them outside of the file they are created in.

WoW only recognizes the .tga and (native) .blp formats for images. Not .png - you'll need to convert your texture. Also, make sure that the dimensions of your texture are a power of two (ex: 2,4,8,16,32,etc). The width and height don't have to match, and it can be up to 1024 px, iirc.

I don't know when you want your texture shown/hidden, so I haven't included that part.

/edit: fixed path to texture to escape \

Torhal · 12-22-11, 04:28 PM

AddOn Studio. Ugh.

Anyway: WoW doesn't support PNG; it supports TGA, however.

killerpet1986 · 12-22-11, 04:29 PM

Originally Posted by Seerah

WoW only recognizes the .tga and (native) .blp formats for images. Not .png - you'll need to convert your texture. Also, make sure that the dimensions of your texture are a power of two (ex: 2,4,8,16,32,etc). The width and height don't have to match, and it can be up to 1024 px, iirc.

They can be bigger than 1024, i have an image that is 16,384x512 px. Not sure what the limit is

Rugguggla · 12-22-11, 04:39 PM

Originally Posted by Seerah

Textures cannot exist on their own, they need to belong to a frame. You also have no need to use XML (most addons don't). Finally, you don't need a separate frame for each event you want to register. (And as a sidenote: semi-colons, while harmless, are not needed in Lua.)

lua Code:

local frame = CreateFrame("Frame", nil, UIParent)
     frame:SetPoint("TOPLEFT", 567, -3)
     frame:SetSize(127, 136)     --this is an alias function to frame:SetWidth(127) and frame:SetHeight(136)
local texture = frame:CreateTexture()
     texture:SetTexture("Interface\\AddOns\\Consuela\\consuela")
     texture:SetAllPoints()     --we'll anchor all of the texture's corners to its parent's, the frame above
     texture:Hide()     --we'll hide this for now until you want it shown
 
local function eventHandler(self, event, ...)
     if event == "PLAYER_REGEN_DISABLED" then
          PlaySoundFile("Interface\\AddOns\\Consuela\\comeget.mp3")
     else
          PlaySoundFile("Interface\\AddOns\\Consuela\\pledge.mp3")
     end
end

Oh yeah, and frames don't need to be named, unless you wish to reference them outside of the file they are created in.

WoW only recognizes the .tga and (native) .blp formats for images. Not .png - you'll need to convert your texture. Also, make sure that the dimensions of your texture are a power of two (ex: 2,4,8,16,32,etc). The width and height don't have to match, and it can be up to 1024 px, iirc.

I don't know when you want your texture shown/hidden, so I haven't included that part.

/edit: fixed path to texture to escape \

So all i would need is a texture:Show() when i want to display it after each Soundplay?
Any tips on the 5 second stuff before hiding the image again?

I thought Addon Studio would help me get started, but i think ill just use plain editors with markup instead.

killerpet1986 · 12-22-11, 04:52 PM

Originally Posted by Rugguggla

So all i would need is a texture:Show() when i want to display it after each Soundplay?
Any tips on the 5 second stuff before hiding the image again?

I thought Addon Studio would help me get started, but i think ill just use plain editors with markup instead.

You could try something like this: (not sure if its the most elegant solution, someone here might have a better one)

lua Code:

local UpdateTimer = 0; -- make an update timer that will count to 5
 
local UpdateFrame = CreateFrame("Frame"); -- create a frame that will update on a screen refresh
UpdateFrame:Hide(); -- hide the frame, it will not update when hidden
UpdateFrame:SetScript("Onupdate", function(self, update)
     UpdateTimer = UpdateTimer  + update; -- increment the UpdateTimer by the amount of time that has passed since the last update
     if UpdateTimer >= 5 then -- if 5 seconds have passed then
          frame:Hide() -- hide the image
          UpdateFrame:Hide(); -- hide the frame (to stop updating)
     end -- end if
end) -- close setscript
 
 
 
local frame = CreateFrame("Frame", nil, UIParent)
     frame:SetPoint("TOPLEFT", 567, -3)
     frame:SetSize(127, 136)     --this is an alias function to frame:SetWidth(127) and frame:SetHeight(136)
local texture = frame:CreateTexture()
     texture:SetTexture("Interface\\AddOns\\Consuela\\consuela")
     texture:SetAllPoints()     --we'll anchor all of the texture's corners to its parent's, the frame above
     texture:Hide()     --we'll hide this for now until you want it shown
 
local function eventHandler(self, event, ...)
     if event == "PLAYER_REGEN_DISABLED" then
          PlaySoundFile("Interface\\AddOns\\Consuela\\comeget.mp3")
          frame:Show() -- show the image
          UpdateTimer = 0; -- reset the timer
          UpdateFrame:Show(); -- show the frame to start the timer
     else
          PlaySoundFile("Interface\\AddOns\\Consuela\\pledge.mp3")
     end
end

Rugguggla · 12-22-11, 05:11 PM

hmm, the PLAYER_REGEN_DISABLED event doesnt seem to get triggered, even had some print text to doublecheck it.

ill fiddle around with it

thanks for giving me a push in the right direction!

killerpet1986 · 12-22-11, 05:27 PM

Originally Posted by Rugguggla

hmm, the PLAYER_REGEN_DISABLED event doesnt seem to get triggered, even had some print text to doublecheck it.

ill fiddle around with it

thanks for giving me a push in the right direction!

Take a look at http://www.wowwiki.com/API_Frame_RegisterEvent another good site is http://wowprogramming.com/docs/widge.../RegisterEvent if you still have problems after poking around a bit i can help you out more.

Rugguggla · 12-22-11, 05:35 PM

Cool! Thanks

Phanx · 12-22-11, 06:31 PM

Originally Posted by killerpet1986

You could try something like this: (not sure if its the most elegant solution, someone here might have a better one)

Your code won't work, since you're trying to call "frame" before it has been defined. You also don't need two frames; you can just use the one frame to listen for events (since frames still receive events while hidden) and run an OnUpdate script (since those only run when the frame is shown).

On a side note, giving your frame a global name can be helpful during development, since it enables you to access your addon using in-game slash commands (eg. "/run RuggugglasAddon:SetPoint("TOPLEFT", 400, 12)" to move the frame without having to edit the file and reload the UI).

This should generally work, unless I typo'd some syntax.

Lua Code:

local totalElapsed = 0 -- This will be used for the 5 second countdown.
 
local frame = CreateFrame("Frame", "RuggugglasAddon", UIParent)
frame:SetPoint("TOPLEFT", 567, -3)
frame:SetSize(127, 136)
frame:Hide() -- Hide the whole frame, not just the texture.
 
local texture = frame:CreateTexture(nil, "BACKDROP")
texture:SetTexture("Interface\\AddOns\\Consuela\\consuela")
texture:SetAllPoints()
 
frame:RegisterEvent("PLAYER_DEAD")
frame:RegisterEvent("PLAYER_REGEN_DISALBED")
 
frame:SetScript("OnUpdate", function(self, elapsed)
    -- This will automatically run every time a new
    -- video frame is rendered, but only while the
    -- frame is shown. Since the frame is hidden to
    -- begin with, it isn't running now.
    totalElapsed = totalElapsed + elapsed -- Update the timer.
    if totalElapsed > 5 then
        self:Hide()
        -- Hiding the frame automatically stops the
        -- OnUpdate script from running.
    end
end)
 
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_REGEN_DISALBED" then
        PlaySoundFile("Interface\\AddOns\\Consuela\\comeget.mp3")
        totalElapsed = 0 -- Reset the timer.
        self:Show()
        -- The OnUpdate script will automatically start
        -- running once the frame is shown.
    else
        -- If you add more events, you'll want to add more
        -- elseif event == "EVENT_NAME" then checks here.
        PlaySoundFile("Interface\\AddOns\\Consuela\\pledge.mp3")
    end
end)