COMBAT_LOG_EVENT_UNFILTERED help!

[skitspam]

Hello!
I am currently trying to make a simple addon which is supposed to get the name of the unit who killed another specific unit.

I have tried to use the COMBAT_LOG_EVENT_UNFILTERED event with the event UNIT_DIED to get the sourceName, but it always returns nil.

local frame = CreateFrame("FRAME", "MyAddonFrame");
frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");
function eventHandler(self, event, ...)

	if(event=="COMBAT_LOG_EVENT_UNFILTERED") then
		local time, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags=...
		if(event=="UNIT_DIED")then
			if(destName=="theUnit")then
				print(sourceName.." killed "..destName)
			end
		end
	end
end

Is there any way to get the sourceName by using this combatlog event? Or can I get the name in any other way?

[Nobgul]

Depending on what you are going to use this for. The only thing I can think of is.
Use UNIT_HEALTH If it is <0 then the unit is dead find the killing blow or spell then save the name of the person who delt it in a table for later use?

[Nobgul]

Also check out UNITGUID.

It may be a way to grab the players name.

[Ketho]

UNIT_DIED doesn't show who killed it

UNIT_DIED,0x0000000000000000,nil,0x80000000,0xF130AF290001BAC9,"Blight Beast",0xa48

You could check for overkill events though:

local function OnEvent(self, event, ...)
   local _, subevent, _, sourceName, _, _, destName, _, prefixParam1, prefixParam2, _, suffixParam1, suffixParam2 = ...
 
   if (subevent == "SPELL_DAMAGE" or subevent == "SPELL_PERIODIC_DAMAGE" or subevent == "RANGE_DAMAGE") and suffixParam2 > 0 then
      print("["..sourceName.."] killed ["..destName.."] with "..suffixParam1.." "..GetSpellLink(prefixParam1))
   elseif subevent == "SWING_DAMAGE" and prefixParam2 > 0 then
      print("["..sourceName.."] killed ["..destName.."] with "..prefixParam1.." Melee")
   end
end
 
local f = CreateFrame("Frame")
f:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
f:SetScript("OnEvent", OnEvent)

This example won't account for multiple timed killing blows on the same unit ..

btw I'm not actually using any format(), but I know I should ><

[skitspam]

Originally Posted by Ketho UNIT_DIED doesn't show who killed it UNIT_DIED,0x0000000000000000,nil,0x80000000,0xF130AF290001BAC9,"Blight Beast",0xa48 You could check for overkill events though: local function OnEvent(self, event, ...)    local _, subevent, _, sourceName, _, _, destName, _, prefixParam1, prefixParam2, _, suffixParam1, suffixParam2 = ...      if (subevent == "SPELL_DAMAGE" or subevent == "SPELL_PERIODIC_DAMAGE" or subevent == "RANGE_DAMAGE") and suffixParam2 > 0 then       print("["..sourceName.."] killed ["..destName.."] with "..suffixParam1.." "..GetSpellLink(prefixParam1))    elseif subevent == "SWING_DAMAGE" and prefixParam2 > 0 then       print("["..sourceName.."] killed ["..destName.."] with "..prefixParam1.." Melee")    end end   local f = CreateFrame("Frame") f:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED") f:SetScript("OnEvent", OnEvent) This example won't account for multiple timed killing blows on the same unit .. btw I'm not actually using any format(), but I know I should ><

Yea. This works the way I want it to!
Thanks for the fast answer!

[skitspam]

Actually, I recieved alot of errors because of comparing a nil value with a number (the suffixParam2), but it was easily avoidable by first checking whether the value is nil or not.

if(suffixParam2~=nil)then
	DoStuff()
end