Twitter bug

VikingP · 03-20-15, 09:44 AM

Im using a UI that it's not been updated, but i would like to keep using it.
So looking for some help to see if i can fix this.
Have little lua skills. Tested a few things without any luck.
It's ShestakUI, https://github.com/Shestak/ShestakUI

Here is how the copyurl.lua looks like:

Lua Code:

local T, C, L, _ = unpack(select(2, ...))
if C.chat.enable ~= true then return end
 
----------------------------------------------------------------------------------------
--  Copy url from chat(module from Gibberish by p3lim)
----------------------------------------------------------------------------------------
local patterns = {
    "(https://%S+)",
    "(http://%S+)",
    "(www%.%S+)",
    "(%d+%.%d+%.%d+%.%d+:?%d*)"
}
 
for _, event in pairs({
    "CHAT_MSG_GUILD",
    "CHAT_MSG_PARTY",
    "CHAT_MSG_PARTY_LEADER",
    "CHAT_MSG_RAID",
    "CHAT_MSG_RAID_LEADER",
    "CHAT_MSG_CHANNEL",
    "CHAT_MSG_WHISPER",
    "CHAT_MSG_BN_WHISPER",
    "CHAT_MSG_SAY",
    "CHAT_MSG_INSTANCE_CHAT",
    "CHAT_MSG_INSTANCE_CHAT_LEADER"
}) do
    ChatFrame_AddMessageEventFilter(event, function(self, event, str, ...)
        for _, pattern in pairs(patterns) do
            local result, match = string.gsub(str, pattern, "|cff00FF00|Hurl:%1|h[%1]|h|r")
            if match > 0 then
                return false, result, ...
            end
        end
    end)
end
 
local orig = SetItemRef
function SetItemRef(link, str, ...)
    if string.sub(link, 1, 3) ~= "url" then return orig(link, str, ...) end
 
    local editbox = ChatEdit_ChooseBoxForSend()
    ChatEdit_ActivateChat(editbox)
    editbox:Insert(string.sub(link, 5))
    editbox:HighlightText()
end

Error:

Lua Code:

Message: ...rface\AddOns\Blizzard_SocialUI\Blizzard_SocialUI.lua:119: Attempt to access forbidden object from code tainted by an AddOn
Time: 03/20/15 16:44:01
Count: 13
Stack: [C]: in function `Show'
...rface\AddOns\Blizzard_SocialUI\Blizzard_SocialUI.lua:119: in function `SocialPostFrame_ShowScreenshot'
Interface\FrameXML\ItemRef.lua:249: in function <Interface\FrameXML\ItemRef.lua:1>
(tail call): ?
(tail call): ?
...ace\AddOns\Blizzard_CombatLog\Blizzard_CombatLog.lua:3602: in function `SetItemRef'
Interface\FrameXML\ChatFrame.lua:3374: in function `ChatFrame_OnHyperlinkShow'
[string "*:OnHyperlinkClick"]:1: in function <[string "*:OnHyperlinkClick"]:1>
 
Locals: (*temporary) = SocialPostFrame {
 0 = <userdata>
 TitleText = <unnamed> {
 }
 RightBorder = <unnamed> {
 }
 LeftBorder = <unnamed> {
 }
 ImageFrame = <unnamed> {
 }
 ShareIcon = <unnamed> {
 }
 EdgeArt-Right = <unnamed> {
 }
 TopRightCorner = <unnamed> {
 }
 TopLeftCorner = <unnamed> {
 }
 Bg = <unnamed> {
 }
 ScreenshotButton = <unnamed> {
 }
 TopBorder = <unnamed> {
 }
 PostButton = <unnamed> {
 }
 TopTileStreaks = <unnamed> {
 }
 TitleBg = <unnamed> {
 }
 BottomBorder = <unnamed> {
 }
 BotRightCorner = <unnamed> {
 }
 BorderFrame = <unnamed> {
 }
 SocialMessageFrame = SocialPostFrameMessageFrame {
 }
 CloseButton = <unnamed> {
 }
 Title = <unnamed> {
 }
 AchievementButton = <unnamed> {
 }
 BotLeftCorner = <unnamed> {
 }
 DragBar = <unnamed> {
 }
 EdgeArt-Left = <unnamed> {
 }
 ItemButton = <unnamed> {
 }
}

Any help or tip would be nice

Munglunch · 03-20-15, 10:04 AM

Whats happening is that the older method of parsing chat strings for hyperlinks has no protection from the new "share" linktype.

Try this

In your code:

Lua Code:

for _, event in pairs({
    "CHAT_MSG_GUILD",
    "CHAT_MSG_PARTY",
    "CHAT_MSG_PARTY_LEADER",
    "CHAT_MSG_RAID",
    "CHAT_MSG_RAID_LEADER",
    "CHAT_MSG_CHANNEL",
    "CHAT_MSG_WHISPER",
    "CHAT_MSG_BN_WHISPER",
    "CHAT_MSG_SAY",
    "CHAT_MSG_INSTANCE_CHAT",
    "CHAT_MSG_INSTANCE_CHAT_LEADER"
}) do
    ChatFrame_AddMessageEventFilter(event, function(self, event, str, ...)
        for _, pattern in pairs(patterns) do
            local result, match = string.gsub(str, pattern, "|cff00FF00|Hurl:%1|h[%1]|h|r")
            if match > 0 then
                return false, result, ...
            end
        end
    end)
end

You need to add this

Lua Code:

if(str:find("%pHshare%p+")) then return end

So re-written it will look like this:

Lua Code:

for _, event in pairs({
    "CHAT_MSG_GUILD",
    "CHAT_MSG_PARTY",
    "CHAT_MSG_PARTY_LEADER",
    "CHAT_MSG_RAID",
    "CHAT_MSG_RAID_LEADER",
    "CHAT_MSG_CHANNEL",
    "CHAT_MSG_WHISPER",
    "CHAT_MSG_BN_WHISPER",
    "CHAT_MSG_SAY",
    "CHAT_MSG_INSTANCE_CHAT",
    "CHAT_MSG_INSTANCE_CHAT_LEADER"
}) do
    ChatFrame_AddMessageEventFilter(event, function(self, event, str, ...)
        if(str:find("%pHshare%p+")) then return end
        for _, pattern in pairs(patterns) do
            local result, match = string.gsub(str, pattern, "|cff00FF00|Hurl:%1|h[%1]|h|r")
            if match > 0 then
                return false, result, ...
            end
        end
    end)
end

VikingP · 03-20-15, 12:52 PM

Thank you for trying, but that didn't solve it. Still same error.

Torhal · 03-20-15, 02:08 PM

Originally Posted by Munglunch

Lua Code:

for _, event in pairs({...}) do
    ChatFrame_AddMessageEventFilter(event, function(self, event, str, ...)
        if(str:find("%pHshare%p+")) then return end

Yeah...no. Terminating the entire iteration when finding "share" won't do anything remotely bad...

VikingP · 03-20-15, 04:28 PM

Originally Posted by Torhal

Yeah...no. Terminating the entire iteration when finding "share" won't do anything remotely bad...

Joke? didn't get that 1

Torhal · 03-20-15, 05:20 PM

Originally Posted by VikingP

Joke? didn't get that 1

I was just pointing out that using the solution you were given would actually break things worse than what they are.

VikingP · 03-20-15, 07:08 PM

Originally Posted by Torhal

I was just pointing out that using the solution you were given would actually break things worse than what they are.

Ahh

Above my skills

Credit for trying atleast!

Munglunch · 03-20-15, 07:36 PM

Originally Posted by Torhal

I was just pointing out that using the solution you were given would actually break things worse than what they are.

That's weird, I could have sworn that in the native function ChatFrame_MessageEventHandler (ChatFrame.lua @line 2913), while parsing/executing chat filters (ChatFrame.lua @line 2929) will initially check the first return value for anything that evaluates (ie... anything OTHER than false or nil).

...But that would mean that my solution would cause NO HARM AT ALL, ..... so ... that can't be right. Right?

Actually, posting anything other than a possible solution to the problem presented is in fact making "things worse than what they are".

Torhal · 03-20-15, 08:28 PM

I don't have the solution, because I didn't fully look at the code, but when you're iterating over things to set them up, terminating the iteration altogether instead of gracefully handling it will lead to a bad state. So, if "share" was found for "CHAT_MSG_PARTY" the others that came after would never have the filter applied, even if they should. That's not causing no harm at all, it is in fact making things worse. I'm not trying to pick a fight here; I was merely pointing out that there was a logic error in case you wanted to re-address.

I'll refrain from being helpful now.

10leej · 03-20-15, 11:12 PM

Wait....... WoW has twitter now? Is this recent?

/derailed

VikingP · 03-21-15, 04:33 AM

Originally Posted by 10leej

Wait....... WoW has twitter now? Is this recent?

/derailed

Since 6.1
http://www.wowhead.com/guide=2957/how-to-tweet-in-game

Lombra · 03-21-15, 06:05 AM

Originally Posted by Torhal

I don't have the solution, because I didn't fully look at the code, but when you're iterating over things to set them up, terminating the iteration altogether instead of gracefully handling it will lead to a bad state. So, if "share" was found for "CHAT_MSG_PARTY" the others that came after would never have the filter applied, even if they should. That's not causing no harm at all, it is in fact making things worse. I'm not trying to pick a fight here; I was merely pointing out that there was a logic error in case you wanted to re-address.

I'll refrain from being helpful now.

The return is inside the function!

Torhal · 03-21-15, 12:38 PM

Originally Posted by Lombra

The return is inside the function!

And this is why I generally don't write replies when I just skim code. Yay.

Munglunch · 03-21-15, 04:08 PM

Originally Posted by Torhal

And this is why I generally don't write replies when I just skim code. Yay.

Torhal, I'm sorry for the way that I worded that post, it was unnecessary and unprofessional.

... And that is why I generally don't write replies when I am in a bad mood. Bad Mung!

Torhal · 03-21-15, 06:13 PM

Originally Posted by Munglunch

Torhal, I'm sorry for the way that I worded that post, it was unnecessary and unprofessional.

... And that is why I generally don't write replies when I am in a bad mood. Bad Mung!

It's all good. I still have all my limbs. I think. Damn it!

VikingP · 03-21-15, 08:21 PM

Nice of you all to kiss and make up

After 4 hours i found a solution (error was also caused from 2 other files altinvite and multitip)

Here is how it ended up.

Lua Code:

local T, C, L, _ = unpack(select(2, ...))
if C.chat.enable ~= true then return end
 
----------------------------------------------------------------------------------------
--  Copy url from chat(module from Gibberish by p3lim)
----------------------------------------------------------------------------------------
local patterns = {
    "(https://%S+)",
    "(http://%S+)",
    "(www%.%S+)",
    "(%d+%.%d+%.%d+%.%d+:?%d*)"
}
 
for _, event in pairs({
    "CHAT_MSG_GUILD",
    "CHAT_MSG_PARTY",
    "CHAT_MSG_PARTY_LEADER",
    "CHAT_MSG_RAID",
    "CHAT_MSG_RAID_LEADER",
    "CHAT_MSG_CHANNEL",
    "CHAT_MSG_WHISPER",
    "CHAT_MSG_BN_WHISPER",
    "CHAT_MSG_SAY",
    "CHAT_MSG_INSTANCE_CHAT",
    "CHAT_MSG_INSTANCE_CHAT_LEADER",
    "CHAT_MSG_BATTLEGROUND_LEADER",
    "CHAT_MSG_BN_CONVERSATION",
    "CHAT_MSG_RAID_WARNING",
    "CHAT_MSG_OFFICER",
    "CHAT_MSG_BATTLEGROUND",
    "CHAT_MSG_YELL"
}) do
    ChatFrame_AddMessageEventFilter(event, function(self, event, str, ...)
        for _, pattern in pairs(patterns) do
            local result, match = string.gsub(str, pattern, "|cff00FF00|Hurl:%1|h[%1]|h|r")
            if match > 0 then
                return false, result, ...
            end
        end
    end)
end
 
local SetHyperlink = _G.ItemRefTooltip.SetHyperlink
function _G.ItemRefTooltip:SetHyperlink(link, ...)
    if link and (strsub(link, 1, 3) == "url") then
        local url = strsub(link, 5)
        
        local editbox = ChatEdit_ChooseBoxForSend()
        ChatEdit_ActivateChat(editbox)
        editbox:Insert(string.sub(link, 5))
        editbox:HighlightText()
        
        return
     end
     
     SetHyperlink(self, link, ...)
end