A fix? WorldMapBlobFrame taint issues.

[Grimsin]

I think i have come up with a fix for the infamous worldmapblobframe. Now the only problem with it is that when you leave combat it will automaticlly turn on quest tracking on the WorldMap. I always have mine on so to me this is not a big issue. I think somehow one could add a GetChecked to the begining and store a variable then use the variable to make the exiting combat function load your checked state accordingly. But for the most part this will fix any of the WorldMapBlobFrame issues when it comes to toggling the worldmap in combat for any reason via an addon.

local GUIWorldMapEvents = CreateFrame("Frame", nil, UIParent)
GUIWorldMapEvents:RegisterEvent("PLAYER_ENTERING_WORLD")
GUIWorldMapEvents:RegisterEvent("PLAYER_REGEN_ENABLED") 
GUIWorldMapEvents:RegisterEvent("PLAYER_REGEN_DISABLED")
 
GUIWorldMapEvents:SetScript("OnEvent", function(self)
    if event == "PLAYER_ENTERING_WORLD" then
        ShowUIPanel(WorldMapFrame)
        HideUIPanel(WorldMapFrame)
    
    elseif event == "PLAYER_REGEN_DISABLED" then
        WatchFrame.showObjectives = nil;
        WorldMapQuestShowObjectives:SetChecked(false)
        WorldMapQuestShowObjectives:Hide()
        WorldMapTrackQuest:Hide()
        WorldMapTitleButton:Hide()
        WorldMapFrameSizeUpButton:Hide()
        WorldMapBlobFrame:Hide()
        WorldMapPOIFrame:Hide()
        
        WorldMapFrameSizeUpButton.Show = GrimUI.Dummy
        WorldMapQuestShowObjectives.Show = GrimUI.Dummy
        WorldMapTrackQuest.Show = GrimUI.Dummy
        WorldMapTitleButton.Show = GrimUI.Dummy
        WorldMapBlobFrame.Show = GrimUI.Dummy
        WorldMapPOIFrame.Show = GrimUI.Dummy
        
        
        WatchFrame_Update();
    
    elseif event == "PLAYER_REGEN_ENABLED" then
        
        WorldMapFrameSizeUpButton.Show = WorldMapFrameSizeUpButton:Show()
        WorldMapQuestShowObjectives.Show = WorldMapQuestShowObjectives:Show()
        WorldMapTrackQuest.Show = WorldMapTrackQuest:Show()
        WorldMapTitleButton.Show = WorldMapTitleButton:Show()
        WorldMapBlobFrame.Show = WorldMapBlobFrame:Show()
        WorldMapPOIFrame.Show = WorldMapPOIFrame:Show()
        
        WatchFrame.showObjectives = true;
        WorldMapQuestShowObjectives:SetChecked(true)
 
        WorldMapQuestShowObjectives:Show()
        WorldMapTrackQuest:Show()
        WorldMapTitleButton:Show()
        WorldMapFrameSizeUpButton:Show()
        WorldMapBlobFrame:Show()
        WorldMapPOIFrame:Show()
        
        WatchFrame_Update();
    end
end)

[Grimsin]

Also note that there is an issue if you go into combat with the worldmap in the large mode... not sure yet how to force small mode in combat...

[Grimsin]

Here is a final version, you would of course have to setup the variables part but otherwise cut and paste. Full functioning, what it does is it turns off all the quest tracking and objectives on the WorldMap when you enter combat then turns it all back on according to what you had selected before going into combat. It will also close the Map apon entering combat, this was done so that if you had the map in fullsize mode it would close and resize it to small mode so that you could then reopen while in combat if need be.

This will fix taint issues in DHUD, PocketPlot and others and of course can be found in the GrimUI to fix my own worldmap button problem

In theory should fix any taint issues with any addons call to the worldmap. Should alleviate tainting on addons calling worldmap frame for position functions. In theory...

--##############################################################################
--##    WorldMapBlobFrame and Combat taint on WorldMap toggles fix    START   ##
--##############################################################################
 
local GUIWorldMapEvents = CreateFrame("Frame", nil, UIParent)
GUIWorldMapEvents:RegisterEvent("PLAYER_ENTERING_WORLD")
GUIWorldMapEvents:RegisterEvent("PLAYER_REGEN_ENABLED") 
GUIWorldMapEvents:RegisterEvent("PLAYER_REGEN_DISABLED")
 
GUIWorldMapEvents:SetScript("OnEvent", function(self)
    local CurrentTrackState = WorldMapQuestShowObjectives:GetChecked()
    
    if event == "PLAYER_ENTERING_WORLD" then
        ShowUIPanel(WorldMapFrame)
        HideUIPanel(WorldMapFrame)
    
    elseif event == "PLAYER_REGEN_DISABLED" then
        
         
        if CurrentTrackState == 1 then
        GrimUIData.WorldMapQuestTrack = true
        elseif CurrentTrackState == nil then
        GrimUIData.WorldMapQuestTrack = false
        end
        
        HideUIPanel(WorldMapFrame)
        WorldMap_ToggleSizeDown()
        WatchFrame.showObjectives = nil;
        WorldMapQuestShowObjectives:SetChecked(false)
        WorldMapQuestShowObjectives:Hide()
        WorldMapTrackQuest:Hide()
        WorldMapTitleButton:Hide()
        WorldMapFrameSizeUpButton:Hide()
        WorldMapBlobFrame:Hide()
        WorldMapPOIFrame:Hide()
        
        WorldMapFrameSizeUpButton.Show = GrimUI.Dummy
        WorldMapQuestShowObjectives.Show = GrimUI.Dummy
        WorldMapTrackQuest.Show = GrimUI.Dummy
        WorldMapTitleButton.Show = GrimUI.Dummy
        WorldMapBlobFrame.Show = GrimUI.Dummy
        WorldMapPOIFrame.Show = GrimUI.Dummy
        
        
        WatchFrame_Update();
    
    elseif event == "PLAYER_REGEN_ENABLED" then
        
        WorldMapFrameSizeUpButton.Show = WorldMapFrameSizeUpButton:Show()
        WorldMapQuestShowObjectives.Show = WorldMapQuestShowObjectives:Show()
        WorldMapTrackQuest.Show = WorldMapTrackQuest:Show()
        WorldMapTitleButton.Show = WorldMapTitleButton:Show()
        WorldMapBlobFrame.Show = WorldMapBlobFrame:Show()
        WorldMapPOIFrame.Show = WorldMapPOIFrame:Show()
        
 
        WorldMapQuestShowObjectives:Show()
        WorldMapTitleButton:Show()
        WorldMapFrameSizeUpButton:Show()
        
        
        if GrimUIData.WorldMapQuestTrack == true then
            
            WatchFrame.showObjectives = true
            WorldMapQuestShowObjectives:SetChecked(true)
            
            WorldMapTrackQuest:Show()
            WorldMapBlobFrame:Show()
            WorldMapPOIFrame:Show()
            
            WatchFrame_Update();
        end
        
        if GrimUIData.WorldMapQuestTrack == false then
            
            WatchFrame.showObjectives = nil
            WorldMapQuestShowObjectives:SetChecked(false)
        end
        
        
        
        
 
    end
end)
 
--############################################################################
--##    WorldMapBlobFrame and Combat taint on WorldMap toggles fix    END   ##
--############################################################################

[Guardix]

You do know that Mapster has a workaround, which looks a bit like yours ?

[Grimsin]

really? i did not but that does not surprise me. i found the problem in a lot of addons when trying to figure out why it was happening with my own code... eventually i wrote this workaround which should work with any addon. should mind you.

I did think one thing that could be added is to check weather or not the full size quest view is open or not and decide about closing in combat based on that. the only reason the force close on combat enter was to compensate for people who might have that full view version open when they go into combat. If you dont force close and toggle to the small view when its reopened after combat its all kinds of funny. That though is the only change i think i would make to this... i imagine what is in mapster might be a bit better. If you really wanted to dig into the bliz code there might be an even better way that allows you to still have the quest objectives and such open since in making this i noticed it wasnt the frame itself being open but rather the quest objectives locations on the worldmap frame itself being updated is what causes the taint. Im not quite that advanced yet but maybe some secure code for opening the worldmap would be better in fact it was referenced to me at one point... one thing i know about the secure code is :Show and :Hide fire hmmmm.... interesting so it just dawned on me that using a secure toggle for show hide fires an x/y calculation error but if you toggle the map out of combat via some normal nonsecure method IE ShowUIPanel or Toggle or how you want to do it that it will then work useing the secure button SOOO maybe an easier and better way would be to create the secure toggle function then on player entering world have it do the show hide on the map real quick as the code does currently and then you would technically be able to use the secure toggle method with no problems.

i will test this and see if it works but anyhow for now this is here for anyone whos interested

edit - oh it dawned on me to why i cant use or at lest i have not figured out how to use the secure method... it requires a secure frame be overlayed on the minimap and when i do this i lose the tooltips for minimap POI's... im sure there is a work around for that to but... It would work if you were just making a button and not overlaying rightclick on the minimap as i have done...