Force show cooldown text

[tehmoku]

Does anyone know a way to force enable showing of *Blizzard* cooldown text per cooldown frame?

In other words, I want to have the option "Show Numbers for Cooldowns" disabled, but force it to show on specific cooldown frames I have access to.

Currently I'm just creating my own text handler per frame, but it would be much nicer for consistency to use Blizzard's.

Edit:

For some clarity, here's what I mean:

local f = CreateFrame("Button", nil, UIParent, "CompactAuraTemplate")
f:SetSize(40, 40)
f:SetPoint("CENTER", 0, 0)
 
f.icon:SetTexture("Interface\\Icons\\spell_holy_divineillumination")
 
f.cooldown.text = f.cooldown:CreateFontString(nil, "OVERLAY", "GameFontNormal")
f.cooldown.text:SetFont("Fonts\\FRIZQT__.TTF", 15, "OUTLINE")
f.cooldown.text:SetPoint("CENTER", 0, 0)
 
f.cooldown:SetHideCountdownNumbers(false)
 
f:SetScript("OnClick", function(self)
    CooldownFrame_Set(self.cooldown, GetTime(), 10, 1)
end)

Here's a button with a cooldown that will go on CD when clicked. For reference, I have up potentially hundreds of these.

Currently how I'm handling them is this:

local timeElapsed = 0
f.cooldown:SetScript("OnUpdate", function(self, elapsed)
    timeElapsed = timeElapsed + elapsed
    if timeElapsed > 0.2 then
        local start, dur = self:GetCooldownTimes()
        local timeLeft = start / 1000 + dur / 1000 - GetTime()
 
        if timeLeft >= 1 then
            self.text:SetText(format("%d", timeLeft))
        else
            self.text:SetText("")
        end
 
        timeElapsed = 0
    end
end)

But I'm wondering if there's a way to force this button to show blizzard text even with the setting disabled.

[SDPhantom]

Taint-free solution:

local LockShowCountdownNumbers; do
    local function ReshowCountdownNumbers(cooldown)
--      Call the real function still in the frame's metatable
        getmetatable(cooldown).__index.SetHideCountdownNumbers(cooldown, false)
    end
 
    function LockShowCountdownNumbers(cooldown, lock)
        if lock then
--          We use hooksecurefunc() to prevent taint
--          A quirk of this is it copies the original function from the metatable and stores our hooked version in the frame's actual table
--          This still performs what we want and setting the entry to nil will restore the original operation
            hooksecurefunc(cooldown, "SetHideCountdownNumbers", ReshowCountdownNumbers)
        else
            cooldown.SetHideCountdownNumbers = nil;--   Clear table entry, allowing fallback to frame metatable
        end
    end
end

--  Test setup
local f = CreateFrame("Button", nil, UIParent, "CompactAuraTemplate")
f:SetSize(40, 40)
f:SetPoint("CENTER", 0, 0)
 
f.icon:SetTexture("Interface\\Icons\\spell_holy_divineillumination")
 
LockShowCountdownNumbers(f.cooldown, true)--    Call our function
f.cooldown:SetHideCountdownNumbers(false)-- Test the lock
 
f:SetScript("OnClick", function(self)
    CooldownFrame_Set(self.cooldown, GetTime(), 10, 1)
end)

If you don't care about taint, then you could just set the table entry to nop(), which is an empty function defined in UIParent.lua. Just like the taint-free code, you can set this back to nil to restore operation since the actual function is in the frame's metatable.

f.coolodown.SetHideCountdownNumbers = nop

[tehmoku]

It seems this solution isn't working for me.

I may definitely be missing something, or perhaps I misrepresented my problem. It seems that this forces cooldown text to show even when the text is disabled by SetHideCountdownNumbers(true), and for that it works wonderfully. But I'm looking to know if there's a way to show the cooldown text when it is globally disabled by SetCVar("countdownForCooldowns", false)

With that CVar disabled the text still doesn't show using your solution.

[SDPhantom]

Can't really think of any other way besides what you've already done. There could be a little optimization with your math, but that's more nitpicking on trimming the number of operations you're using than anything you'd actually notice.

[tehmoku]

Yeah, I was worried this is handled entirely on the C side of things. I was hoping that somebody smarter than I had a silver bullet though.

I would like to see your optimizations though. I threw it together pretty quick, and I can already see at least one thing I'd change, but I might as well optimize as much as I can if I'm going to handle the numbers myself (although I don't know if that's specifically worth it...)

[SDPhantom]

Originally Posted by tehmoku I would like to see your optimizations though. I threw it together pretty quick, and I can already see at least one thing I'd change, but I might as well optimize as much as I can if I'm going to handle the numbers myself (although I don't know if that's specifically worth it...)

The first thing that stood out to me was this line.

local timeLeft = start / 1000 + dur / 1000 - GetTime()

Currently, you're taking one variable, dividing by 1000, then taking another variable and doing the same before adding them together. You can save a divide operation by adding the variables together before dividing by 1000.

local timeLeft = (start + dur) / 1000 - GetTime()

A second thing I'd note is FontStrings have a built-in format function that works in the same way, you can save a global index and a function call by using it instead. Even if C code does the exact same thing, remember, C code processes much faster natively than Lua code can.

self.text:SetFormattedText("%d", timeLeft)

Again, and at the scale of once every 200ms, you're not really going to see a difference.

[tehmoku]

Originally Posted by SDPhantom local timeLeft = (start + dur) / 1000 - GetTime()

Yeah, this was the thing that immediately stood out to me when I re-looked it over, haha.

Originally Posted by SDPhantom A second thing I'd note is FontStrings have a built-in format function that works in the same way, you can save a global index and a function call by using it instead. Even if C code does the exact same thing, remember, C code processes much faster natively than Lua code can. self.text:SetFormattedText("%d", timeLeft)

This one I actually didn't know though, so thank you!

Originally Posted by SDPhantom Again, and at the scale of once every 200ms, you're not really going to see a difference.

What fun is coding if you aren't unnecessarily harsh on yourself about efficiency?

[SDPhantom]

Originally Posted by tehmoku What fun is coding if you aren't unnecessarily harsh on yourself about efficiency?

I used to get a rush from making an idea work, but the dopamine from that has faded long ago. I still enjoy a good problem to solve for entertainment. At least an effort to keep the old brain working in comparison to the mundacity that is everything else.

Basically the definition of a hobby at this point.