Fix run a slash command from a button

[Walkerbo]

Hi all

I had a button that ran a slash command;

local NewbDevBoxButtonFrameREHackButton =
    CreateFrame(
    "Button",
    "NewbDevBoxButtonFrameREHackButton",
    NewbDevBoxButtonFrame,
    "SecureActionButtonTemplate, GameMenuButtonTemplate"
)
NewbDevBoxButtonFrameREHackButton:SetSize(NumberList.actionButtonWidth, NumberList.actionButtonHeight)
NewbDevBoxButtonFrameREHackButton:SetText(TextStringList.btnREHackButton)
NewbDevBoxButtonFrameREHackButton:SetNormalFontObject(TextDimensionList.buttonFont)
NewbDevBoxButtonFrameREHackButton:SetHighlightFontObject(TextDimensionList.buttonFont)
NewbDevBoxButtonFrameREHackButton:SetAttribute("type", "macro")
NewbDevBoxButtonFrameREHackButton:SetAttribute("macrotext", "/hack")

This was broken on the launch of pre-patch.
How do I get this working again?

[Xrystal]

What error does it report ?
Which of the lines does it say is/are the problem ?

It's possible the templates you are using no longer exist so you might have to identify an alternative if that is the case.

[Walkerbo]

Sorry, I should have said.

I get no errors at all.
The button template still works for other buttons such as the reload UI button.

[Fizzlemizz]

Is Hack (or whatever /hack is supposed to call), still in your AddOns, still enabled, ...

[Xrystal]

Just copied your code and changed it to work on my game and the following works... hopefully it may offer clues as to what might be making it not work for you.

I parented my version of the frame to UIParent as I don't have a frame to parent it to in my testaddon. I then set it's point in relation to it's parent. I then hardcoded the size, text, fonts and the macro to use.

local NewbDevBoxButtonFrameREHackButton =
    CreateFrame(
    "Button",
    "NewbDevBoxButtonFrameREHackButton",
    UIParent,
    "SecureActionButtonTemplate, GameMenuButtonTemplate"
)
NewbDevBoxButtonFrameREHackButton:SetPoint("CENTER")
NewbDevBoxButtonFrameREHackButton:SetSize(30, 30)
NewbDevBoxButtonFrameREHackButton:SetText("Text")
NewbDevBoxButtonFrameREHackButton:SetNormalFontObject(GameFontNormal)
NewbDevBoxButtonFrameREHackButton:SetHighlightFontObject(GameFontWhite)
NewbDevBoxButtonFrameREHackButton:SetAttribute("type", "macro")
NewbDevBoxButtonFrameREHackButton:SetAttribute("macrotext", "/sit")

[Walkerbo]

@Fizzlemizz
Yes Hack is an addon and I have it operational, and I have tested it using its slash command in the chat box and I can confirm that it does work.

@Xrystal
Thanks for your code, however, I still get the same results, I don't sit when I click your button

[Fizzlemizz]

Register the button for AnyUp and AnyDown clicks.

[Xrystal]

Originally Posted by Walkerbo @Fizzlemizz Yes Hack is an addon and I have it operational, and I have tested it using its slash command in the chat box and I can confirm that it does work. @Xrystal Thanks for your code, however, I still get the same results, I don't sit when I click your button

Weird, my character sat as soon as I clicked the button.

Although I only had the bugcatching addons active at the time in case another addon is interfering.

[Fizzlemizz]

It depends on your setting for the CVar "ActionButtonUseKeyDown"

[Walkerbo]

@Fizzlemizz

Adding in the register for clicks worked!

It is amazing when I think that I am starting to get a handle on coding something like this pre-patch just comes along and slaps me down again.

I would be lost without the help I get from this community.

Thanks all

[SDPhantom]

Why not simplify it and not make it a SecureActionButton? With some digging around in Hack's code, you can find their slash handler.

This happens to be at line 183 of Hack.lua

SlashCmdList['HACKSLASH'] =
	function(name)
		if name == '' then
			Hack.Toggle()
		else
			Hack.Run(name)
		end
	end

You could just call SlashCmdList["HACKSLASH"](""), but further digging shows the table Hack is a global, meaning you can call Hack.Toggle() directly.

local NewbDevBoxButtonFrameREHackButton =
    CreateFrame(
    "Button",
    "NewbDevBoxButtonFrameREHackButton",
    NewbDevBoxButtonFrame,
    "GameMenuButtonTemplate"
)
NewbDevBoxButtonFrameREHackButton:SetSize(NumberList.actionButtonWidth, NumberList.actionButtonHeight)
NewbDevBoxButtonFrameREHackButton:SetText(TextStringList.btnREHackButton)
NewbDevBoxButtonFrameREHackButton:SetNormalFontObject(TextDimensionList.buttonFont)
NewbDevBoxButtonFrameREHackButton:SetHighlightFontObject(TextDimensionList.buttonFont)
NewbDevBoxButtonFrameREHackButton:SetScript("OnClick",function() if Hack then Hack.Toggle() end end)

[Uitat]

in project deranjata i came up wit this bit o code, it may help you

function AutoStart()--[[name this whatever your button will activate]]--
        local editbox=ChatEdit_ChooseBoxForSend(DEFAULT_CHAT_FRAME);--Get an editbox
        ChatEdit_ActivateChat(editbox);--  Show the editbox
        editbox:SetText("/der");--[[ Command goes here]]
        ChatEdit_OnEnterPressed(editbox);--[[ Process command and hide (runs ChatEdit_SendText() and ChatEdit_DeactivateChat() respectively)]]--
end