Thread Tools Display Modes
10-14-14, 12:27 PM   #121
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Guild levels are gone. However, I haven't been in a guild since Wrath, so beyond reading patch notes I have no ability to test any Mass Res stuff myself. Feel free to ping me on Skype if you need help testing stuff.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Donít message me about addon bugs or programming questions.
  Reply With Quote
10-16-14, 08:42 AM   #122
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Nothing seems to need an actual update for 6.0, so if I don't get any reports by the weekend I'll just bump the TOC and call it good.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Donít message me about addon bugs or programming questions.
  Reply With Quote
10-16-14, 10:18 AM   #123
myrroddin
A Pyroguard Emberseer
 
myrroddin's Avatar
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 1,243
Sounds fine to me. As I mentioned, I'm not getting any LRI error reports. I did get an unrelated SR2 error report (fixed), and I still have the one mentioned above.

The second isn't LRI; I'm certain it is something on how I'm using one or two of the APIs. Unfortunately, it looks like the next time I can log in won't be until the weekend. I will ping you on Skype then.
  Reply With Quote
07-31-16, 01:14 AM   #124
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2007
Posts: 1,710
Updated my old healer raidframes, they now sport a custom resurrecticon element powered by this library, will let you know if I stumble upon anything while using it.

https://github.com/p3lim-wow/oUF_Kri.../Resurrect.lua
  Reply With Quote
07-31-16, 09:46 AM   #125
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Thanks. I saw your other thread about the mass-res spells not firing events, but I think that was the case with the old guild perk Mass Res too. At least, when I had a friend's paladin come repeatedly res my level 1 trial account alt while updating LRI for Legion, their mass res spells were detected without issue. I admit I don't actually remember offhand how LRI is handling that stuff internally, though, so I definitely appreciate a heads-up if anything is behaving oddly.

The only issue I noticed in my (admittedly brief) testing is that if the player casting the mass res is near the 100-yard boundary, events are kind of unreliable... you can get an event when they start casting, but no event when they cancel the cast, for example, causing LRI to get stuck thinking they're casting forever. I didn't bother addressing this, though, as I figured it was unlikely to come up in actual gameplay.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Donít message me about addon bugs or programming questions.
  Reply With Quote
08-02-16, 05:09 AM   #126
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2007
Posts: 1,710
Sometimes when the target getting ressed is out of range, once the target accepts the res the icon of my element gets stuck (no callbacks or methods reporting incorrectly, most likely the former).

I've registered UNIT_HEALTH while the icon is shown in my element just in case, seems to work fine.
  Reply With Quote
08-02-16, 01:55 PM   #127
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
There is a nil global leak at line 425 caleld casterGUID.

Ever tought about addon an extra checker for mass-resurrects by:

Lua Code:
  1. IsItemInRange(41058, unit)

This should be a 100 yard range friendly checker item.

I'm building a similar party resurrect info tool myself, and i think i'll use this.

Last edited by Resike : 08-02-16 at 02:47 PM.
  Reply With Quote
08-03-16, 06:31 AM   #128
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Originally Posted by p3lim View Post
Sometimes when the target getting ressed is out of range, once the target accepts the res the icon of my element gets stuck (no callbacks or methods reporting incorrectly, most likely the former). I've registered UNIT_HEALTH while the icon is shown in my element just in case, seems to work fine.
Can you enable debugging ("/lri 2" should be sufficient, you can use "/lri ChatFrame5" to change where it's printed) and let me know what's printed in this situation? LRI currently uses UNIT_FLAGS, which used to fire when a player went from dead to alive or vice versa, but maybe that has a shorter range than UNIT_HEALTH, or doesn't work for that purpose at all anymore. This situation should definitely be handled correctly in LRI.

Originally Posted by Resike View Post
There is a nil global leak at line 425 caleld casterGUID.
Fixed, thanks, though you may want to double-check your version; there wasn't a casterGUID on line 425 in the current version.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Donít message me about addon bugs or programming questions.
  Reply With Quote
08-03-16, 10:48 AM   #129
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
Originally Posted by Phanx View Post
Fixed, thanks, though you may want to double-check your version; there wasn't a casterGUID on line 425 in the current version.
I downloaded this version:
https://wow.curseforge.com/addons/li...o/files/15-24/
  Reply With Quote
08-03-16, 12:36 PM   #130
myrroddin
A Pyroguard Emberseer
 
myrroddin's Avatar
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 1,243
Phanx and I are trying to track down the spellIDs for Brazier of Awakening and Failure Detection Pylon.

Please take note, we want the spellIDs cast by these items, not the itemIDs (which are part of the URLs I linked).

Last edited by myrroddin : 08-03-16 at 12:36 PM. Reason: spelling and grammar
  Reply With Quote
08-03-16, 04:19 PM   #131
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Originally Posted by myrroddin View Post
Brazier of Awakening and Failure Detection Pylon. ... we want the spellIDs cast by these items
And to be more specific, the spell IDs for the spells cast by the objects these items summon. Wowhead lists the spell that summons the object, but not the spell the object casts. I made some reasonable guesses, but if anyone has these items and can confirm, that would be nice.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Donít message me about addon bugs or programming questions.
  Reply With Quote
08-03-16, 04:44 PM   #132
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
Originally Posted by Phanx View Post
And to be more specific, the spell IDs for the spells cast by the objects these items summon. Wowhead lists the spell that summons the object, but not the spell the object casts. I made some reasonable guesses, but if anyone has these items and can confirm, that would be nice.
http://i.imgur.com/W6u4ZOC.jpg

Also applies a buff with the same name and spell id:

8/4 00:39:59.148 SPELL_RESURRECT,Creature-0-3770-0-16292-94729-00002272B0,"Brazier of Awakening",0x2111,0x0,Player-1303-077A0AFD,"Resikehunter-GrimBatol",0x512,0x0,187777,"Reawaken",0x1
8/4 00:39:59.561 SPELL_AURA_APPLIED,Creature-0-3770-0-16292-94729-00002272B0,"Brazier of Awakening",0x2111,0x0,Player-1303-077A0AFD,"Resikehunter-GrimBatol",0x512,0x0,187777,"Reawaken",0x1,BUFF
8/4 00:40:59.491 SPELL_AURA_REMOVED,Creature-0-3770-0-16292-94729-00002272B0,"Brazier of Awakening",0xa28,0x0,Player-1303-077A0AFD,"Resikehunter-GrimBatol",0x512,0x0,187777,"Reawaken",0x1,BUFF

The other one only comes in Legion i can't test that.

Last edited by Resike : 08-03-16 at 04:56 PM.
  Reply With Quote
08-03-16, 06:27 PM   #133
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2007
Posts: 1,710
Might want to add Ancestral Protection Totem to your list if it's not already tracked.

Edit, CLEU results:

1470271529.335 SPELL_SUMMON false Player-1403-063012B1 Shammy 1297 0 Creature-0-3768-1-105-104818-0000229029 Ancestral Protection Totem 2600 0 207399 Ancestral Protection Totem 8
1470271541.363 SPELL_AURA_APPLIED false Player-1403-0645631B Victim 1298 0 Player-1403-0645631B Victim 1298 0 225080 Reincarnation 1 DEBUFF
1470271541.363 UNIT_DIED true nil -2147483648 -2147483648 Player-1403-0645631B Victim 1298 0 -1 false
1470271637.048 SPELL_CAST_SUCCESS false Player-1403-0645631B Victim 1298 0 nil -2147483648 -2147483648 207553 Totemic Revival 8



Edit2, UNIT_SPELLCAST_SUCCEEDED output so you know when to register CLEU:

UNIT_SPELLCAST_SUCCEEDED player Ancestral Protection Totem 3-3768-1-105-207399-001FA2945E 207399

Last edited by p3lim : 08-03-16 at 07:04 PM.
  Reply With Quote
08-03-16, 06:54 PM   #134
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2007
Posts: 1,710
The other issue I mentioned seems to be related to dungeons, not easy to test.
  Reply With Quote
08-04-16, 05:44 AM   #135
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
Originally Posted by Resike View Post
http://i.imgur.com/W6u4ZOC.jpg

Also applies a buff with the same name and spell id:

8/4 00:39:59.148 SPELL_RESURRECT,Creature-0-3770-0-16292-94729-00002272B0,"Brazier of Awakening",0x2111,0x0,Player-1303-077A0AFD,"Resikehunter-GrimBatol",0x512,0x0,187777,"Reawaken",0x1
8/4 00:39:59.561 SPELL_AURA_APPLIED,Creature-0-3770-0-16292-94729-00002272B0,"Brazier of Awakening",0x2111,0x0,Player-1303-077A0AFD,"Resikehunter-GrimBatol",0x512,0x0,187777,"Reawaken",0x1,BUFF
8/4 00:40:59.491 SPELL_AURA_REMOVED,Creature-0-3770-0-16292-94729-00002272B0,"Brazier of Awakening",0xa28,0x0,Player-1303-077A0AFD,"Resikehunter-GrimBatol",0x512,0x0,187777,"Reawaken",0x1,BUFF

The other one only comes in Legion i can't test that.
I've looked into this, and it's seems like the only way to track who gets resurrected by this is to track the buff.
  Reply With Quote
08-04-16, 06:52 AM   #136
myrroddin
A Pyroguard Emberseer
 
myrroddin's Avatar
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 1,243
Hmm. Does it have a cast time? For that matter, do any of the items listed above have cast times?
  Reply With Quote
08-04-16, 07:22 AM   #137
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2007
Posts: 1,710
Originally Posted by myrroddin View Post
Hmm. Does it have a cast time? For that matter, do any of the items listed above have cast times?
The totem is an instant placement that buffs everyone within its radius with hp% increase. If one person dies to non-massive damage within that circle while the totem is up the totem gets consumed and the dead player receives an instant reincarnation (on the dead player's end it looks like as if they had reincarnation, it shows a 3rd button in the middle like for shamans).

Originally Posted by Resike View Post
I've looked into this, and it's seems like the only way to track who gets resurrected by this is to track the buff.
The same for the totem, you'd want to track the debuff with spellID 225080.
  Reply With Quote
08-04-16, 11:02 AM   #138
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Does the Brazier of Awakening trigger a SPELL_SUMMON combat event when the item is used? Is there a SPELL_CAST_SUCCESS combat event when it resurrects someone, or only the buff application?
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Donít message me about addon bugs or programming questions.
  Reply With Quote
08-04-16, 12:02 PM   #139
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
Originally Posted by Phanx View Post
Does the Brazier of Awakening trigger a SPELL_SUMMON combat event when the item is used? Is there a SPELL_CAST_SUCCESS combat event when it resurrects someone, or only the buff application?
Here is the full log:
https://gist.githubusercontent.com/R.../gistfile1.txt

The buff gets removed after 60 seconds, thats not on the log.
  Reply With Quote
08-05-16, 04:16 AM   #140
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
I've also tought about what happens if one person casts 2 resurrect spells at the same time? Like the brazier and the engineer one. The addon can't really handle that, so the table should also store the res spells by a subtable with the spellID key:

Lua Code:
  1. resTable[sourceGUID][spellID].targetGUID

Also another issue, what happens if the engineer jumper cable fails to resurrect? Then the CLEU stays registered forever for no reason. It should remove the res after the cast success +1-2 seconds with an OnUpdate or something.
  Reply With Quote

WoWInterface » AddOns, Compilations, Macros » Released AddOns » LibResInfo - resurrection info without comms

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off