Issue with :SetPoint() when moving objects

[Sweetsour]

Hello!

I'm having an issue with moving objects and keeping their positions on the screen when loading saved variables after reloading the UI.

Normal Layout


Layout after moving objects


Layout after reloading UI


Setting data to Saved Variables (after finishing with move)

point,_,relativePoint,x,y = LargeIconGrpTop:GetPoint(1);
Auras.db.char.frames.eleGrp.LargeIconGrpTopEle.point = point;
Auras.db.char.frames.eleGrp.LargeIconGrpTopEle.relativeTo = "AuraGroupEle";
Auras.db.char.frames.eleGrp.LargeIconGrpTopEle.relativePoint = relativePoint;
Auras.db.char.frames.eleGrp.LargeIconGrpTopEle.x = x;
Auras.db.char.frames.eleGrp.LargeIconGrpTopEle.y = y;

Setting Point(s) upon "Auras:OnEnable()"

local function InitializeGroup(group,width,height,point,relativeTo,relativePoint,x,y)
    if (width ~= nil) then
        group:SetWidth(width);
        group:SetHeight(height);
    end
    group:ClearAllPoints();
    --group:SetPoint(point,(SSA[relativeTo] or UIParent),relativePoint,x,y); (what I've also tried)
    group:SetPoint(point,x,y)
end
 
local dbEle = Auras.db.char.frames.eleGrp;
for groupObj in pairs(dbEle) do
    InitializeGroup(SSA[groupObj],dbEle[groupObj].width,dbEle[groupObj].height,dbEle[groupObj].point,SSA[dbEle[groupObj].relativeTo],dbEle[groupObj].relativePoint,dbEle[groupObj].x,dbEle[groupObj].y);
end

[Lombra]

Try:

group:SetDontSavePosition(true)

[Sweetsour]

Originally Posted by Lombra Try: group:SetDontSavePosition(true)

Hmm, doesn't seem to be making a difference

I should have posted my move start and end code:

Object:RegisterForDrag("LeftButton"); -- Forgot to add this in the intialization function
 
-- Enable Movement
Object:EnableMouse(true);
Object:SetMovable(true);
Object:SetUserPlaced(true); -- just tried this to no avail
Object:SetScript("OnDragStart", AuraObjects[i].StartMoving);
Object:SetScript("OnDragStop", AuraObjects[i].StopMovingOrSizing);
 
-- Disable Movement
Objects:EnableMouse(false);
Object:SetMovable(false);
Object:SetScript("OnDragStart", nil);
Object:SetScript("OnDragStop", nil);

[Banknorris]

Err, are you waiting for event ADDON_LOADED with arg1=="<your_addon_name>" before trying to set points from saved variables?

[Sweetsour]

Originally Posted by Banknorris Err, are you waiting for event ADDON_LOADED with arg1=="<your_addon_name>" before trying to set points from saved variables?

This was something I hadn't thought of. Though, after trying, there still wasn't any difference

I even tried running the :SetPoint() at "PLAYER_LOGIN" and still nothing.

[Seerah]

Why are you not using the relativeTo frame returned from GetPoint?

[Lombra]

Originally Posted by Sweetsour Hmm, doesn't seem to be making a difference I should have posted my move start and end code: Object:RegisterForDrag("LeftButton"); -- Forgot to add this in the intialization function   -- Enable Movement Object:EnableMouse(true); Object:SetMovable(true); Object:SetUserPlaced(true); -- just tried this to no avail Object:SetScript("OnDragStart", AuraObjects[i].StartMoving); Object:SetScript("OnDragStop", AuraObjects[i].StopMovingOrSizing);   -- Disable Movement Objects:EnableMouse(false); Object:SetMovable(false); Object:SetScript("OnDragStart", nil); Object:SetScript("OnDragStop", nil);

Do the same for Object instead. (assuming that's not the same frame) Then reload two times.

If you use AceAddon :OnEnable = PLAYER_LOGIN I believe, so that should be fine for using the saved variables. Ideally you'd do it at ADDON_LOADED, though.

[Sweetsour]

Originally Posted by Seerah Why are you not using the relativeTo frame returned from GetPoint?

I was getting strange results from trying to reference the parent object in the saved variables, so I just keep the parent's name in "relativeTo" part of my saved variables, then access the parent via SSA[relativeTo]

Originally Posted by Lombra Do the same for Object instead. (assuming that's not the same frame) Then reload two times. If you use AceAddon :OnEnable = PLAYER_LOGIN I believe, so that should be fine for using the saved variables. Ideally you'd do it at ADDON_LOADED, though.

Sorry, what do you mean by "the same for Object instead"? Also yes, it is the same frame

[Sweetsour]

I just realized something interesting.

In one of the pictures above, it shows the GetPoint values with "point" and "relativePoint" both as "BOTTOM". After further inspection, the row with Flame Shock, Earth Shock, Lava Burst, and Elemental Blast is in the correct location and its point and relativePoint are both still set to "CENTER" (as all the other icons groups' points are set to originally).

However, the two side icons and the other horizontal set of icons get set to "BOTTOM" during the move. It's only these object that have incorrect screen positions after reloading the UI.

[Sweetsour]

Another update:

I setup a script to run "OnUpdate" to display a specific object's :GetPoint() values in real-time as I drag the object. The moment the object becomes draggable, the "relativeTo" display the correct parent object. However, the moment I start dragging it, the "relativeTo" go to "nil". Not sure why this is happening =/

[Lombra]

Originally Posted by Sweetsour Another update: I setup a script to run "OnUpdate" to display a specific object's :GetPoint() values in real-time as I drag the object. The moment the object becomes draggable, the "relativeTo" display the correct parent object. However, the moment I start dragging it, the "relativeTo" go to "nil". Not sure why this is happening =/

That's because once you start dragging it, it clears all points and positions it relative to the UIParent. (or maybe its own parent, not sure)

Can you post some more code? Can't really tell what's going on from little bits of information here and there. I don't really understand what the exact issue is from the original post. I gather that there is some undesired positioning.

Frames that have a name will have their position automatically saved in layout-cache. (a file in the WTF folder that saves frame positions and dimensions) These values then get loaded and applied at some point in the loading process. (probably after ADDON_LOADED, maybe before PLAYER_LOGIN) This may override or conflict with any anchor points you want to explicitly set yourself. Doing frame:SetDontSavePosition(true) ensures that the frame will not be saved in layout-cache. Other than that it's hard to tell.

[Sweetsour]

Originally Posted by Lombra That's because once you start dragging it, it clears all points and positions it relative to the UIParent. (or maybe its own parent, not sure) Can you post some more code? Can't really tell what's going on from little bits of information here and there. I don't really understand what the exact issue is from the original post. I gather that there is some undesired positioning. Frames that have a name will have their position automatically saved in layout-cache. (a file in the WTF folder that saves frame positions and dimensions) These values then get loaded and applied at some point in the loading process. (probably after ADDON_LOADED, maybe before PLAYER_LOGIN) This may override or conflict with any anchor points you want to explicitly set yourself. Doing frame:SetDontSavePosition(true) ensures that the frame will not be saved in layout-cache. Other than that it's hard to tell.

I managed to do some reading before you posted this, so I now know a lot more about how frames behave when moving them. As a result, it turns out I left an important piece of information out that the objects I was moving were children of a frame that contains them all (in the circumstance where the user would want to move all the objects at once, instead of one at a time).

Thankfully, however, I found someone who ran into the same issue that I did and provided a great fix that seems to be working

Object:SetScript("OnMouseDown",function(self)
    local framePt,_,parentPt,x,y = self:GetPoint(1)
    self.framePt = framePt
    self.parentPt = parentPt
    self.frameX = x
    self.frameY = y
    self:StartMoving()
    -- once it has done so, we need the starting offset relative to UIParent
    -- so we can determine later what the relative movement was
    _,_,_,x,y = self:GetPoint(1)
    self.screenX = x
    self.screenY = y
end);
Object:SetScript("OnMouseUp",function(self)
    local framePt,_,parentPt,x,y = self:GetPoint(1)
    self:StopMovingOrSizing()
    -- once we have it, subtract the starting screen-offset to get the delta,
    -- and then add that to the starting frame-offset to get a new frame-offset
    x = (x - self.screenX) + self.frameX
    y = (y - self.screenY) + self.frameY
    self:ClearAllPoints()
    self:SetPoint(self.framePt, self:GetParent(), self.parentPt, x, y)
    -- and finally, clean up
    self.framePt = nil
    self.parentPt = nil
    self.frameX = nil
    self.frameY =nil
    self.screenX = nil
    self.screenY = nil
end);

Original thread that I found the solution: https://forums.wowace.com/showthread.php?t=15268

Thank you all for all of your assistance