Party frames in arena

Grimsin · 02-25-10, 12:30 PM

Is there an obvious reason why my party frames do not show up in arenas?

**Seerah** · 02-25-10, 01:22 PM

Do you have them set to hide when in raid?

Grimsin · 02-26-10, 09:50 AM

i have party frames set to hide in raid. Well actually... my code checks to see what the blizzard option is set to to decide that... but i always have mine checked to hide them in raid. When you are in the arena it thinks you are in a raid?

My party frames have some issues with hiding and showing properly all the time in general. like for some reason when you queue for wintersgrasp it does not hide the party frames like its supposed to. You have to /reload to get it to register but yet if you are in a party and the party leader shifts it to a raid it changes up just fine. I have PLAYER_ENTERING_WORLD set as one of the events to check against so i would think it would fire when entering wintersgrasp and fix the party frames. But it does not...

I had a problem with the party frames not showing up after being in a raid and everyone dropping from a dungeon. I think i fixed that although im sure if you were to drop raid while in combat it would fire taint since my fix was not secure code.

Also have a funny issue with the party leader icons, if you go to a random with a friend and you finish the random if you both stay partied and everyone else drops and you leave the dungeon it for some reason thinks you are both the party leader and the leader icon gets stuck. Only does this for party member 1. The other ones seem to function right when this same scenario is recreated.

IE having 3 friends... its only partyframe 1 that gets the leader icon stuck. partyframe 2's leader icon functions proper.

I would post my partyframes code but..... i wouldnt expect anyone to look through it its almost 12000 lines... - edit: i take that back its about 6000 lines and thats with most of the 2nd layout missing and no petframes for either layout....

Grimsin · 02-26-10, 09:55 AM

i weeded out the parts that deal with the hiding/showing

lua Code:

-----------------------------------------
---- hide party frames in raid Start ----
-----------------------------------------
 
local RaidPartyHandler = CreateFrame("Frame", "RaidPartyHandler", UIParent, "SecureHandlerStateTemplate");
SecureHandler_OnLoad(RaidPartyHandler);
GrimUI.RaidPartyHandler = RaidPartyHandler
 
GrimPartyMain = CreateFrame("Frame", nil, RaidPartyHandler);
GrimUI.GrimPartyMain = GrimPartyMain
 
 
RaidPartyHandler:SetFrameRef("GrimPartyMain", GrimPartyMain);
 
RaidPartyHandler:Execute([[
GrimPartyMain = self:GetFrameRef("GrimPartyMain");
]]);
 
RaidPartyHandler:Execute("raidhideparty = " .. tostring(GetCVar("hidePartyInRaid"))); -- hook to Blizzard option for party raid hide frames 
 
 
RaidPartyHandler:SetAttribute("_onstate-unitexists", [[
    if raidhideparty == 1 and newstate then
    GrimPartyMain:Hide()
    end
    if raidhideparty ~= 1 and newstate then
    GrimPartyMain:Show()
    end
]]);
 
RaidPartyHandler:SetAttribute("unit", "raid1");
RegisterUnitWatch(RaidPartyHandler, true);
 
 
 
RaidPartyHandler:SetAttribute("state-unitexists", UnitExists("raid1"));
 
-----------------------------------------
---- hide party frames in raid End   ----
-----------------------------------------
 
---------------------------------------
-- show them again when you leave it heh....
----------------------------------------------
local ReshowPartyFrames = CreateFrame("Frame", nil, UIParent)
ReshowPartyFrames:RegisterEvent("RAID_ROSTER_UPDATE")
ReshowPartyFrames:RegisterEvent("PLAYER_ENTERING_WORLD")
 
GrimUI.ReshowPartyFrames = ReshowPartyFrames
 
ReshowPartyFrames:SetScript("OnEvent", function(self)
    
    local StillInRaid = UnitExists("raid1")
    
    if event == "PLAYER_ENTERING_WORLD" and StillInRaid ~= 1 then
    GrimPartyMain:Show()
    end
    
    
    if StillInRaid ~= 1 then
    GrimPartyMain:Show()
    end
 
end)

Shadowed · 02-26-10, 03:46 PM

There's a simpler way of doing it. You don't need to muck around with the secure system as much: partyFrame is the secure header that shows the party frame.

lua Code:

local stateMonitor = CreateFrame("Frame", nil, nil, "SecureHandlerBaseTemplate")
        stateMonitor:SetFrameRef("partyHeader", partyFrame)
        stateMonitor:WrapScript(stateMonitor, "OnAttributeChanged", [[
            if( name ~= "state-raidmonitor" ) then return end
            
            if( self:GetAttribute("state-raidmonitor") == "raid" ) then
                self:GetFrameRef("partyHeader"):Hide()
            else
                self:GetFrameRef("partyHeader"):Show()
            end
        ]])
        RegisterStateDriver(stateMonitor, "raidmonitor", "[target=raid1, exists] raid; none")

That is a simplified version of what Shadowed Unit Frames does, https://gist.github.com/6323ba8bb2a9a4365413 is the full version which let's me do things like modify the stateMonitors attributes to decide whether or not I want the feature enabled.

You have to WrapScript before you call RegisterStateDriver, because as soon as you call RegisterStateDriver it's going to check the state and it'll switch to raid (or none) before your attribute event is setup.

Grimsin · 02-26-10, 05:15 PM

so wait what your saying is i can hook my party frames to partyFrame? and use that stateheader to control the party frames? and it will register the bliz option as well?

Shadowed · 02-26-10, 05:27 PM

lua Code:

-- Create our party frame header
local headerFrame = CreateFrame("Frame", "FooBarHeader", UIParent, "SecureGroupHeaderTemplate")
-- Create our state monitor
local stateMonitor = CreateFrame("Frame", nil, nil, "SecureHandlerBaseTemplate")
-- Set a frame ref so the state monitor can access the party frames
stateMonitor:SetFrameRef("partyHeader", partyFrame)
-- Wrap a bit of secure code around OnAttributeChanged so we can execute the code below while in combat, without causing errors
stateMonitor:WrapScript(stateMonitor, "OnAttributeChanged", [[
    -- If any other attributes fired this event, don't go any further, we don't care about them
    if( name ~= "state-raidmonitor" and name ~= "disable-hide" ) then return end
 
    -- If the player is in a raid and the auto hiding isn't disabled, hide the party frames
    if( self:GetAttribute("state-raidmonitor") == "raid" and not self:GetAttribute("disable-hide") ) then
        self:GetFrameRef("partyHeader"):Hide()
    -- If the player player is not in a raid, or party frames shouldn't be hidden while in a raid, show the party frames    
    else
        self:GetFrameRef("partyHeader"):Show()
    end]])
-- Setup a state driver that will set the "state-raidmonitor" attribute based on if we are in a raid (raid1 exists).
RegisterStateDriver(stateMonitor, "raidmonitor", "[target=raid1, exists] raid; none")

If you wanted to disable hiding the party frames in a raid, you would do stateMonitor:SetAttribute("disable-hide", true) this would also handle reshowing the party frames.

Dayve · 02-27-10, 04:48 AM

Originally Posted by Shadowed

There's a simpler way of doing it. You don't need to muck around with the secure system as much: partyFrame is the secure header that shows the party frame.

Both versions use secure code to respond to a state attribute change, but Grimsin's method (which is my old method that I told him about) uses UnitWatch to set the state while yours uses a state driver. What is simpler is this method which I started using recently:

lua Code:

RegisterStateDriver(partyFrame, "visibility", "[@raid1,exists]hide;show");

That will enable in-raid hiding on partyFrame, no other code required. And to disable it after having been enabled:

lua Code:

UnregisterStateDriver(partyFrame, "visibility");
partyFrame:Show();

Shadowed · 02-27-10, 05:27 AM

Mmm, I'd have to dig through comments. Pretty sure there was a reason why I used a unit watch over visibility thought. But that would also work.

Grimsin · 02-28-10, 02:42 PM

im confused...

So both of those methods should show/hide partyframes in raid according to the blizzard option selected? and of course reshow them after leaving a raid?

And would either and/or fix the fact partyframes do not show up in arenas?

Dayve · 02-28-10, 09:45 PM

The problem you had with the party frames not reshowing was due to a logic error:

lua Code:

RaidPartyHandler:SetAttribute("_onstate-unitexists", [[
    if raidhideparty == 1 and newstate then
    GrimPartyMain:Hide()
    end
    if raidhideparty ~= 1 and newstate then
    GrimPartyMain:Show()
    end
]]);

Should be:

lua Code:

RaidPartyHandler:SetAttribute("_onstate-unitexists", [[
    if raidhideparty == 1 and newstate then
        GrimPartyMain:Hide()
    else
        GrimPartyMain:Show()
    end
]]);

If you want to use the other method I posted just now, then you only need to create 'GrimPartyMain' and then use this to apply the user setting:

lua Code:

if GetCVarBool("hidePartyInRaid") then
    RegisterStateDriver(GrimPartyMain, "visibility", "[@raid1,exists]hide;show");
else
    UnregisterStateDriver(GrimPartyMain, "visibility");
    GrimPartyMain:Show();
end

As for the arena problem, the reason the party frames are hiding is because when you are in an arena you really are in a raid, so there's really no bug occurring there. If you wish the party frames to remain shown you need to force the hiding behavior off when entering an arena instance and reapply the user setting when leaving; try watching for PLAYER_ENTERING_WORLD and grab instance type with IsInInstance().

Grimsin · 03-01-10, 09:48 AM

well im sure im going to try the other method you posted since what i had at first even with the change you just posted has issues. like if i change the logic, which btw the logic change you posted now is how i had it at first, then it does not show back up when leaving a raid. Also the way i did it had other problems like the one when queuing for winters grasp when it loaded you to WG and formed the raid the party frames got stuck no mater what. When dropping from a raid the party frames would not show back up either. Not with out that unsecure code i added which is a problem in itself. OOH and almost forgot to mention... my method requires a reload once you get into the raid sometimes....for some reason....

Grimsin · 03-01-10, 10:28 AM

oh another issue i forgot about... if you select the show/hide party frames in raid option in the bliz options it requires a reload to register it with my code...

Grimsin · 03-01-10, 10:36 AM

Okay trying your method just noticed an issue, the get cvar that has to have something to say is = to or not = to on it since doing the getcvar on that will return a number? i think im still confused to, so your saying i only need to do the createframe for "GrimPartyMain" and i can ditch the rest of the code? i still need a setattrib on something with something for it to run the if statement from right? some sort of event?

Dayve · 03-01-10, 11:47 AM

Originally Posted by Grimsin

Okay trying your method just noticed an issue, the get cvar that has to have something to say is = to or not = to on it since doing the getcvar on that will return a number?

GetCVarBool() returns either 1 or nil which evaluate to true and false respectively, so it can be used directly in an 'if' statement.

Originally Posted by Grimsin

i think im still confused to, so your saying i only need to do the createframe for "GrimPartyMain" and i can ditch the rest of the code?

Yes.

Originally Posted by Grimsin

i still need a setattrib on something with something for it to run the if statement from right? some sort of event?

No. The state driver code will automatically show/hide 'GrimPartyMain'.

The requirement for a UI reload comes about because you are only checking the CVar value while the addon is loading; to reflect the user option in real time you need to watch for CVar changes and reapply the setting when "hidePartyInRaid" changes.

Grimsin · 03-01-10, 11:59 AM

The response to cvar changes would then also need to be in secure code correct? in case someone does it in combat....

hmm or are the bliz options locked down in combat?

Grimsin · 03-01-10, 12:31 PM

Well assuming the cvars lock down in combat and assuming you cant go into an arena while in combat... this all appears to be working so far.

lua Code:

GrimPartyMain = CreateFrame("Frame", "GrimPartyMain", UIParent, "SecureHandlerStateTemplate");
GrimUI.GrimPartyMain = GrimPartyMain
 
 
if GetCVarBool("hidePartyInRaid") then
 
RegisterStateDriver(GrimPartyMain, "visibility", "[@raid1,exists]hide;show");
 
else
 
UnregisterStateDriver(GrimPartyMain, "visibility");
GrimPartyMain:Show();
end
 
ShowArenaParty = CreateFrame("Frame", "ShowArenaParty", UIParent, "SecureHandlerStateTemplate");
GrimUI.ShowArenaParty = ShowArenaParty
ShowArenaParty:RegisterEvent("PLAYER_ENTERING_WORLD")
ShowArenaParty:SetScript("OnEvent", function(self)
    local inInstance, instanceType = IsInInstance()
    if inInstance == 1 and instanceType == "arena" then
    GrimPartyMain:Show();
    end
end)
 
UpdatePartyCVar = CreateFrame("Frame", "UpdatePartyCVar", UIParent, "SecureHandlerStateTemplate");
UpdatePartyCVar:RegisterEvent("CVAR_UPDATE")
UpdatePartyCVar:SetScript("OnEvent", function(self)
 
    if GetCVarBool("hidePartyInRaid") then
 
    RegisterStateDriver(GrimPartyMain, "visibility", "[@raid1,exists]hide;show");
 
    else
 
    UnregisterStateDriver(GrimPartyMain, "visibility");
    GrimPartyMain:Show();
    end
end)

Dayve · 03-02-10, 12:56 AM

CVars are not secure in any way; consequently they can change in combat and there is no way for you to write secure code to respond to it. Check InCombatLockdown() when you get CVAR_UPDATE; if in combat then delay response until combat ends.

Grimsin · 03-02-10, 06:14 AM

hmm how would you delay until combat ends though? use the Regen enabled event?

Dayve · 03-02-10, 06:44 AM

Yes, that should work.