How to handle multiple tooltip

[fatrog]

Hello,

I have a problem with my tiny addon I made. I get error while its event get triggered by multiple tooltip at once.
eg. when you put your mouse on inventory items while switch it and it show other options

This is my event handler so far:

TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Item, GetItemGCDInfos)

The error is:

attempt to call method 'GetItem' (a nil value)

it is refering at the function I use to get spell gcd from items. It works for the "main" tooltip, but throw the error for the other ones



And this is my whole code for the sake of this post:

local gcdMS, gcdMSControl, cooldownMS, displayedName, spellID, ItemName, ItemLink, gcdText
 
local function MSround(num, numDecimalPlaces)
  local mult = 10^(numDecimalPlaces or 0)
  return math.floor(num * mult + 0.5) / mult
end
 
local function SetNewLineWithGCD(tt,gcdMS)
        gcdMS = MSround(gcdMS / 1000,2)
        gcdText = ""
        gcdText = "GCD "..gcdMS.."sec"
        tt:AddLine(" ",1,1,1)
        tt:AddLine(gcdText,0,1,0)
end
 
local function GetSpellGCDInfos(tt)
    gcdMS, cooldownMS, spellID = nil
    
    _, spellID = tt:GetSpell()
    if spellID ~= nil then
        cooldownMS, gcdMS = GetSpellBaseCooldown(spellID)
    end
 
    if gcdMS ~= nil then
        SetNewLineWithGCD(tt,gcdMS)
    end
end
 
local function GetItemGCDInfos(tt)
    gcdMS, cooldownMS, spellID, ItemLink = nil
    
    _, ItemLink = tt:GetItem()
    _, spellID = GetItemSpell(ItemLink)
    
    if spellID ~= nil then
        cooldownMS, gcdMS = GetSpellBaseCooldown(spellID)
    end
    
    if gcdMS ~= nil then
        SetNewLineWithGCD(tt,gcdMS)
    end
end
 
local function GetMacroGCDInfos(tt)
    gcdMS, cooldownMS, displayedName, spellID, itemName, ItemLink = nil
    
    displayedName = _G[tt:GetName().."TextLeft"..1]:GetText()
    _,_,_,_,_,_,spellID = GetSpellInfo(displayedName)
    
    if spellID ~= nil then
        cooldownMS, gcdMS = GetSpellBaseCooldown(spellID)
    else
        _,ItemLink = GetItemInfo(displayedName)
        _, spellID = GetItemSpell(ItemLink)
        if spellID ~= nil then
            cooldownMS, gcdMS = GetSpellBaseCooldown(spellID)
        end
    end
    
    if gcdMS ~= nil then
        SetNewLineWithGCD(tt,gcdMS)
    end
end
 
TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Spell, GetSpellGCDInfos)
TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Item, GetItemGCDInfos)
TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Macro, GetMacroGCDInfos)

[fatrog]

noone knows?

I wanted to add that it also appens (obviously) on comparison tooltip (shift key)

Edit:
Ultimately, is there a way to make errors die silently in lua?

[Xrystal]

It looks like it is referring to the line

_, ItemLink = tt:GetItem()

Which is in the function mentioned by the line you first posted.

It looks like this is one of the functions removed, or being removed based on the dev comments in GameTooltip.lua.

-- Temp replacements for GetX API that's been removed
-- TODO: Evaluate for removal
function GameTooltipDataMixin:GetItem()
    return TooltipUtil.GetDisplayedItem(self);
end

https://www.townlong-yak.com/framexm...ooltip.lua#983

Try using the TooltipUtil route and using your tooltip frame instead of self.

[fatrog]

Thank you for your help

Ok, by using tooltip frame you mean 'GameTooltip' object? It confuses me

[Kanegasi]

Within your code at that GetItem spot, tt is a tooltip frame. When you register GetItemGCDInfos at the bottom, the UI is feeding your function the current tooltip frame being rendered, which is usually GameTooltip.

Replace

tt:GetItem()

with

TooltipUtil.GetDisplayedItem(tt)

[fatrog]

Hello,

Thank you so much for explainations. And sorry for very late answer.

So, as you suggested, I have made it like this:

local function GetItemGCDInfos(tt)
    ctt = TooltipUtil.GetDisplayedItem(tt)
    gcdMS, cooldownMS, spellID, ItemLink = nil
    
    if ctt ~= nil then
        _, ItemLink = ctt:GetItem()
        _, spellID = GetItemSpell(ItemLink)
    end
    
    if spellID ~= nil then
        cooldownMS, gcdMS = GetSpellBaseCooldown(spellID)
    end
    
    if gcdMS ~= nil then
        SetNewLineWithGCD(ctt,gcdMS)
    end
end

Unfortunatly, I still got the same error (eg. when I get multiple tooltip like when I put my cursor over the suggested items in the "edit stuff" menu)

[fatrog]

Ok, i'm stupid. I kept the getItem() method call..

Thanks for help, all good now