Quantcast L["...."] addings in Files - WoWInterface
Thread Tools Display Modes
12-31-14, 04:24 AM   #1
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
L["...."] addings in Files

I'm a bit Angry. When you add NEW L["..."] PLEASE add it also to the Lang files. I work atm at NxWeekly.lua and the enUS differs a lot from the others.

So Please;

1. Add new L["..."] to ALL other language Files (enUS, itIT, etc ......)
2. Add NEW L["..."] AT THE END OF THE TRANSLATIONFILE !!!!!!!! So it's esier to take a look, what missing


With my next Commit:

If you want to Translate a Boss of WoW use

B["BOSS"]

Last edited by gOOvER : 12-31-14 at 09:41 AM.
  Reply With Quote
12-31-14, 04:33 AM   #2
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
See
https://github.com/Rythal/Carbonite/pull/202
  Reply With Quote
12-31-14, 05:41 AM   #3
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Originally Posted by gOOvER View Post
I'm a bit Angry. When you add NEW L["..."] PLEASE add it also to the Lang files. I work atm at NxWeekly.lua and the enUS differs a lot from the others.

So Please;

1. Add new L["..."] to ALL other language Files
2. Add NEW L["..."] AT THE END OF THE TRANSLATIONFILE !!!!!!!! So it's esier to take a look, what missing


With my next Commit:

If you want to Translate a Boss of WoW use

B["BOSS"]
Take a look at http://www.wowinterface.com/forums/s...ad.php?t=51261
ATM I don't have access to github so I can't make a pull for it.
  Reply With Quote
12-31-14, 09:46 AM   #4
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
@atl77: Please take a look into existing PR's before you breaking the Languages. Because you are only adding L[...] to deDE.lua and not to others.
  Reply With Quote
12-31-14, 10:39 AM   #5
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
Sorry had to do some things. I think atl77 hasn't pulled your Request out of same Idea I don't pull it for the moment I Know the Github Version is thrwoing Errors at the Moment, but your change with lib should be decided by Rythal and thats why I don't pull nelegalnos pull for the Moment wants to wait until rythal decides if we pull gOOvERs request first than I will manually merge nelegalnos pull and go further with my Ideas for bindings

Greetings Samyonair
  Reply With Quote
12-31-14, 10:47 AM   #6
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,456
I am the main culprit in not adding them to every language besides enUS, and that's because the people working on translating have not needed them moved. When I do the push, someone is right there to duplicate the new strings across to the rest of the language files and i've gotten use to that.

When i'm working, localization is the last thing on my mind, and usually the last thing I do. I ignore the errors that it's not in the locale files, then I add them all to enUS and push it then move onto the next bug.
  Reply With Quote
12-31-14, 10:49 AM   #7
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,456
and what error is the github throwing? the only one I knew of was the Seals and I fixed that 5 minutes after it was reported.
  Reply With Quote
12-31-14, 10:52 AM   #8
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
Because you have done your merge without translated Lterms all languages apart from enUS, and German (because of atl77) are throwing arrors because of missing L terms

Greetings Samyonair
  Reply With Quote
12-31-14, 10:55 AM   #9
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,456
I must completely misunderstand how the acelocale works, it was my understanding if it's declared in enUS it uses that as the default, if your using another locale language and it wasn't replaced, then go back to the default one and use that, which was why enUS was declared the default language during table initializations.
  Reply With Quote
12-31-14, 11:02 AM   #10
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,456
I thought so... reading the page again on acelocale, and it is suppose to work the way I thought it was with enUS declared the default.
  Reply With Quote
12-31-14, 11:18 AM   #11
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,456
Silent flag was just added, acelocale should never again return an error.
  Reply With Quote
12-31-14, 11:41 AM   #12
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
I think then it is a good Idea if the Translators put their changes byself by compaering locales files with enUS because this removes many merge conflicts

greatings Samyonair
  Reply With Quote
12-31-14, 11:42 AM   #13
DeaTHCorEKiD
A Deviate Faerie Dragon
Join Date: Apr 2010
Posts: 14
i think silent flag in dev version are counterproductive, this helps not to find errors or missing translations.
  Reply With Quote
12-31-14, 11:57 AM   #14
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
the silent flag is only for locales files, our Problem is we have Translators for almost all supported Languages and they transmit their files, and a change in time between working on translations and a codechange leaves more problems then a missing term,

greetings Samyonair
  Reply With Quote
12-31-14, 11:58 AM   #15
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,456
Originally Posted by DeaTHCorEKiD View Post
i think silent flag in dev version are counterproductive, this helps not to find errors or missing translations.
Not if I start making sure all new translations are always at the bottom. Just as my version of carbonite has debug settings enabled so I see stuff no one else does, I'll have my locales non-silenced to make sure they are added to enUS.

I really don't understand what changed, as besides the initial push I never updated the other languages besides enUS, and this is the first i've heard of errors coming from it, warnings yes but not errors.
  Reply With Quote
12-31-14, 12:02 PM   #16
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,456
Wait... maybe I'm getting cross-confused, when you said errors I thought you meant ingame LUA errors and that's what I was trying to fix up, are you meaning the github is throwing errors because it can't merge.
  Reply With Quote
12-31-14, 12:09 PM   #17
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
No I thought on lua errors I mixed it sorry

for declaretion

Lua errors missing L Terms

and merge conflicts by changeing translation files by

1. Translator works on translations

2. fix / enhancement : pushed to all languagefiles

3. Translator pulls his Version from 1

merge confict because files defer

greetings Samyonair

easy way for development

Guide for Translators Howto remove silent flag to develop

My thought was you do only enUS to don't create merge conflicts

Last edited by samyonair : 12-31-14 at 12:12 PM.
  Reply With Quote
12-31-14, 12:56 PM   #18
atl77
A Chromatic Dragonspawn
Join Date: Oct 2014
Posts: 179
Proposal: silent for release only

Even though I believe the translator will spot missing translations sooner or later, I also think the silent option should only be set for releases. How about setting a flag to tell if a version is a release version and putting that into the locale definition instead of "true"?
  Reply With Quote
12-31-14, 01:09 PM   #19
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Originally Posted by samyonair View Post
Sorry had to do some things. I think atl77 hasn't pulled your Request out of same Idea I don't pull it for the moment I Know the Github Version is thrwoing Errors at the Moment, but your change with lib should be decided by Rythal and thats why I don't pull nelegalnos pull for the Moment wants to wait until rythal decides if we pull gOOvERs request first than I will manually merge nelegalnos pull and go further with my Ideas for bindings

Greetings Samyonair
I'm updating the file to the current version. And I don't mind updating the locale files when i have the time.
  Reply With Quote

WoWInterface » Featured Projects » Carbonite » Carbonite: Dev Talk » L["...."] addings in Files

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off