Removing shield from the protected casts.

[Deadlyz]

Hello!

I'd like to disable the shield texture for protected casts.

The old classic texture looks terrible with the new UI and Blizzard didn't even bother to position it properly.

Looking for a bored Addon Author to help me!

Thanks in advance!

[L3n1n]

Didn't test but it should work.

TargetFrameSpellBar:HookScript("OnShow", function(self)
    if self.BorderShield:IsShown() then
        self.BorderShield:Hide()
    end
end)

[Deadlyz]

Originally Posted by L3n1n Didn't test but it should work. TargetFrameSpellBar:HookScript("OnShow", function(self)     if self.BorderShield:IsShown() then         self.BorderShield:Hide()     else end)

Thanks! I'm getting an error though

3x FrameXML\Bindings.xml:1 Interface/AddOns/NoShield/NoShield.lua:1 Interface/AddOns/NoShield/NoShield.lua:5: unexpected symbol near ')'

[L3n1n]

I did mistake, replace "else" to "end".

[Deadlyz]

Originally Posted by L3n1n I did mistake, replace "else" to "end".

Thanks! It works now, but somehow only hides shields randomly.

[Xrystal]

You could try IsVisible() in addition to IsShown()
https://wowpedia.fandom.com/wiki/API...Region_IsShown


You could try just having the Hide() line. Seeing as the function is to show the frame, rather than check if it is shown first just tell it to hide it regardless as your code runs after their code. The test on whether it is Shown or not may be returning false for some reason. But the above may rectify this scenario.

[Deadlyz]

Originally Posted by Xrystal You could try IsVisible() in addition to IsShown() https://wowpedia.fandom.com/wiki/API...Region_IsShown You could try just having the Hide() line. Seeing as the function is to show the frame, rather than check if it is shown first just tell it to hide it regardless as your code runs after their code. The test on whether it is Shown or not may be returning false for some reason. But the above may rectify this scenario.

Thanks!

The final version of the code for anyone interested

TargetFrameSpellBar.BorderShield:SetTexture(0)
FocusFrameSpellBar.BorderShield:SetTexture(0)

[SDPhantom]

Originally Posted by Deadlyz Thanks! It works now, but somehow only hides shields randomly.

The problem is, when a cast stops, the frame is still "Shown" for the duration it's fading. When another spell is cast, OnShow doesn't fire because it never was hidden in the first place.

Originally Posted by Xrystal You could try IsVisible() in addition to IsShown() https://wowpedia.fandom.com/wiki/API...Region_IsShown

:IsVisible() implies :IsShown(). The difference is :IsVisible() checks inherited visibility from the parent where :IsShown() only checks the object's shown state.

[Deadlyz]

Originally Posted by SDPhantom The problem is, when a cast stops, the frame is still "Shown" for the duration it's fading. When another spell is cast, OnShow doesn't fire because it never was hidden in the first place. :IsVisible() implies :IsShown(). The difference is :IsVisible() checks inherited visibility from the parent where :IsShown() only checks the object's shown state.

Thanks for the explanation