oUF - Layout discussion

[Caellian]

Originally Posted by haste Also, your wall of text doesn't answer my question . I wanted to know where it's called, not how it looks .

I'm not sure what you mean with "where it's called
this ? as for where, it's below health and power settings.

	self.Name = SetFontString(self.Health, font,(unit == 'player' or unit == 'target') and 11 or 9)
	if(self:GetParent():GetName():match'oUF_Raid') then
		self.Name:SetPoint('TOP')
	else
		self.Name:SetPoint('LEFT', 1, 1)
	end

Originally Posted by haste 1: Lua 5.1.3 Copyright (C) 1994-2008 Lua.org, PUC-Rio > r, g, b = 1, .5, .75 > return string.format('|cff%02x%02x%02x', r*255, g*255, b*255) |cffff7fbf

What exactly did you mean with this ?

Other than that, everything's fine now

[haste]

1: That's where it is created . oUF doesn't have any ":OverrideNameUpdate()", so I don't know how it ends up executing (ie. calling) your function. All I know is that it most likely happens at a point it shouldn't be doing it.

2: Just replace your returns with that, or the static strings for the color. The latter would be the best solution tho'.

codepad is a nice page if you don't have a Lua interpreter on your computer.

[Caellian]

Originally Posted by haste 1 - Frames anchored to the UIParent directly (ie. player, target, focus, etc - anything spawned as a single unit). 2 - Frames anchored to a header frame (ie. raid, party). 3 - Frames anchored to a frame on a header frame (ie. partypet/target).

Might sound like a noob question (or actually it is)
How exactly do you write this self.Health:SetFrameLevel(unit and 1 or 3) then ?

Originally Posted by haste 2: Just replace your returns with that, or the static strings for the color. The latter would be the best solution tho'.

I've updated my GetDifficultyColor function in the layout but how do i have to change the following so it uses it instead on the default [difficulty]

self:Tag(self.Info, '[shortlarge] [difficulty][smartlevel] [rare]')

And, that's it i guess

[haste]

1: This is probably the easiest way to do it:

if(unit) then
     :SetFrameLevel(1)
elseif(self:GetAttribute'unitsuffix') then
     :SetFrameLevel(3)
elseif(not unit) then
     :SetFrameLevel(2)
end

2: http://ixo.no/git/oUF_Classic.git/tree/classic.lua#n29.

[Caellian]

Originally Posted by haste Just replace your returns with that, or the static strings for the color. The latter would be the best solution tho'.

Aight, thanks a lot haste, btw here's how the tag looks

oUF.Tags['[leveldiff]']  = function(u) local leveldiff = UnitLevel('unit')
	if level == '??' then
		r, g, b = .69,.31,.31
		return string.format('|cff%02x%02x%02x', r*255, g*255, b*255)
	else
	local levelDiff = UnitLevel('target') - UnitLevel('player')
		if levelDiff >= 5 then
			r, g, b = .69,.31,.31
			return string.format('|cff%02x%02x%02x', r*255, g*255, b*255)
		elseif levelDiff >= 3 then
			r, g, b = .71,.43,.27
			return string.format('|cff%02x%02x%02x', r*255, g*255, b*255)
		elseif levelDiff >= -2 then
			r, g, b = .84,.75,.65
			return string.format('|cff%02x%02x%02x', r*255, g*255, b*255)
		elseif -levelDiff <= GetQuestGreenRange() then
			r, g, b = .33,.59,.33
			return string.format('|cff%02x%02x%02x', r*255, g*255, b*255)
		else
			r, g, b = .55,.57,.61
			return string.format('|cff%02x%02x%02x', r*255, g*255, b*255)
		end
	end
	oUF.TagEvents['[leveldiff]'] = 'UNIT_LEVEL'
end

But you said it would be better if i used the static string for the color, do you mean the html color code like this '|cffD7BEA5|r' ?

[haste]

Without the |r part. You also have r, g and b as globals in your tag .

You also do: local leveldiff = UnitLevel('unit') instead of UnitLevel(unit), another thing is that it is hardcoded to player only.

[Caellian]

Nevermind, thanks and fixed

While you're around, maybe you can answer to this aswell. (note to self: do not abuse of haste)

It's been forever now since i had to use the UTF8 lib to fix an issue.

when i'm in a party/raid where there's a player with any special character in his name, it's replaced with a ?

Why, fixable ? (without the use of that HUGE lib)

[haste]

It's fixable, in exactly the same way as the utf-8 lib handles :sub(). The reason the library is "HUGE" is because it has the tables for converting utf-8 characters between upper- and lowercase.

The reason that your seeing a ? is simple however. All the string functions are byte based. This means that multi-byte characters such as 東京 are seen by Lua as more than two characters:

('東京'):len() -- returns: 6, instead of 2

If we look under the hood, the string consists of:

('東京'):byte(1, 6) -- returns: 230,     157,     177,     228,     186,     172

Now, when you run :sub() on a multi-byte string - you end up with chopping off some valuable information:

> return ('東京'):sub(1, 5)
東�
> return ('東京'):sub(1, 4)
東�
> return ('東京'):sub(1, 3)
東

In the two first subs we end up with invalid characters, and WoWs default behavior is to display these as a ?, unless the font actually can render them that is.

This is valid for all characters outside the ASCII scope.

You have a couple solution to solve this ofc:
a) use the utf-8 lib.
b) strip out the sub function from the utf-8 lib and use only that.
c) set a width on the strings and let the internal font string code handle it.
d) ignore the issue.

[Caellian]

I'll take either c or d, most likely c then, thanks a lot, again !

[Caellian]

Hmm i can't figure out why the world bosses like Thrall '??' level appear in gray instead of red even though ?? is set to red.

[haste]

Some code would probably be useful :).

[p3lim]

Originally Posted by haste Some code would probably be useful .

He posted it a bit earlier

Originally Posted by Caellian Aight, thanks a lot haste, btw here's how the tag looks oUF.Tags['[leveldiff]'] = function(u) local leveldiff = UnitLevel('unit') if level == '??' then r, g, b = .69,.31,.31 return string.format('|cff%02x%02x%02x', r*255, g*255, b*255) else local levelDiff = UnitLevel('target') - UnitLevel('player') if levelDiff >= 5 then r, g, b = .69,.31,.31 return string.format('|cff%02x%02x%02x', r*255, g*255, b*255) elseif levelDiff >= 3 then r, g, b = .71,.43,.27 return string.format('|cff%02x%02x%02x', r*255, g*255, b*255) elseif levelDiff >= -2 then r, g, b = .84,.75,.65 return string.format('|cff%02x%02x%02x', r*255, g*255, b*255) elseif -levelDiff <= GetQuestGreenRange() then r, g, b = .33,.59,.33 return string.format('|cff%02x%02x%02x', r*255, g*255, b*255) else r, g, b = .55,.57,.61 return string.format('|cff%02x%02x%02x', r*255, g*255, b*255) end end oUF.TagEvents['[leveldiff]'] = 'UNIT_LEVEL' end But you said it would be better if i used the static string for the color, do you mean the html color code like this '|cffD7BEA5|r' ?

[Caellian]

Same as above, didn't want to repost the same, i've tried different ways, all leads to the same result, ?? is grey (.55, .57, .61)

I was trying to fix this before replacing with the html codes.

[haste]

well, level isn't the same variable as leveldiff.

[Caellian]

Originally Posted by haste well, level isn't the same variable as leveldiff.

I know, replacing it with leveldiff was one of the thing i've tried, still grey.

[haste]

Pastey your code, or anything.

[Caellian]

Originally Posted by haste Pastey your code, or anything.

http://www.pastey.net/107923

[p3lim]

Originally Posted by Caellian http://www.pastey.net/107923

UnitLevel never returns a string, only numbers.
For a unit that the level is unknown UnitLevel returns -1

oUF's tags does handle this and returns the ?? instead of -1 value.

Here is a diff file:
http://www.pastey.net/107929-4ak8:107923-32wz

[Toran]

Originally Posted by Caellian @Rostok I can missunderstand but my guess would be that you have to place it elsewhere than below a if(unit == 'player')

Thank you Caellian, for the push in the right direction. I lifted the code out of the (unit == 'player') section and it applies to all now.

I am modifying oUF_Lyn and am surprised to see other icons in that same section including resting icon, leader icon, and raid target icons. Does that mean I need to pull all of them out of that section also? Odd that Lyn would have put these icons in the (unit == 'player') section if that makes them only show in the player frame.

[Caellian]

Originally Posted by p3lim UnitLevel never returns a string, only numbers. For a unit that the level is unknown UnitLevel returns -1 oUF's tags does handle this and returns the ?? instead of -1 value. Here is a diff file: http://www.pastey.net/107929-4ak8:107923-32wz

how can i not think about that, scratching my head for hours, thanks a lot p3lim

Originally Posted by Toran Thank you Caellian, for the push in the right direction. I lifted the code out of the (unit == 'player') section and it applies to all now. I am modifying oUF_Lyn and am surprised to see other icons in that same section including resting icon, leader icon, and raid target icons. Does that mean I need to pull all of them out of that section also? Odd that Lyn would have put these icons in the (unit == 'player') section if that makes them only show in the player frame.

Well, resting icon will only apply to the player anyway.
Leader and raid target it's a matter of 'taste' i guess, i myself don't display the raidleader/masterlooter on smaller frames like focus and target for example, i only show them on myself, party and raid.
I can be mistaken but i think there are even some icons that have their own unit restriction build in oUF itself.