Buff Addon - Who cast this on me?

[keLston]

Is there a buff addon that provides this sort of information?

Occasionally in the combat log, you can tell with beneficial buffs especially when they wear off who casted a buff on you.

But there are certain buffs, especially with LFR trolls, that there seems to be no way to discern who casted something on you (like Heroism/Bloodlust).

The closest thing I know to this is DBM's spelltracker module but it goes by being in the raid and providing cooldown information and tells you when someone's Heroism ends up on cooldown.

I'd like to be able to tell if someone drive by buffs me or gives me one of the cosmetic item buffs so I can return the favor. There doesn't seem to be an addon that does this so i'm not sure if it's possible? I seem to remember it being a thing once, maybe I remember poorly.

[Phanx]

Caster info for buffs is available from the UnitAura API. My addon PhanxBuffs adds this info to its own tooltips; here is a completely drycoded standalone addon that should add caster names to buff and debuff tooltips for the default UI and any addon that uses the standard GameTooltip:

hooksecurefunc(GameTooltip, "SetUnitAura", function(self, unit, index, filter)
	local _, _, _, _, _, _, _, caster = UnitAura(unit, index, filter)
	local name = caster and UnitName(caster)
	if name then
		self:AddDoubleLine("Cast by:", name, nil, nil, nil, 1, 1, 1)
		self:Show()
	end
end)

If you need help turning the above code into an addon, copy and paste it into this page:
http://addon.bool.no/

[Tonyleila]

Raven can show this in the tooltip.

[Clamsoda]

Fixed Phanx's code. The first argument of a hooksecurefunc function is itself, and there was a missing comma between GameTooltip and "SetUnitAura". Fixed, and working great.

hooksecurefunc(GameTooltip, "SetUnitAura", function(self, unit, index, filter)
	local _, _, _, _, _, _, _, caster = UnitAura(unit, index, filter)
	local name = caster and UnitName(caster)
	if name then
		GameTooltip:AddDoubleLine("Cast by:", name, nil, nil, nil, 1, 1, 1)
		GameTooltip:Show()
	end
end)

[keLston]

Awesome. Thanks so much!

[Phanx]

Originally Posted by Clamsoda The first argument of a hooksecurefunc function is itself, ...

In this case, yes, but as a general rule, no -- hooksecurefunc doesn't have a "self", as it's a function, not an object. There only needs to be a self parameter in this case because the specific function being hooked receives one. I copied and pasted from code that was using method (colon) notation -- eg. frame:Method(x) which is syntatic sugar for frame.Method(self, x) -- and forgot to add the explicitly named parameter to work with function (dot) notation, but don't take that to mean that all functions passed to hooksecurefunc magically get a "self" prepended to their arguments.

[Clamsoda]

The anonymous function inside of any hooksecurefunc function WILL have the object as the first argument, no?

[semlar]

In this case, self is a reference to GameTooltip because the function being hooked is a method in a table (GameTooltip.SetUnitAura).

If you were to hook a function directly, "print" for example, self would not be passed as an argument.

[RLD]

just found this....

good snippet of code and variation disussion.

played with this a little bit

print(name) will print locally to see if 'name' would get passed. (this happens on mouse over). would rather have it with OnClick().

then tried to do a CastSpellByName("Mark of the Wild",name) to see if I could buff 'name'

but no matter what my very limited knowledge seems to try I get a taint and error.

any help would be appreciated.

[Phanx]

Originally Posted by RLD then tried to do a CastSpellByName("Mark of the Wild",name) to see if I could buff 'name'

CastSpellByName has not been available to addons since before the Burning Crusade, almost 7 years ago. You should probably read:

(1) The list of things addons can't do. It's a sticky thread in this very forum.

(2) The WoW API documentation on Wowpedia or WoW Programming. Both will tell you whether it's even possible for you to use the function, and if so, how you should use it.

If you want any more specific help, you're going to have to be a lot more specific about what you want to do (big picture wise, eg. "I want to keep my raid buffed"). You're talking about names and OnClick scripts in your post, but I have no idea what you're actually talking about. Finally, if you want help with code, you need to show the code.

[ravagernl]

Originally Posted by RLD print(name) will print locally to see if 'name' would get passed. (this happens on mouse over). would rather have it with OnClick(). then tried to do a CastSpellByName("Mark of the Wild",name)

Are you trying to target the person/mob who gave you that buff by left-clicking on the actual buff or something? If so, I believe that can't be done.

[Nimhfree]

If you have a custom button that handles your buffs, I bet you can set a macro on it to target the person that cast the spell on you. Then you can specially click that buff button to invoke the macro. I do not think this would work in combat, so raid buffs may not be usable a lot, but it could work out of combat. Once you target the caster of the original buff you can do as you will.

Edit:
In fact, I imagine you might be able to monitor when you get a buff cast on you, and instead of having the actual buff need to be specially clicked, you would have a different button that you could set the macrotext on to target the caster of the buff. Then you click that button to target the benefactor so you can cast MotW on them.

Edit 2:
Something like this should work. It is a bit rough, but you get the idea:

local previousBuffs = {} local targetButton = CreateFrame("Button", nil, WorldFrame, "SecureActionButtonTemplate,UIPanelButtonTemplate") targetButton:SetWidth(16) targetButton:SetHeight(16) targetButton:SetPoint("LEFT",WorldFrame,"BOTTOMLEFT",50,320) targetButton:SetAttribute("type1", "macro") targetButton:SetScript("OnEvent", function(ignored, event, arg1) if arg1 == "player" then local i = 1 local currentBuffs = {} local chosenCaster = nil while (true) do local name,_,_,_,_,_,_,caster,_,_,spellId = UnitAura(arg1, i) if name then spellId = tonumber(spellId) if nil ~= spellId then currentBuffs[spellId] = caster if nil == previousBuffs[spellId] then chosenCaster = caster end end i = i + 1 else break end end local benefactorName = chosenCaster and UnitName(chosenCaster) if benefactorName and not InCombatLockdown() then targetButton:SetAttribute("macrotext", SLASH_TARGET1 .. ' ' .. benefactorName) end previousBuffs = currentBuffs end end) targetButton:RegisterUnitEvent("UNIT_AURA", "player")

[Petrah]

I've been using this one for almost 4 years. It just tells you in the buff tooltip the name of the person who cast the buff on you. Especially useful if you're leading raids.


http://www.wowinterface.com/download...urce.html#info

[Phanx]

I like how you guys are all throwing out random suggestions for this guy whose post didn't even make any sense, and who will probably never come back and check for replies.