Unequip all items

[Walkerbo]

Hi all

I am trying to unequip all items into any empty bag slot.

The problem is that I can unequip all items into my bags or into my backpack but not all into any empty slot in both.

This is the code I am trying to run;

for k, v in pairs(EquipmentSlots) do
   PickupInventoryItem(v)
   for bag = 0, 4 do
      for slot = 0, GetContainerNumSlots(bag) do
         local itemID = GetContainerItemID(bag, slot)
         if not itemID then
            PutItemInBag(slot)
         end
      end
   end
   if CursorHasItem() then
    PutItemInBackpack()
   end
end

If I have enough bagspace the items move into the bags, but if I do not have enough space the leftover items do not drop into the backpack.

I have tried splitting it into 2 separate chunks runnig one after the other with the same results.

It is the backpack one that seems to break it, it will fill the backpack then say "not enough space" and then stop altogether.

Does anyone have any advice/help for me?

Cheers

[Kanegasi]

PutItemInBag wants an InventorySlotId, not a slot in a bag. 20, 21, 22, and 23 are the bag slots. You should also break out of the inner loops once you put the item in a bag.

local ignore,foundspot={[0]={},[1]={},[2]={},[3]={},[4]={},}
for k, v in pairs(EquipmentSlots) do
   PickupInventoryItem(v)
   foundspot = false
   if CursorHasItem() then
      for bag = 4, 0, -1 do
         for slot = 1, GetContainerNumSlots(bag) do
            if not ignore[bag][slot] and not GetContainerItemID(bag, slot) then
               if bag == 0 then
                  PutItemInBackpack()
               else
                  PutItemInBag(bag+19)
               end
               ignore[bag][slot] = true
               foundspot = true
               break
            end
         end
         if foundspot then
            break
         end
      end
   end
end

Edit: Fizzlemizz makes a good point. Based on your wording, it does look like you would rather fill other bags with the unequipped gear before your backpack. I reversed the bag loop so your backpack is searched last.

Edit2: Added CursorHasItem and an ignore table to keep track of spots filled by the code.

[Fizzlemizz]

Bag 0 is the backpack so checking there first for empty slots is probably not what you're looking for.

for bag = 1, 4 do

Edit:
In a tight loop, the bag inventory doesn't update in time so you the get the "That bag is full" notification which can cause the process to break. Best to wait for the bag update event before processing the next item:

local LastBag, LastSlot, Remove
local function SaveToBags()
    while Remove do
        PickupInventoryItem(Remove)
        Remove = Remove+1
        if Remove > INVSLOT_LAST_EQUIPPED then
            Remove = nil
            return
        end
        if CursorHasItem() then -- only process picked up items
            local Placed
            for bag = LastBag, 4 do -- bag 0 is the backpack
                local slots = GetContainerNumSlots(bag)
                for LastSlot = LastSlot, slots do
                    local itemID = GetContainerItemID(bag, LastSlot)
                    if not itemID then
                        PutItemInBag(bag+19)
                        Placed = true -- so scram
                        break
                    end
                end
                if bag > LastBag then
                    LastBag = bag
                    LastSlot = 1
                end
                if Placed then break end
            end
            if not Placed then -- no empty slots in bags
                local GotSpace
                for i=1, GetContainerNumSlots(0) do -- make sure the backpack isn't full as well
                    if not GetContainerItemID(0, i) then
                        GotSpace = true
                        break
                    end
                end
                if not GotSpace then  -- No more slots in backpack to put stuff either
                    print("Not enough backpack space!")
                    Remove = nil
                    return 
                end
                PutItemInBackpack()
            end
            break
        end
    end
end
 
local f = CreateFrame("Frame")
f:RegisterEvent("BAG_UPDATE")
f:SetScript("OnEvent", function(self, event, ...)
    if event == "BAG_UPDATE" then -- if you are using the handler for more than this event
        if Remove then
            SaveToBags()
            return -- maybe, if you are doing other things with this event as well
        end
--  elseif event == "SOME_EVENT" then
    end
end)
 
SLASH_XXX1 = "/xx"
SlashCmdList.XXX = function()
    LastBag = 1 
    LastSlot = 1
    Remove = INVSLOT_FIRST_EQUIPPED
    SaveToBags()
end

Edit: I didn't notice Kanegasi had made changes before doing this...

[Walkerbo]

Hi Kanegasi and Fizzlemizz

Thanks for your answers.

Fizzlemizz, I can see the wait makes a lot of sense, it is something I should have picked up myself

I do have a couple of questions about your solutions.

You both used;

PutItemInBag(bag+19)

I dont understand where the 19 comes into it?

And Kanegasi you set up a table to record all placed items;

local ignore={[0]={},[1]={},[2]={},[3]={},[4]={},}

Is it necassary to record where items were placed, or is this just good practise?

[Fizzlemizz]

Kanegasi mentioned that PutItemInBag requires a bag id. (InventorySlotId) not a bag number and these start at 20 (bag 1+19 = 20).

Using the table keeps track of where you put the last item instead of using the event method. Checking GetContainerItemID in a tight loop can return nil for a slot that has only just been filled in the previous loop(s) until the system catches up and sends the event which could cause a "Bag is full" message.

[Kanegasi]

Fizzlemizz, I left this thread open on my phone's browser just after your post, so I didn't catch your edits either lol.

Anyways, to expand on InventorySlotId: https://wowpedia.fandom.com/wiki/InventorySlotId
And PutItemInBag: https://wowpedia.fandom.com/wiki/API_PutItemInBag

Basically, your character's entire "inventory" is actually your equipped items, your equipped bags (where items are saved elsewhere), your 28 base bank slots, and then your equipped bank bags. On retail, this counts all the way to 86. 0 is the old unused ammo slot, 1 is your head, 2 is your neck, 19 is your tabard, 20 is the first bag next to your backback, 21-23 is the next three. I'm honestly not sure what 24-51 is, then 52-79 is your base bank, and finally 80-86 is your bank bags.

Also, Fizzlemizz nailed the table explanation. It's a temporary table that starts off blank every time you use this code and is a quick solution to track slots where your unequipped items get dropped into. The slots may actually not line up depending on how you have new items enter your bags, but it still works in the end because the loop will find the, say for example, four empty slots and the table will treat those spots filled in the eyes of this loop when it dumps four of your pieces in.

[Walkerbo]

Hi Kanegasi and Fizzlemizz

Thanks for the further explainations, I do really appreciate your help.

You two absolutely rock

Cheers

[briskman3000]

Originally Posted by Kanegasi I'm honestly not sure what 24-51 is

If I had to guess, they probably have something to do with the old Keyring system. It was dynamically sized with up to 32 slots.

IIRC when the added the 4 extra backpack slots for having an authenticator, they repurposed they keyring system for those slots. Counting up the number of slots in spots 24 - 51 gives you 28, which would be the 28 unassigned numbers you see there.

I'm completely pulling this out of my ass and my be completely wrong, but it all makes sense to me.