Using LibBabble for Translations

gOOvER · 12-31-14, 02:02 AM

There are some Libs for Translations. I think it's better to Use this one, insteed of adding translations:

See:

http://www.wowace.com/search/?scope=...rch=LibBabble-

gOOvER · 12-31-14, 04:53 AM

Added Support in last Commint for LibBabble-Boss

atl77 · 12-31-14, 01:02 PM

Originally Posted by gOOvER

Added Support in last Commint for LibBabble-Boss

Pull Request denied, reasons here: https://github.com/Rythal/Carbonite/pull/202

gOOvER · 01-01-15, 12:38 AM

And why you close it? i can revert the 3 lines.

Please reopen, i don't want to loose the other work.

Rythal · 01-01-15, 12:50 AM

Re-opened it.

Still new to git but I believe you should of still had your groover/Master which could of been used to push a new commit after the library was removed.

gOOvER · 01-01-15, 01:42 AM

Yes, your right. But so i would open a new PR

Lib Remove and Translations Carbonite.Weekly up2date for all languages