Set Script function

[Uitat]

ok so im bout to go batty,
im trying to figure out how to incorperate this in to my addon

/script ChatFrame1:SetPoint("BOTTOMLEFT","LeftChatBaseFrame","BOTTOMLEFT", 0 ,0);
--x,y coordinants to docked frame (BottomLeft Corner, Main Chat)
/script ChatFrame1:SetPoint("TOPRIGHT","LeftChatBaseFrame","BOTTOMLEFT",451 ,241);
--x,y coordinants to docked frame (TopRight Corner, Main Chat)
/script ChatFrame2:SetPoint("BOTTOMLEFT","RightChatBaseFrame","BOTTOMLEFT", 8 ,0);
--x,y coordinants to docked frame (BottomLeft Corner, Combat Window)
/script ChatFrame2:SetPoint("TOPRIGHT","RightChatBaseFrame","BOTTOMLEFT",455 ,194);
--x,y coordinants to docked frame (TopRight Corner, Combat Window)


im trying to make a event handled function for rolling these scripts, but darn i really do not want to have an entire page devoted to this, lol

im thinking on player enters world run script above, i do not want to use XML and i know there is a way to lua it out but for the life of me i cant remember it

[Tim]

local DummyFrame = CreateFrame("Frame")
DummyFrame:SetScript("OnEvent", function(self, event, ...)
   if (event == "PLAYER_ENTERING_WORLD") then
      ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 0, 0)
      ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", 451, 241)
      ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0)
      ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", 455, 194)
   end
end)

Of course for this to work you're going to need a valid parent named LeftChatBaseFrame and RightChatBaseFrame. You may need/want to clear all points for both chat frames as well. ChatFrame1:ClearAllPoints() ChatFrame2:ClearAllPoints() and those would need to be placed before the setpoints.

http://wowpedia.org/API_Frame_SetScript

[Uitat]

Originally Posted by Tim local DummyFrame = CreateFrame("Frame") DummyFrame:SetScript("OnEvent", function(self, event, ...) if (event == "PLAYER_ENTERING_WORLD") then ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 0, 0) ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", 451, 241) ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0) ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", 455, 194) end end) Of course for this to work you're going to need a valid parent named LeftChatBaseFrame and RightChatBaseFrame. You may need/want to clear all points for both chat frames as well. ChatFrame1:ClearAllPoints() ChatFrame2:ClearAllPoints() and those would need to be placed before the setpoints. http://wowpedia.org/API_Frame_SetScript

thank you man for the imput, im going to chk this out and see if this is exactly what i am looking for, my code was already 58 lines long and growing

[Uitat]

Originally Posted by Tim local DummyFrame = CreateFrame("Frame")

Originally Posted by Tim DummyFrame:SetScript("OnEvent", function(self, event, ...) if (event == "PLAYER_ENTERING_WORLD") then ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 0, 0) ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", 451, 241) ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0) ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", 455, 194) end end) Of course for this to work you're going to need a valid parent named LeftChatBaseFrame and RightChatBaseFrame. You may need/want to clear all points for both chat frames as well. ChatFrame1:ClearAllPoints() ChatFrame2:ClearAllPoints() and those would need to be placed before the setpoints. http://wowpedia.org/API_Frame_SetScript

ok here it is with the top portion of my code no longer referancing to the file that i was working on, i just dumped it in after my chat frame creation

-- welcome to Project Deranjata Artwork, Visual Style Portion of Project Deranjata

local aspect = CreateFrame("Frame", nil, UIParent)
aspect:RegisterEvent("PLAYER_ENTERING_WORLD")
aspect:SetScript("OnEvent", function(self, event)
    UIParent:SetScale(0.6)    -- you can change the scale here but you will break the entire add-on --
    aspect:UnregisterAllEvents()
    print ("Your Resolution Scale has been changed to 0.6")
    print ("Welcome to Project Deranjata, Version 0.0.1.0a, Your input is Needed, please be sure to visit us on www.wowinterface.com . all input is welcomed, next stage is Action Bars. Have fun and !!!Good Luck!!!")
end)

local resolHeight = GetScreenHeight()
local resolWidth = GetScreenWidth()
local aspectRatio = (resolWidth/resolHeight)
print(format("If this function works, your aspect ratio is %.2f.", aspectRatio))

--This is the Backdrop Variable--
local backdrop = {
bgFile = "Interface\\DialogFrame\\UI-DialogBox-Background",
edgeFile = "Interface\\DialogFrame\\UI-DialogBox-Border",
tile = true,
tileSize = 32,
edgeSize = 20,
insets = {
left = 4,
right = 4,
top = 4,
bottom = 4,
}
}

local backdropClear = {
--bgFile = "Interface\\DialogFrame\\UI-DialogBox-Background",
edgeFile = "Interface\\DialogFrame\\UI-DialogBox-Border",
tile = true,
tileSize = 32,
edgeSize = 20,
insets = {
left = 4,
right = 4,
top = 4,
bottom = 4,
}
}
-- This is Left Main Frame Chunk
local frame = CreateFrame("frame", "LeftChatBaseFrame", UIParent)
LeftChatBaseFrame:SetWidth(resolWidth*.34)
LeftChatBaseFrame:SetHeight(resolHeight*.33)
LeftChatBaseFrame:SetPoint("BOTTOMLEFT", UIParent,"BOTTOMLEFT", -6, -6)
LeftChatBaseFrame:SetFrameStrata("BACKGROUND")
LeftChatBaseFrame:SetFrameLevel(1)
LeftChatBaseFrame:SetAlpha(1)
LeftChatBaseFrame:SetBackdrop(backdrop)
-- This is Right Main Frame Chunk
local frame = CreateFrame("frame", "RightChatBaseFrame", UIParent)
RightChatBaseFrame:SetWidth(resolWidth*.34)
RightChatBaseFrame:SetHeight(resolHeight*.33)
RightChatBaseFrame:SetPoint("BOTTOMRIGHT", UIParent,"BOTTOMRIGHT", 6, -6)
RightChatBaseFrame:SetFrameStrata("BACKGROUND")
RightChatBaseFrame:SetFrameLevel(1)
RightChatBaseFrame:SetAlpha(1)
RightChatBaseFrame:SetBackdrop(backdrop)

--set chat frame to proper position
local DummyFrame = CreateFrame("Frame")
DummyFrame:RegisterEvent("PLAYER_ENTERING_WORLD")
DummyFrame:SetScript("OnEvent", function(self, event, ...)
   if (event == "PLAYER_ENTERING_WORLD") then
           ChatFrame1:ClearAllPoints() 
           ChatFrame2:ClearAllPoints()
      ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 0, 0)
      ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", 451, 241)
      ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0)
      ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", 455, 194)
   end
end)

took the advice on the CAP function, also added in a Register event so it could see it happening

[Uitat]

and the final product, which makes it scale-able to any resolution that the user chooses, on enter world or reload it will auto configure to the resolution they have chosen,

local DummyFrame = CreateFrame("Frame")
DummyFrame:RegisterEvent("PLAYER_ENTERING_WORLD")
DummyFrame:SetScript("OnEvent", function(self, event, ...)
   if (event == "PLAYER_ENTERING_WORLD") then
   		ChatFrame1:ClearAllPoints() 
   		ChatFrame2:ClearAllPoints()
      ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 8, 0)
      ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.310))
      ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0)
      ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.252))
   end
end)

whatcha think?

[Seerah]

You don't need to check if your event matches "PLAYER_ENTERING_WORLD" because that is the only event your frame is registered for.

Also, unregister that event at the end of your function. Otherwise your code will run on every load screen and it doesn't need to.

[Uitat]

so you mean something like this?

local DummyFrame = CreateFrame("Frame")
DummyFrame:RegisterEvent("PLAYER_ENTERING_WORLD")
DummyFrame:SetScript("OnEvent", function(self, event, ...)
   if (event == "PLAYER_ENTERING_WORLD") then
           ChatFrame1:ClearAllPoints() 
           ChatFrame2:ClearAllPoints()
      ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 8, 0)
      ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.310))
      ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0)
      ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.252))
   end
DummyFrame:UnregisterEvent("PLAYER_ENTERING_WORLD")
end)

[Seerah]

Yes, but you still don't need to check if the event that fired was "PLAYER_ENTERING_WORLD", unless you're registering more than just that event to your frame.

[Tim]

What Seerah is saying is that if you only plan on using this code for PLAYER_ENTERING_WORLD you can bypass the If then statement like so:

local DummyFrame = CreateFrame("Frame")
DummyFrame:RegisterEvent("PLAYER_ENTERING_WORLD")
DummyFrame:SetScript("OnEvent", function(self, event, ...)
   ChatFrame1:ClearAllPoints() 
   ChatFrame2:ClearAllPoints()
   ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 8, 0)
   ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.310))
   ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0)
   ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.252))
   DummyFrame:UnregisterEvent("PLAYER_ENTERING_WORLD")
end)

[Uitat]

Originally Posted by Tim What Seerah is saying is that if you only plan on using this code for PLAYER_ENTERING_WORLD you can bypass the If then statement like so: local DummyFrame = CreateFrame("Frame") DummyFrame:RegisterEvent("PLAYER_ENTERING_WORLD") DummyFrame:SetScript("OnEvent", function(self, event, ...) ChatFrame1:ClearAllPoints() ChatFrame2:ClearAllPoints() ChatFrame1:SetPoint("BOTTOMLEFT", LeftChatBaseFrame, "BOTTOMLEFT", 8, 0) ChatFrame1:SetPoint("TOPRIGHT", LeftChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.310)) ChatFrame2:SetPoint("BOTTOMLEFT", RightChatBaseFrame, "BOTTOMLEFT", 8, 0) ChatFrame2:SetPoint("TOPRIGHT", RightChatBaseFrame, "BOTTOMLEFT", (resolWidth*.334), (resolHeight*.252)) DummyFrame:UnregisterEvent("PLAYER_ENTERING_WORLD") end)

tim thank you much for clerifying thatif you all dont know, the smaller i can make this code and the cleaner it is the better, since i am the only maintainer, its goina be a handful on changes to the API,


makes sens to only check if its only on player enters world instead of every reload
... question, why does everyone code seem so pretty compare to mine hahaha