Nx.Quest inquiry

[Thrumbar]

Was going through the NxQuest.lua and cam across this. Should the be 1, 25 do as the limit was raised to 25 some time ago ???



2995 function Nx.Quest:CalcWatchColors()
2996
2997 -- Nx.QLocColors = { 1,0,0, "QuestWatchR", 0,1,0, "QuestWatchG", .2,.2,1, "QuestWatchB" }
2998
2999 local opts = self.GOpts
3000
3001 local colors = {}
3002 self.QLocColors = colors
3003
3004 local a = Nx.Util_str2a (Nx.qdb.profile.Quest.MapWatchAreaAlpha)
3005
3006 local colMax = Nx.qdb.profile.Quest.MapWatchColorCnt
3007 local colI = 1
3008
3009 for n = 1, 15 do

4624 for n = 1, 15 do

6753 for ln = 1, 15 do

7075 for n = 1, 15 do

7158 for n = 1, 15 do

7497 for n = 1, 15 do

9677 for objn = 1, 15 do


Thrumbar

[JWMcQuire]

I'm using the latest version from Github which shows the quest limit as x/25 on both the quest watch and quest log window title bars.

So I don't see any need to change the code if it already shows up correctly in-game.

P.S.
Also, are you sure this code has to do with the quest limit and not the color settings?

[Thrumbar]

As far I I read it there is only 12 colors involved in the quest watch. (As viewed in the setting) Though it may be a timing and not the true quest limit. I only thought it involves quest limit as in one of the changes it list Objectives max 15.

Thrumbar

Originally Posted by JWMcQuire I'm using the latest version from Github which shows the quest limit as x/25 on both the quest watch and quest log window title bars. So I don't see any need to change the code if it already shows up correctly in-game. P.S. Also, are you sure this code has to do with the quest limit and not the color settings?

[JWMcQuire]

Thanks for clarifying that.

However, I would assume that if Carbonite shows the right data in-game, then I would say it is best not to push any changes unless such changes improve the function of the addon.

[Thrumbar]

I can understand your point and have closed my pull request. Will reevaluate what I put in future pull request and delay any until after Legion fully launches. Unless it is to fix a issue...

Thrumbar

Originally Posted by JWMcQuire Thanks for clarifying that. However, I would assume that if Carbonite shows the right data in-game, then I would say it is best not to push any changes unless such changes improve the function of the addon.

[JWMcQuire]

Originally Posted by Thrumbar . . . delay any until after Legion fully launches. Unless it is to fix a issue... Thrumbar

I've decided to hold off too. My most recent pull request was me being bored and wanting to "fix" something that bugged me about the min/max button locations.

I've pretty much gone dry on WoW again, but remain active to do a little fishing and farm apexis crystals to upgrade my soon-to-be outdated gear to get ready for Legion's release.