ArenaFrames script pops error when combat start

[plopek]

Hello,

So i have this script from some russian forum. I made it to work to my needs in legion, but I'm getting some error in some situation like killing mobs out of the world. I can't really specify when. It seems like its happens randomly. What I know it is trying to run outside of arena when it is not supposed to.

12x [ADDON_ACTION_BLOCKED] AddOn 'Mods' tried to call the protected function 'ArenaEnemyFrames:ClearAllPoints()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `ClearAllPoints'
FrameXML\UIParent.lua:2769: in function `UIParentManageFramePositions'
FrameXML\UIParent.lua:2057: in function <FrameXML\UIParent.lua:2044>
[C]: in function `SetAttribute'
FrameXML\UIParent.lua:2807: in function `UIParent_ManageFramePositions'
FrameXML\MainMenuBar.lua:384: in function `MainMenuBarVehicleLeaveButton_Update'
FrameXML\MainMenuBar.lua:358: in function <FrameXML\MainMenuBar.lua:357>
 
Locals:

-----------------------------------------------------------------------
-----------------------------------------------------------------------
local ArenaFrames = 1 -------------------------------------------------
-----------------------------------------------------------------------
-----------------------------------------------------------------------
 
--[[------------------------
    Arena frames / trinkets
--------------------------]]
 
if (ArenaFrames == 1) then
    local trinkets = {}
    local events = CreateFrame("Frame")
    function events:ADDON_LOADED(addonName)
        if addonName ~= "Blizzard_ArenaUI" then
            return
        end
            ArenaEnemyFrame1:ClearAllPoints()
            ArenaEnemyFrame1:SetPoint("CENTER", TargetFrame, "CENTER", 117, 265)        
            ArenaEnemyFrame1.SetPoint = function() end  
            ArenaEnemyFrame2:ClearAllPoints()
            ArenaEnemyFrame2:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -60)
            ArenaEnemyFrame2.SetPoint = function() end
            ArenaEnemyFrame3:ClearAllPoints()
            ArenaEnemyFrame3:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -120)
            ArenaEnemyFrame3.SetPoint = function() end
            ArenaEnemyFrame4:ClearAllPoints()
            ArenaEnemyFrame4:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -180)
            ArenaEnemyFrame4.SetPoint = function() end
            ArenaEnemyFrame5:ClearAllPoints()
            ArenaEnemyFrame5:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -240)
            ArenaEnemyFrame5.SetPoint = function() end  
                ArenaPrepFrame1:ClearAllPoints()
                ArenaPrepFrame1:SetPoint("CENTER", TargetFrame, "CENTER", 117, 265)
                ArenaPrepFrame1.SetPoint = function() end
                ArenaPrepFrame2:ClearAllPoints()
                ArenaPrepFrame2:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -50)
                ArenaPrepFrame2.SetPoint = function() end
                ArenaPrepFrame3:ClearAllPoints()
                ArenaPrepFrame3:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -100)
                ArenaPrepFrame3.SetPoint = function() end
                ArenaPrepFrame4:ClearAllPoints()
                ArenaPrepFrame4:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -150)
                ArenaPrepFrame4.SetPoint = function() end
                ArenaPrepFrame5:ClearAllPoints()
                ArenaPrepFrame5:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -200)
                ArenaPrepFrame5.SetPoint = function() end
            ArenaPrepFrames:SetScale(1.20)            
            ArenaEnemyFrames:SetScale(1.20)         
        local arenaFrame, trinket
        for i = 1, MAX_ARENA_ENEMIES do
            arenaFrame = "ArenaEnemyFrame"..i
            trinket = CreateFrame("Cooldown", arenaFrame.."Trinket", ArenaEnemyFrames)
            trinket:SetPoint("TOPRIGHT", arenaFrame, 35, -6)
            trinket:SetSize(24, 24)
            trinket.icon = trinket:CreateTexture(nil, "BACKGROUND")
            trinket.icon:SetAllPoints()
            trinket.icon:SetTexture("Interface\\Icons\\inv_jewelry_trinketpvp_02")
            trinket:Hide()
            trinkets["arena"..i] = trinket
        end
        self:UnregisterEvent("ADDON_LOADED")
    end
    function events:UNIT_SPELLCAST_SUCCEEDED(unitID, spell, rank, lineID, spellID)
        if not trinkets[unitID] then
            return
        end
        if spellID == 59752 or spellID == 42292 or spellID == 195710 then
            CooldownFrame_Set(trinkets[unitID], GetTime(), 180, 1)
            SendChatMessage("Trinket used by: "..GetUnitName(unitID, true), "PARTY")    
        end
    end
    function events:PLAYER_ENTERING_WORLD()
        local _, instanceType = IsInInstance()
        if instanceType == "arena" then
            self:RegisterEvent("UNIT_SPELLCAST_SUCCEEDED")
        elseif self:IsEventRegistered("UNIT_SPELLCAST_SUCCEEDED") then
            self:UnregisterEvent("UNIT_SPELLCAST_SUCCEEDED")
            for _, trinket in pairs(trinkets) do
                trinket:SetCooldown(0, 0)
                trinket:Hide()
            end
        end
    end
    SLASH_TEST1 = "/arena"
    SlashCmdList["TEST"] = function(msg, editBox)
        if not IsAddOnLoaded("Blizzard_ArenaUI") then
            LoadAddOn("Blizzard_ArenaUI")
        end
        ArenaEnemyFrames:Show()
        
        local focusFrame
            if FocusFrame:Show() then
                FocusFrame.classPortrait:SetTexture("Interface\\TargetingFrame\\UI-Classes-Circles")
                FocusFrame.classPortrait:SetTexCoord(unpack(CLASS_ICON_TCOORDS["WARRIOR"]))
                FocusFrame.name:SetText("Badguy")
                FocusFrame:Show()
            end
        local arenaFrame
        for i = 1, 4 do
            arenaFrame = _G["ArenaEnemyFrame"..i]       
            arenaFrame.classPortrait:SetTexture("Interface\\TargetingFrame\\UI-Classes-Circles")
            arenaFrame.classPortrait:SetTexCoord(unpack(CLASS_ICON_TCOORDS["WARRIOR"]))
            arenaFrame.name:SetText("Badguy")
            arenaFrame:Show()               
            CooldownFrame_Set(trinkets["arena"..i], GetTime(), 180, 1)      
        end
    end
    events:SetScript("OnEvent", function(self, event, ...) return self[event](self, ...) end)
    events:RegisterEvent("ADDON_LOADED")
    events:RegisterEvent("PLAYER_ENTERING_WORLD")
    events:RegisterEvent("PLAYER_ENTERING_WORLD")
end

Can you guys help me to get this issue solved.
Thank you in advance.

[Phanx]

You can't do things like this:

ArenaEnemyFrame1.SetPoint = function() end

When you override a method (eg. SetPoint) on a secure frame (eg. ArenaEnemyFrame1) then any time the default UI calls that method, it calls your (insecure, because it's in an addon) function instead of the original (secure, because it's in Blizzard code) function, and that makes the entire code path count as insecure. If that's happening while you're in combat, you get an "action blocked" error because insecure code isn't allowed to move secure frames while in combat.

Based on a quick skim of the default UI code, it looks like the default UI doesn't even move the arena frames directly -- it only moves an intermediate parent frame, "ArenaEnemyFrames". You should be able to solve the problem by re-parenting the individual arena frames to the UIParent instead, eg.

ArenaEnemyFrame1:SetParent(UIParent)

Do that before you ClearAllPoints and SetPoint.

Also, you probably want to do the same thing with the arena prep frames, which are named ArenaPrepFrame1 through ArenaPrepFrame5, otherwise they will show up in the default location.

[plopek]

Thank you for reply Phanx,

I've tried the method u mentioned but it didn't work. ArenaPrepFrames moved to desired location without error but ArenaFrames didn't move at all and it pops error as soon as game started.

4x [ADDON_ACTION_BLOCKED] AddOn 'Mods' tried to call the protected function 'ArenaEnemyFrames:ClearAllPoints()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `ClearAllPoints'
FrameXML\UIParent.lua:2769: in function `UIParentManageFramePositions'
FrameXML\UIParent.lua:2057: in function <FrameXML\UIParent.lua:2044>
[C]: in function `SetAttribute'
FrameXML\UIParent.lua:2807: in function `UIParent_ManageFramePositions'
FrameXML\BuffFrame.lua:318: in function `BuffFrame_UpdateAllBuffAnchors'
FrameXML\BuffFrame.lua:103: in function `BuffFrame_Update'
FrameXML\BuffFrame.lua:48: in function <FrameXML\BuffFrame.lua:44>
 
Locals:

I hope I did it the way you suggested

-----------------------------------------------------------------------
-----------------------------------------------------------------------
local ArenaFrames = 1 -------------------------------------------
-----------------------------------------------------------------------
-----------------------------------------------------------------------
 
--[[------------------------
    Arena frames / trinkets
--------------------------]]
 
if (ArenaFrames == 1) then
    local trinkets = {}
    local events = CreateFrame("Frame")
    function events:ADDON_LOADED(addonName)
        if addonName ~= "Blizzard_ArenaUI" then
            return
        end
            ArenaEnemyFrame1:SetParent(UIParent)
            ArenaEnemyFrame1:ClearAllPoints()
            ArenaEnemyFrame1:SetPoint("CENTER", TargetFrame, "CENTER", 117, 265)        
            --ArenaEnemyFrame1.SetPoint = function() end
            ArenaEnemyFrame2:SetParent(UIParent)
            ArenaEnemyFrame2:ClearAllPoints()
            ArenaEnemyFrame2:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -60)
            --ArenaEnemyFrame2.SetPoint = function() end
            ArenaEnemyFrame3:SetParent(UIParent)
            ArenaEnemyFrame3:ClearAllPoints()
            ArenaEnemyFrame3:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -120)
            --ArenaEnemyFrame3.SetPoint = function() end
            ArenaEnemyFrame4:SetParent(UIParent)
            ArenaEnemyFrame4:ClearAllPoints()
            ArenaEnemyFrame4:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -180)
            --ArenaEnemyFrame4.SetPoint = function() end
            ArenaEnemyFrame5:SetParent(UIParent)
            ArenaEnemyFrame5:ClearAllPoints()
            ArenaEnemyFrame5:SetPoint("BOTTOMLEFT", ArenaEnemyFrame1, "BOTTOMLEFT", 0, -240)
            --ArenaEnemyFrame5.SetPoint = function() end
                ArenaPrepFrame1:SetParent(UIParent)
                ArenaPrepFrame1:ClearAllPoints()
                ArenaPrepFrame1:SetPoint("CENTER", TargetFrame, "CENTER", 117, 265)
                --ArenaPrepFrame1.SetPoint = function() end
                ArenaPrepFrame2:SetParent(UIParent)
                ArenaPrepFrame2:ClearAllPoints()
                ArenaPrepFrame2:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -50)
                --ArenaPrepFrame2.SetPoint = function() end
                ArenaPrepFrame3:SetParent(UIParent)
                ArenaPrepFrame3:ClearAllPoints()
                ArenaPrepFrame3:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -100)
                --ArenaPrepFrame3.SetPoint = function() end
                ArenaPrepFrame4:SetParent(UIParent)
                ArenaPrepFrame4:ClearAllPoints()
                ArenaPrepFrame4:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -150)
                --ArenaPrepFrame4.SetPoint = function() end
                ArenaPrepFrame5:SetParent(UIParent)
                ArenaPrepFrame5:ClearAllPoints()
                ArenaPrepFrame5:SetPoint("TOPRIGHT", ArenaPrepFrame1, "TOPRIGHT", 0, -200)
                --ArenaPrepFrame5.SetPoint = function() end
            ArenaPrepFrames:SetScale(1.20)            
            ArenaEnemyFrames:SetScale(1.20)         
        local arenaFrame, trinket
        for i = 1, MAX_ARENA_ENEMIES do
            arenaFrame = "ArenaEnemyFrame"..i
            trinket = CreateFrame("Cooldown", arenaFrame.."Trinket", ArenaEnemyFrames)
            trinket:SetPoint("TOPRIGHT", arenaFrame, 35, -6)
            trinket:SetSize(24, 24)
            trinket.icon = trinket:CreateTexture(nil, "BACKGROUND")
            trinket.icon:SetAllPoints()
            trinket.icon:SetTexture("Interface\\Icons\\inv_jewelry_trinketpvp_02")
            trinket:Hide()
            trinkets["arena"..i] = trinket
        end
        self:UnregisterEvent("ADDON_LOADED")
    end
    function events:UNIT_SPELLCAST_SUCCEEDED(unitID, spell, rank, lineID, spellID)
        if not trinkets[unitID] then
            return
        end
        if spellID == 59752 or spellID == 42292 or spellID == 195710 then
            CooldownFrame_Set(trinkets[unitID], GetTime(), 180, 1)
            SendChatMessage("Trinket used by: "..GetUnitName(unitID, true), "PARTY")    
        end
    end
    function events:PLAYER_ENTERING_WORLD()
        local _, instanceType = IsInInstance()
        if instanceType == "arena" then
            self:RegisterEvent("UNIT_SPELLCAST_SUCCEEDED")
        elseif self:IsEventRegistered("UNIT_SPELLCAST_SUCCEEDED") then
            self:UnregisterEvent("UNIT_SPELLCAST_SUCCEEDED")
            for _, trinket in pairs(trinkets) do
                trinket:SetCooldown(0, 0)
                trinket:Hide()
            end
        end
    end
    SLASH_TEST1 = "/arena"
    SlashCmdList["TEST"] = function(msg, editBox)
        if not IsAddOnLoaded("Blizzard_ArenaUI") then
            LoadAddOn("Blizzard_ArenaUI")
        end
        ArenaEnemyFrames:Show()
        local focusFrame
            if FocusFrame:Show() then
                FocusFrame.classPortrait:SetTexture("Interface\\TargetingFrame\\UI-Classes-Circles")
                FocusFrame.classPortrait:SetTexCoord(unpack(CLASS_ICON_TCOORDS["WARRIOR"]))
                FocusFrame.name:SetText("Badguy")
                FocusFrame:Show()
            end
        local arenaFrame
        for i = 1, 4 do
            arenaFrame = _G["ArenaEnemyFrame"..i]       
            arenaFrame.classPortrait:SetTexture("Interface\\TargetingFrame\\UI-Classes-Circles")
            arenaFrame.classPortrait:SetTexCoord(unpack(CLASS_ICON_TCOORDS["WARRIOR"]))
            arenaFrame.name:SetText("Badguy")
            arenaFrame:Show()               
            CooldownFrame_Set(trinkets["arena"..i], GetTime(), 180, 1)      
        end
    end
    events:SetScript("OnEvent", function(self, event, ...) return self[event](self, ...) end)
    events:RegisterEvent("ADDON_LOADED")
    events:RegisterEvent("PLAYER_ENTERING_WORLD")
    events:RegisterEvent("PLAYER_ENTERING_WORLD")
end

[Phanx]

I don't immediately see anything in your code that should cause that error. The only things I can think of are:

a) You forgot to reload the UI after saving your changes, or you forgot to save the file before reloading the UI.

b) You have some other code in the same addon that's doing Bad Things.

c) You are somehow already in combat when the Blizzard_ArenaUI loads -- but that should cause a different "action blocked" error whose stack trace doesn't originate within the Blizzard "move all the things" function.

Without any further information (b) seems like the most likely problem.