Runebar bug

[zork]

I tested my new runebar module and found a bug with the color init.

This does not return the correct value for me on the first login of a character:
https://github.com/haste/oUF/blob/ma...nebar.lua#L119

Changing that to:

UpdateType(self, nil, i, floor((i+1)/2))

fixed it. (holy and frost where swapped)

[haste]

The correct order should be death/blood, frost, unholy. Isn't this what you were seeing?

[lightspark]

Originally Posted by haste The correct order should be death/blood, frost, unholy. Isn't this what you were seeing?

zork is right, with your implementation we get order of blood, unholy, frost. I did a small test: logged in and then reloaded UI, and here is what i've got

[haste]

No, your forgetting that the API returns the incorrect order, which is why we have the runemap to re-arrange it. The API returns blood, unholy and frost.

[lightspark]

Another test, using oUF from github



As you can see, I’ve got the order of blood, unholy, frost, but that's only colors, 'cause when i use any spell, which consumes unholy rune, the blue one (on the left side of a picture) recharges
Then i reloaded UI and I’ve got correct order, 'cause oUF uses data returned by GetRuneType(rid) instead of alt in this line:

local colors = self.colors.runes[GetRuneType(rid) or alt]

May be there is an error in some other place because of that usage of runemap, but there IS an error.
The way i created that runebar is the same as the one in an example code of runebar.lua

[zork]

That is exactly what my tests turned out aswell.
On first login of a char (not reload) GetRuneType is using a wrong value.

[haste]

I'm actually unable to re-create this. Even gave it a whirl with 64-bit WoW to see if it made any difference.

[lightspark]

Haha, I've got it After rewriting the code for 5.0.4, I forgot to put Spawn and SetActiveStyle functions inside oUF:Factory. I just used those functions without it.
Previously I had this:

oUF:SetActiveStyle("Player")
oUF:Spawn("player", "oUF_PlayerFrame")

and I've got the same bug as zork did, now i changed code to this:

oUF:Factory(function(self)
    self:SetActiveStyle("Player")
    self:Spawn("player", "oUF_PlayerFrame")
end)

and everything works just fine

[haste]

Nice! I'll dig into it then.

[lightspark]

And one more test, haste, there IS a bug with alt
Previously I checked the value returned by GetRuneType and alt, but I didn't check the order in which runes are created.
So, I gave names to all the runes I wanna spawn and then I get them via GetName() on the first call of UpdateType Runes are created in this order 1, 2, 5, 6, 3, 4, so there is no need to make alt be 1, 1, 3, 3, 2, 2, because runes already are in correct(required) order.



P.S. I'm afraid I'm some kind of captain obvious right now and everyone except me already knew it
P.P.S. Remove maintank.lua from oUF.xml

[haste]

Pushed.

https://github.com/haste/oUF/compare...d...83a12d7830

[Rainrider]

Wouldn't it be helpful to pass runeReady along to PostUpdateRune, so we don't have to call GetRuneCooldown again?

[haste]

Thanks, somehow managed to miss the potential arguments while adding those.

https://github.com/haste/oUF/compare...0...aa453967bf