Action blocked taint spam.

[Lesteryoung]

I've been getting action blocked errors consistently and so did a taintLog and this showed up,

10/3 01:42:50.577  An action was blocked in combat because of taint from ModifyFrames - Boss1TargetFrame:SetPoint()
10/3 01:42:50.577      Interface\FrameXML\UIParent.lua:2861 <unnamed>:UIParentManageFramePositions()
10/3 01:42:50.577      Interface\FrameXML\UIParent.lua:2160
10/3 01:42:50.577      <unnamed>:SetAttribute()
10/3 01:42:50.577      Interface\FrameXML\UIParent.lua:2912 UIParent_ManageFramePositions()
10/3 01:42:50.577      Interface\FrameXML\BuffFrame.lua:331 BuffFrame_UpdateAllBuffAnchors()
10/3 01:42:50.577      Interface\FrameXML\BuffFrame.lua:104 BuffFrame_Update()
10/3 01:42:50.577      Interface\FrameXML\BuffFrame.lua:49

.

The lua that is tainting is this:

--[[PetActionBarFrame:ClearAllPoints()
PetActionBarFrame:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", 322, 112)
PetActionBarFrame:SetScale(.87)]]
 
LossOfControlFrame:SetScale(.93)
SpellActivationOverlayFrame:SetScale(.94)
 
PlayerFrame.feedbackText = PlayerFrame:CreateFontString(nil, "OVERLAY", "NumberFontNormalHuge")
PlayerFrame.feedbackStartTime = 0
PetFrame.feedbackText = PlayerFrame.feedbackText
PetFrame.feedbackStartTime = 0
 
local noop = function() return end
 
for _, objname in ipairs({
    "PlayerStatusTexture",
    "PetAttackModeTexture",
    "UIErrorsFrame",
    "PetName",
    "PlayerFrameGroupIndicator",
    "MainMenuBarRightEndCap",
    "MainMenuBarLeftEndCap",
    "PlayerFrameRoleIcon",
    "PlayerAttackGlow",
    "PlayerPrestigeBadge",
    "PlayerPrestigePortrait",
    "FocusFrameTextureFramePrestigeBadge",
    "FocusFrameTextureFramePrestigePortrait",
    "TargetFrameTextureFramePrestigeBadge",
    "TargetFrameTextureFramePrestigePortrait",
    "FramerateLabel"
}) do
    local obj = _G[objname]
    if obj then
        obj:Hide()
        obj.Show = noop
    end
end
 
local obj = PlayerPlayTime:GetParent().MultiGroupFrame
obj:Hide()
obj:HookScript("OnShow",function(self) self:Hide() end)
 
FramerateText:SetPoint("LEFT",FramerateLabel,"RIGHT",-19,0)

Could someone tell me what would be causing errors in that lua? Thanks.

[MunkDev]

obj.Show = noop

This line that replaces the Show function for each of those objects also taints every one of them. Anytime :Show() is called for one of those objects from signed code, the execution path will get tainted and break if it hits a protected function call afterwards. This happens because the noop function is not from signed code.

A better approach to forcing them to stay hidden would be:

hooksecurefunc(obj, 'Show', obj.Hide)

Instead of replacing the Show function, this line will make sure it immediately calls :Hide() on the object any time :Show() is called on it.

[Lesteryoung]

Thanks, do you think I should be hiding frames that way anyway?

Should I just be doing "FrameName:Hide()" for each of those?

[MunkDev]

Sure, but if their visibility state is altered by the UI at any point they will show up again. Since you're getting errors with taint, that tells me at least one of them has their state altered through the execution path. And you can't hook the script handler on textures, because they don't have any script handlers.

[sirpucna]

bit of a necro
but i also ran into the same problem
the line thats tainting this example is:
"PlayerStatusTexture"

also another example is:
"PlayerRestGlow"

hope this helps someone else who might be searching

[Resike]

Originally Posted by sirpucna bit of a necro but i also ran into the same problem the line thats tainting this example is: "PlayerStatusTexture" also another example is: "PlayerRestGlow" hope this helps someone else who might be searching

You are probably trying to move the player frame insecurely?