Reliable Instance name function & delaying a function call

Lysiander · 10-05-11, 01:31 AM

Hello there,

I'm working on my oUF layout and am currently immersed in building a Raid Debuff functionality. It all works fine so far, but I have two problems.

1. I have a table, containing the debuffs to show set up as containing keys with zone names and subtables with IDs and priority values as values to the zone names. I have trie to use the GetInstanceInfo() function to compare instance names, but it seems to return localized names. Even when I run the function ingame via chat, inputting the name it returns in the table doesn't work. GetRealZoneText does work, but seems to be unreliable for some reason. Is there a function to return a non localized zone name? I like the option of filtering by difficulty as well as zone that GetInstanceInfo provides, so I would love to get that one to work.

2. I have linked the Debuff Check function call to the UNIT_AURA event. Since that fires pretty often I want to minimize the number of auras it has to check for. Because of this I am dynamically populating the table based on the PLAYER_ENTERING_WORLD event. This works fine so far when I change zones, but does not when I reload the UI. I suspect that this is because during the reload the game does not get usable information from the GetRealZoneText function and hence simply creates an empty table. So i am wondering wether there is a way to delay the function call for a short while. Alternatively, is there an event that would be better suited for my purposes than the PLAYER_ENTERING_WORLD one?

Thanks for your time and help.

Nibelheim · 10-05-11, 01:33 AM

This is why libBabbleZone was created

Another method would be to use the GetCurrentMapAreaID() function, but not sure what numbers it returns in a dungeon.

For events, you could use a timer, or an old trick I use is to register UPDATE_PENDING_MAIL, as it fires pretty late. Just make sure to unregister it after it first fires.

SDPhantom · 10-05-11, 02:51 AM

Have you tried GetMapInfo()? This returns the filename for the map used. Most dungeons have maps now.

Nibelheim · 10-05-11, 02:52 AM

Originally Posted by SDPhantom

Have you tried GetMapInfo()? This returns the filename for the map used. Most dungeons have maps now.

Ohhh, handy

Lysiander · 10-05-11, 03:36 AM

Thanks for the replies.
I would like to avoid libs, as I am not really comfortable in Lua (or programming in general) and want to keep things as simple as possible. I will try to hook the UPDATE_PENDING_MAIL event and see how that turns out.

GetMapInfo() sounds interesting, but how does that work for multilevel dungeons? Does it return a unique name on a per dungeon or per level basis?

Edit: It seems to be unique. I just ran through Sethekk Halls, which has two map levels and it returned "SethekkHalls" on both. I'll test a few more, but it looks like this could solve the map name issue.

Lysiander · 10-05-11, 05:08 AM

Allright, UPDATE_PENDING_MAIL does fire late enough for my purposes. However, I am unsure how to unregister the event. Basically, so far my code looks like this:

Code:

lib.gen_raidDebuffs = function(f)

<codeblock>

f:RegisterEvent("WORLD_MAP_UPDATE", ns.populateTable)
f:RegisterEvent("UPDATE_PENDING_MAIL", ns.populateTable)
f:UnregisterEvent("UPDATE_PENDING_MAIL")

The lib.gen_raidDebuffs function is, as far as I know, only called when the UnitFrames are build by oUF, that is whenever the addons are loaded. The above seems to work fine, but I was wondering if there is any way to test wether the event is actually unregistered.

SDPhantom · 10-05-11, 10:03 AM

Originally Posted by Lysiander

GetMapInfo() sounds interesting, but how does that work for multilevel dungeons? Does it return a unique name on a per dungeon or per level basis?

Edit: It seems to be unique. I just ran through Sethekk Halls, which has two map levels and it returned "SethekkHalls" on both. I'll test a few more, but it looks like this could solve the map name issue.

Here's a clip of the code used in WorldMapFrame_Update(). Note this function will return nil for both "World" and "Cosmic" maps. "Cosmic" is the map where you select either to view Outland or Azeroth. "World" is all 4 continents on Azeroth.

lua Code:

local mapFileName, textureHeight = GetMapInfo();
if ( not mapFileName ) then
    if ( GetCurrentMapContinent() == WORLDMAP_COSMIC_ID ) then
        mapFileName = "Cosmic";
        OutlandButton:Show();
        AzerothButton:Show();
    else
        -- Temporary Hack (Temporary meaning 6 yrs, haha)
        mapFileName = "World";
        OutlandButton:Hide();
        AzerothButton:Hide();
    end
    DeepholmButton:Hide();
    KezanButton:Hide();
    LostIslesButton:Hide();
    TheMaelstromButton:Hide();
else
    OutlandButton:Hide();
    AzerothButton:Hide();
    if ( GetCurrentMapContinent() == WORLDMAP_MAELSTROM_ID and GetCurrentMapZone() == 0 ) then
        DeepholmButton:Show();
        KezanButton:Show();
        LostIslesButton:Show();
        TheMaelstromButton:Show();
    else
        DeepholmButton:Hide();
        KezanButton:Hide();
        LostIslesButton:Hide();
        TheMaelstromButton:Hide();
    end
end
 
local texName;
local dungeonLevel = GetCurrentMapDungeonLevel();
if (DungeonUsesTerrainMap()) then
    dungeonLevel = dungeonLevel - 1;
end
local completeMapFileName;
if ( dungeonLevel > 0 ) then
    completeMapFileName = mapFileName..dungeonLevel.."_";
else
    completeMapFileName = mapFileName;
end
local numOfDetailTiles = GetNumberOfDetailTiles();
for i=1, numOfDetailTiles do
    texName = "Interface\\WorldMap\\"..mapFileName.."\\"..completeMapFileName..i;
    _G["WorldMapDetailTile"..i]:SetTexture(texName);
end

Lysiander · 10-05-11, 11:20 AM

If I understand that code snipped correctly, the name returned by GetMapInfo() is always the same and the game determines multilevel maps by calling GetMapInfo and adding the number of the map to the value returned by GetMapInfo(). So a short answer to my question would be: "Yes´, the name returned by GetMapInfo() is unique to the zone and not the level of the zone." Correct?

P.S. Temorary meaning 6 years... . Nice

Nibelheim · 10-05-11, 05:15 PM

To unregister the event, unregister it in the ns.populateTable function, this way it will fire at least once.

SDPhantom · 10-05-11, 08:47 PM

Originally Posted by Lysiander

So a short answer to my question would be: "Yes´, the name returned by GetMapInfo() is unique to the zone and not the level of the zone." Correct?

Yep, although I find posting code in use affirms the understanding of what it does.

Originally Posted by Lysiander

P.S. Temorary meaning 6 years... . Nice

I didn't put that in, that comment really is in the function code, lol

Lysiander · 10-06-11, 02:46 AM

To unregister the event, unregister it in the ns.populateTable function, this way it will fire at least once.

It seems to fire and unregister as planned the way I have it now, but should I run into trouble (Ill test it with some mailing later) I will do that. thanks.

Yep, although I find posting code in use affirms the understanding of what it does.

I agree, though it can be infuriating at times if you can't decipher what the code means.

As for the comment, I figured that was a blizzard comment. Their programmers have a sense of humor.

Thanks for the help you two.