Quantcast ColorPickerFrame problem - WoWInterface
 
Thread Tools Display Modes
10-31-16, 03:47 PM   #1
jaslm
A Defias Bandit
AddOn Author - Click to view addons
Join Date: Oct 2010
Posts: 2
ColorPickerFrame problem

The ColorPickerFrame display does not reflect the color passed in on the ColorSelect:Show call. This can be seen in the color wheel, bar and swatch. The initial display shows white as the color setting, and thereafter whatever color the last click set the value on the wheel to.

This breaks both the default ColorPicker and my addon ColorPickerPlus.

ColorSelect:SetColorRGB seems to set color internally, but not to display it properly in the WoW widgets.

ColorPickerPlus can still copy and paste colors, and allows text entry, but without the display working properly, it's pretty confusing.
 
11-01-16, 12:20 AM   #2
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2008
Posts: 1,739
Have you read about the frame of type ColorSelect?
http://wowprogramming.com/docs/widgets/ColorSelect
__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW) | TDMOG

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
 
11-01-16, 09:00 AM   #3
Tojaso
A Defias Bandit
 
Tojaso's Avatar
AddOn Author - Click to view addons
Join Date: Sep 2007
Posts: 3
Jaslm and I worked on this together. The standard ColorPickerFrame that is used to select colors is blizz's pre-configured ColorSelect frame. Jaslm's ColorPickerPlus hooks several of the functions in ColorPickerFrame to add features. The reported bug was introduced fairly recently and was reported by users of both the built-in color picker and ColorPickerPlus. We instrumented the code to determine that internal r, g, b values are correctly set with SetColorRGB (by checking what is returned with GetColorRGB) but the displayed color is not updated properly in blizz's ColorPickerFrame. In any case, the bug is demonstrated with the built-in color picker no longer coming up showing the color it is supposed to edit.

I'll look at the ColorPickerFrame.xml code to see if any changes were made in 7.1.
__________________
Tojaso/Tomber, author of Raven

Last edited by Tojaso : 11-01-16 at 09:25 AM.
 
11-01-16, 09:43 AM   #4
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2008
Posts: 1,739
From 7.0.3

https://github.com/tomrus88/Blizzard...127f3f0da18159

-ColorSwatch:SetTexture(r, g, b);
+ColorSwatch:SetColorTexture(r, g, b);

The framexml reflects WOW-22882patch7.1.0_PTR from 9 days ago. No changes since 7.0.3.
__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW) | TDMOG

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)

Last edited by zork : 11-01-16 at 09:45 AM.
 
 

WoWInterface » Site Forums » Archived Beta Forums » Legion Beta archived threads » ColorPickerFrame problem

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off