TraceEvent - Dynamic Lua code profiling

[Kaelten]

ok.... here is a feature request list, hehe don't hate me.


1) it would be nice if the window had maybe one or two more rows, or maybe allow us to cofig the rows.

2) a global track memory usage toggle would be good too.

3) being able to have a seperate window with information about groups of function that would logically make up an addon.

4) being able to toggle memory tracking for an "addon" with a single click

5)you said it keeps track of cps over a 3 second window, if there is could be an option to change this it would be nice.

6)I noticed that I had to add OO by KC_EnhancedTradesClass: could it be possible to only add it by the instance? what if I had KC_EnhancedTrades and KC_EnhancedTradesAdv both based off the same class(bad example I know) and I wanted to track them seprately?

7) go buy yerself a beer or your spirit of choice for doing what looks like will be such a useful mod for developers.

btw: it seems if you shift-click reset it will turn mem tracking on.

[Cairenn]

Originally Posted by Kaelten ok.... here is a feature request list, hehe don't hate me. 7) go buy yerself a bear or your spirit of choice for doing what looks like will be such a useful mod for developers.

Why would he want a bear? Or a ghost?

[Gello]

Originally Posted by Littlejohn Are you sure about table.sort? When I trace my own TraceEvent_SortStats it shows only a few bytes of memory per call. (BTW, the Mem column is in bytes, not KB.) I think table.sort sorts the array in place. (Running a test in lua.exe...) Yep. table.sort uses practically no memory at all.

Oh whew hehe looks like what I was seeing was the impact of the examining.

When tracking "Recap_.+". A function named Recap_SortList includes just a table.sort, a post-sort insertion sort (for the life of me I can't get this secondary sort working inside the table.sort but that's another story) and a redo of gauges. The latter two looked fine (just a couple hundred bytes per call) but the Recap_SortList was generating ~250-300 kilobytes per call. (and the gcinfo() seemed to agree with the memory being eaten)

But...just tracking "Recap_SortList" tracked with ~250 combatants, ~500 bytes per call of Recap_SortList. And the memory used from gcinfo() is back to barely noticable.

I'm going to have endless fun with this.

[Kaelten]

Originally Posted by Cairenn Why would he want a bear? Or a ghost?

:P I'm still waking up give me a break! hehe.

[Cairenn]

Originally Posted by Kaelten :P I'm still waking up give me a break! hehe.

Yeah. Right. That's gonna happen ...

*Stops derailing the thread and buggers off out of the way again*

[Littlejohn]

Originally Posted by Kaelten 1) it would be nice if the window had maybe one or two more rows, or maybe allow us to cofig the rows.

I'd love to know how to do this. The scrolled area is really a static group of XML frames. Any idea how to create them without hardcoding the XML? (I suppose I could create 20 or so and then just hide the ones you don't want. Ick.)

2) a global track memory usage toggle would be good too. 3) being able to have a seperate window with information about groups of function that would logically make up an addon. 4) being able to toggle memory tracking for an "addon" with a single click 5)you said it keeps track of cps over a 3 second window, if there is could be an option to change this it would be nice.

Yep, yep, yep and yep. Gello wanted (3) and (4) too. I'll have to think some more about reporting big-picture system performance.

6)I noticed that I had to add OO by KC_EnhancedTradesClass: could it be possible to only add it by the instance? what if I had KC_EnhancedTrades and KC_EnhancedTradesAdv both based off the same class(bad example I know) and I wanted to track them seprately?

I'm pretty new at Lua and especially OO in Lua. My code treats objects as just another table to find functions in -- if you don't give it a specific table, then it uses the global table. (All variables in Lua are just entries in a table.) Can you explain what you want a bit more?

What I can do is catch the difference between a class table and an object instance table. If you give it an object table, TraceEvent could put a condition on the trace function that checks if the function is being called with the object you're interested in. If you give it a class table, TraceEvent will work the way it does now. Hmm. I think I made a mistake in the syntax. I should use "." for class tables and ":" for object tables. That's consistent with Lua call syntax -- you could trace "KC_EnhancedTradesClass." or "KC_EnhancedTrades:"

Does that make any sense?

7) go buy yerself a beer or your spirit of choice for doing what looks like will be such a useful mod for developers.

Thanks! Sadly I'm putting shingles on the house today... The cold frosty bear will just have to wait a while.

[Kaelten]

hehe, as far as the scrol being adjustable, it would just have to be 20 of them in there and then hide the uneeded ones


no way to make em dynamicaly sadly.

[Quu]

would it also be possible to trace how long a function takes on average to run?

[Littlejohn]

Originally Posted by Quu would it also be possible to trace how long a function takes on average to run?

The trouble is that even a slow function runs faster than the resolution of WoW's timer. It's like measuring your pulse with a sun dial.

One possible solution I'm working on is to run a function 1000 times, measure that, and then divide the time by 1000. Surprisingly this will probably work for all OnEvent and OnUpdate handlers. Other functions maybe not. YMMV. Batteries not included.

[Quu]

what is the resolution of the GetTime() function

I throught I read somewhere that it was milisecond accurate