View Bug Report | ||||||||||||||
|
Notes | Sort Options |
By: Bremagorn - 05-31-20 05:17 AM |
You can mark this resolved. I used your suggested change to helpers.lua and it solved the problem. |
By: Fizzlemizz - 05-29-20 12:56 PM |
Further to this, taking a look at my retail version of XLoot, Xuerian has already made this change but because the Twitch client isn't updating Classic with XLoot (there being no specific version of it), I included an older one in the package. If you copy/paste the XLoot folders from Retail to Classic, it should fix this problem. |
By: Fizzlemizz - 05-29-20 12:13 PM |
Taking a look a XLoot the function is only called in one place and a small modification that doesn't materially change XLoot should resolve the problem. Line 99 of \XLoot\helpers.lua change from: local role = UnitGroupRolesAssigned(name) to: local role = UnitGroupRolesAssigned and UnitGroupRolesAssigned(name) or "NONE" Given the function doesn't exist in Classic, the value of role is essentially nil or "NONE". Any Classic release would need do something similar (although probably more elegant). |
By: Fizzlemizz - 05-29-20 11:10 AM |
My bad. There isn't a Classic version of XLoot available and I hadn't intended to include it in the package. The UnitGroupRolesAssigned function is one of those that didn't exists in Vanilla so Blizzard removed it from the Classic API. If you see the XLoot page on CurseForge (https://www.curseforge.com/wow/addons/xloot) they mention a potential problem rolling in retail and how to avoid it by turning off the "Group" module. I'm not sure what the sentence "I understand this may cause you to lose out on a item..." means, whether it's refereing to the roll that caused the error or something larger. If you get a chance to try it and turning the module off still allows you to roll (presumably using the standard mechanism), please let me know otherwise I'll probably remove XLoot from the next build. Thank you for the report Brem. |