Quantcast
View Bug Report
Bagnon Issue and Options moving bug
Bug #: 5978
File: EasyShards
Date: 07-28-09 01:52 PM
By: EVmaker
Status: Flagged for Future Version
Posted by ricks322 via WoWI:
I use Bagnon to show all my bags as one frame. After installing EasyShards the "B" button (which I mapped to open all bags) now open all the bags, but in the default config i.e. Blizzard style. If I open the bags by clicking on the backpack or any other bag I get the Bagnon version.

Also I clicked on the config menu trying to move it and got an error. I didn't get a chance to copy it, so I will recreate it and enter it later.

Here is the error if I try and move the frame.
Date: 2009-07-28 14:54:11
ID: 1
Error occured in: Global
Count: 1
Message: [string "ES1:OnDragStart"] line 1:
Frame ES1 is not movable
Debug:
(tail call): ?
[C]: ?
[C]: StartMoving()
[string "*:OnDragStart"]:1:
[string "*:OnDragStart"]:1

RSS 2.0 Feed for Bug CommentsNotes Sort Options
By: EVmaker - 07-28-09 01:53 PM
I'll be adding this to the bug report section of the portal shortly, so please keep an eye on the report there for updates. That said, I believe I'll be able to have the frame issue fixed before too long. The other I'll need to do some research, as I personally don't like 'all-in-one' bag mods, so I'll need to grab bagnon to test with.
By: EVmaker - 07-28-09 03:11 PM
Alright the frame issue is a little more complicated then I thought, so for the time being I have removed the ability for the frame to be moved (not that it moved to begin with, with the error), trying to move the frame will simply have nothing happen.

The Bagnon issue has been resolved, simple fix that just adds a couple lines of code to support Bagnon, pressing the default blizzard 'open all bags' keybind will simply call Bagnon's open inventory function. I could also have it call it's open bank/keys as well if desired, but I personally don't like having to code support for specific bag mods, when EasyShards is intended to simply be a shard handler.

That said, what did you change to 'map' B to open all bags? In default blizzard and bagnon, hitting B will open the bagnon window and close it, hitting shift-B will open the same window and close it, I don't see any difference between the shift-b and b with default blizzard keybind and bagnon. In keybinds for bagnon there are options to set keybind for inventory, bank, or keyring, but inventory is basically the same as hitting b, or blizzard's default 'open all bags' shift-b.

The reason I ask, is because in default settings you can simply hit b to open bagnon, and with easyshards the way it was, shift-b to open default blizzard bags, so there isn't really a need to code support for bagnon, since b is the same as the blizzard 'open all bags' keybind?
By: EVmaker - 07-28-09 03:13 PM
And on that note, I've flagged this awaiting feedback, as I'd like to get feedback on my question before I release this version, so going to add a comment on WoWI asking for feedback here.
By: EVmaker - 07-28-09 03:20 PM
To clarify the bottom statement a little better, "since hitting b is the same as blizzard's 'open all bags' keybind when EasyShards is not loaded?"
By: ricks322 - 07-28-09 04:42 PM
The change I had made was before I started using Bagon. I had changed the shift-B to just B, since I never just wanted to open only the backpack. But your right in the fact that since I now use bagon that change is not needed.
By: ricks322 - 07-28-09 05:02 PM
Ok, I went back and reset the keys to default, and everthing works ok now. Pressing B, which would normally open the backback opens the default bagon window. And using "Shift-B" opens the Blizzard style bags.
In short there is no reason to add code for the Bagon addon. No one else would notice the change if they had not remapped the "open all bags" key like I did.
Thanks.
By: EVmaker - 07-28-09 07:37 PM
Glad it's working for you now, if any others think it'd be useful to still have the support (which as ricks322 said will only really matter if you've remapped your blizzard open all bags keybind similar to he had) I can add it back easily enough.

To the frame issue, I'm working on it, now that the bagnon issue isn't really necessary I'm going to wait for releasing the next version until I have it fixed rather then simply getting rid of the frame movement code, so I'm going to flag this as Confirmed (Working on Fix).