Quantcast
Files 4
Downloads 21,630
Favorites 127
My AddOns
View Bug Report
Unnecessary globals
Bug #: 5887
File: Inquest
Date: 06-06-09 12:22 AM
By: Phanx
Status: Fixed
Currently Inquest is creating (at least) 4 global variables for things that don't need to be in the global namespace.

Core.lua
1: global "Inquest", add "local " prefix
2: global "quixote", add "local " prefix
3: global "LSM", add "local " prefix
77: global "InquestLDB", change to "Inquest.LDB" (or "self.LDB" since it's in a scope where "self" == "Inquest")

Options.lua
1: insert
Code:
local Inquest = LibStub("AceAddon-3.0"):GetAddon("Inquest")
QuestLog.lua
1: insert
Code:
local Inquest = LibStub("AceAddon-3.0"):GetAddon("Inquest")
local quixote = LibStub("LibQuixote-2.0")
local LSM = LibStub("LibSharedMedia-3.0")
Tooltip.lua
1: insert
Code:
local Inquest = LibStub("AceAddon-3.0"):GetAddon("Inquest")
local quixote = LibStub("LibQuixote-2.0")
QuestLog.lua
1: insert
Code:
local Inquest = LibStub("AceAddon-3.0"):GetAddon("Inquest")
local quixote = LibStub("LibQuixote-2.0")
local LSM = LibStub("LibSharedMedia-3.0")

RSS 2.0 Feed for Bug CommentsNotes Sort Options
By: Phanx - 06-06-09 02:07 AM
Also in Core.lua:
126, 127: change "InquestLDB" to "Inquest.LDB" (or "self.LDB")