Go to Page... |
Updated: | 06-12-10 02:46 PM |
Created: | 12-03-08 04:31 PM |
Downloads: | 20,117 |
Favorites: | 230 |
MD5: | |
Categories: | TradeSkill Mods, ToolTip |
GatherSage2 is a re-write of the original GatherSage. Almost all of the original GatherSage functionality made its way into GatherSage2 and a lot more was added.
GatherSage2 shows what level is required to mine, pick, smelt, prospect, mill, or skin a resource (vein, deposit, ore, animal, plant, etc). The tooltip will show all skills for which the resource can be gathered or used up (i.e. an herb that can be both picked and milled).
It also shows you your current skill, how many skill ups you have gained since you logged in, and the difference between the skill you need to work with the resource and the skill you currently have.
It displays this information in the tooltip when you mouse over a resource in the world, minimap, inventory, auction house, mailbox, guild bank, and pretty much anywhere the item can be displayed. It will also show you if that resource has a chance of yielding special items (such as stone, gems, or other herbs).
A lot of testing has gone into making sure GatherSage2 does not interfere with other addons you may have loaded. Please report any problems found.
There is a readme.txt file that contains detailed information on GatherSage2
![]() |
Comment Options |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
|
|
I am getting the following error with version 2009-03-08
Code:
GatherSage2-2009-03-08\GS2_Main.lua:457: attempt to compare string with number GatherSage2-2009-03-08\GS2_Main.lua:634: in function `ProcessTooltip' GatherSage2-2009-03-08\GS2_Main.lua:265: in function <Interface\AddOns\GatherSage2\GS2_Main.lua:251> Examples: Mosshoof Runner Ironfur Bear etc. After it breaks on one of those, more and more tooltips start showing the problem, but I *think* it always starts with such mobs.
Last edited by Dridzt : 04-07-09 at 05:04 PM.
|
![]() |
![]() |
Dridzt |
View Public Profile |
Send a private message to Dridzt |
Find More Posts by Dridzt |
Add Dridzt to Your Buddy List |
![]() |
||
|
Same happens if you keep the mouse over the mob when it dies... when the tooltip changes to show the target is skinnable, GS2 does not pick this up since it operates via catching the OnShow() event. Again, if you mouse out then back in, the tooltip shows up appropriately. I think the game itself updates the tooltip in the background dynamically without ever kicking off OnShow()... I suspect it might kick off OnUpdate(), but every time I try to hook this, it ends up very badly, especially if I change the tooltip in the OnUpdate(). This method fires so often, it can really corrupt the tooltip if special attention is not made and there is no way to know what other mods are firing via OnUpdate and in what order. I can't see anything hooking OnUpdate() that would cause this issue since my fix simply re-positions the right FontStrings before GameTooltip:Show() is called and that is right before the tooltip is shown... GameTooltip:Show() is simply a way to tell the engine to re-layout the tooltip before showing it (resizing, etc). I can only attribute this to some change in how the game handles the tooltip. Since this seems to be fixed, I am posting the new version...
Last edited by kellewic : 03-09-09 at 12:22 AM.
|
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
|
A Kobold Labourer
Forum posts: 1
File comments: 17
Uploads: 0
|
I think you've nailed it. Made both changes (though I've never seen that "arithmetic on string" error either) and after an hour+ of hard leveling with frequent mouse scrubbing (which always caused an error pretty quickly before), I've not seen a single tooltip glitch, from GS2, DrDamage, Recount, or the standard skills.
As for the way the /run command moved the tooltip to the right position, and then it moved back... doesn't OnShow() tick once a second or maybe faster? To support dynamic content like timers, etc.? Sounds like the addon displayed the tooltip with the glitch, the /run updated it to be without the glitch, and then the addon ticked and redisplayed it with the glitch again. It may well be that this started with 3.09. I know I never saw this when testing in January, so it started after your 1-30 release. I'd thought it might be tied to an Auctioneer update, but it does make sense that it's some kind of client LUA bug, since it's so random and inconsistent despite the fixed and static addon code.
Last edited by RHuebner : 03-09-09 at 12:55 AM.
|
![]() |
![]() |
RHuebner |
View Public Profile |
Send a private message to RHuebner |
Find More Posts by RHuebner |
Add RHuebner to Your Buddy List |
![]() |
||
|
|
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
|||
|
Thank you so very much! ![]() |
||
![]() |
![]() |
smedeley |
View Public Profile |
Send a private message to smedeley |
Find More Posts by smedeley |
Add smedeley to Your Buddy List |
![]() |
|
|
Tooltip bug
OK, more information... as far as I can tell, this is not related to any other mod. I have unloaded everything except GS2 and I can still reproduce the bug by quickly mousing over all my bag items, however, this does not mess up all the tooltips. Most of the time, it will simply mess up 1 or 2 of them and the rest are fine. The really weird part is when I run the following when moused over a corrupted tooltip:
Code:
/run GatherSage2:Tooltip_FixRightFontStrings(GameTooltip) I can't explain it except that I do not remember this behaviour in 3.08. Does anyone recall this happening before the 3.09 patch was applied? It may very well be a GatherSage2 bug only, but I can't explain why the right FontStrings would reposition themselves to the wrong position after running the above code since GatherSage2 relies on the GameTooltip:OnShow() event and if I am hovering over an item, the OnShow event has already fired so something else is moving those right FontStrings. I suspect it's the game itself since I have no other mods loaded at this point, but I am not ruling out some tooltip behaviour change in the new patch that is causing GatherSage2 to do weird things. Another strange thing is if I only mouse over items that GatherSage2 knows about, I don't see the bug appear (I did this for 5 minutes just mousing back and fourth over 4 ores). The second I mouse over something it doesn't know about, then I instantly see the bug. This is with just GatherSage2 loaded. Can anyone confirm this for me? *** EDIT *** OK, I may have fixed this. If you all can add the following line in GS2_Main.lua at line 832: Code:
self:Tooltip_FixRightFontStrings(tooltip) Code:
-- Wrap all lines that match these texts. WrapLongLines( tooltip, strconcat(L["USE"], ": "), [["Commonly found .*%."]], [["Commonly obtained .*%."]], [["Rarely found .*%."]], [["Rarely obtained .*%."]] ) self:Tooltip_HideAllTextures(tooltip, true) self:Tooltip_FixRightFontStrings(tooltip) tooltip:Show() *** ANOTHER EDIT *** I've searched and searched and cannot find any documented change to how GameTooltip works. I really don't know why this bug suddenly manifested itself. I'm not ruling out that it is my fault, but I sure can't find the cause yet.
Last edited by kellewic : 03-08-09 at 05:32 PM.
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
||
|
I guess the only thing I can do in that instance is advise you to change line 647 in GS2_Main.lua from: Code:
skillLevelRequired = itemRef["skill"][1] Code:
skillLevelRequired = tonumber(itemRef["skill"][1]) or 0 The error shows how many addons are grabbing on to GameTooltip events. It looks like it starts on a mouseover on a bag item and then goes through like 4 mods before it even hits the tooltip mod to show the tooltip (why the hell is MobInfo2 even in there for a bag item?) and then GS2 kicks off to modify the tooltip and errors out. I've been running this version for many weeks and have never seen an actual error like this, but you are running several mods I do not run so who knows what is going on in the background. |
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
||
|
Re: Re: Auctioneer tooltip issue
You can try opening up Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua and commenting out line 1058 that should read: Code:
fixRight(p) I've only been seeing this weirdness in the last few weeks. I don't recall this being the case before then.
Last edited by kellewic : 03-08-09 at 11:15 AM.
|
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
||
|
Using your latest version, I'm still getting errors when mousing over various items.
Love this addon, but the errors are getting out of hand, heh. On average, during a couple hours of play, I'll get between 5-15 of these errors. |
|
![]() |
![]() |
smedeley |
View Public Profile |
Send a private message to smedeley |
Find More Posts by smedeley |
Add smedeley to Your Buddy List |
![]() |
|
A Kobold Labourer
Forum posts: 1
File comments: 17
Uploads: 0
|
Re: Auctioneer tooltip issue
I'm sorry to say that it's still happening to me with this version. Ironically, GS2's own tooltip change (the skill required line) is the most commonly hit, followed by the top 3 lines of DrDamage's DPS analysis and Recount's total damage/DPS summary tooltip. Since I enabled Auctioneer's new "only show with Alt key" option, it doesn't seem to be happening as much to the normal class skill buttons, but that may just be luck considering how weirdly random this glitch's effects are.
What was the hack workaround you deleted? I'd like to give it a try if it might give any further clue on what works and what doesn't. |
![]() |
![]() |
RHuebner |
View Public Profile |
Send a private message to RHuebner |
Find More Posts by RHuebner |
Add RHuebner to Your Buddy List |
![]() |
|
|
Auctioneer tooltip issue
I think I resolved this issue and a new version (2009-03-07) is pending approval from the powers that be...
Basically, I just took the fixRight() function from Auctioneer's tooltip library and incorporated it into my tooltip library. I then call this function for every processTooltip() call regardless of whether GatherSage2 will actually process the tooltip. I did this since a lot of spell and item tooltips were being corrupted somehow. Calling this function corrects the issue as far as I can tell. I still don't know the exact cause since it seemed to happen at random times and I suspect it's something internal that the game is doing since you would think the same Lua code being called the same way would produce the same results. There are some other changes in this version that I never released:
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
|
|
Re: Re: Re: Tooltip text joining bug?
*** REMOVED THIS POST AS I THINK I RESOLVED THE ISSUE AND DIDN'T WANT TO CONFUSE PEOPLE WITH OTHER "HACK" FIXES ***
Last edited by kellewic : 03-07-09 at 06:14 PM.
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
||
|
![]() |
|
![]() |
![]() |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
![]() |
|
An Aku'mai Servant
Forum posts: 34
File comments: 90
Uploads: 0
|
Just wondering if this one works like Gatherer...where it will show where nodes are and such?
Thanks |
![]() |
![]() |
Duchess |
View Public Profile |
Send a private message to Duchess |
Find More Posts by Duchess |
Add Duchess to Your Buddy List |
![]() |