(23Kb)

Updated: 06-04-09 03:54 AM

Patch for:
Fishbringer.

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	06-04-09 03:54 AM
Created:	05-12-09 03:34 PM
Downloads:	3,675
Favorites:	52
MD5:

Fishbringer

Version: 3.1.1

by: Bruners [More]

Updated Fishbringer with a new method for pole checking (all future poles) and new zones.
- Added support for LibSharedMedia-3.0
- Added support for localization, Spanish (esES), Korean (koKR) and French (frFR) ready for testing
- Added some colors to the font changing thingie [/b]
- As requested, frame position is now saved in the db instead of smashing it to the center
- Russian (ruRU)

To list available fonts type:

/fishbringer font

and to change font face type (testing the ABF font):

/fishbringer font ABF

Let me know if it doesn't work as expected i will try to fix it.

Translation of this AddOn is currently in the works, to contribute with your language visit http://wow.curseforge.com/projects/fishbringer/localization/

Thanks to:
LoloMac aka Traulen for the French (frFR) translation
chkid for the Korean (koKR) translation
StiviS for the Spanish (esES) translation
StingerSoft for the Russian (ruRU) translation

frFR update

------------------------------------------------------------------------
r19 | bruners | 2009-05-17 04:38:35 +0000 (Sun, 17 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Save frame position in the db when moving is done.
------------------------------------------------------------------------
r18 | bruners | 2009-05-17 04:12:48 +0000 (Sun, 17 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Clean up font changing and add some shiny colors to the list
------------------------------------------------------------------------
r16 | bruners | 2009-05-16 04:11:51 +0000 (Sat, 16 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Use GetSpellInfo to get the localized name for Fishing, thanks to Phanx for the tip.
------------------------------------------------------------------------
r14 | bruners | 2009-05-15 23:31:00 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/Fishbringer.toc

Add localization.lua to the toc
------------------------------------------------------------------------
r13 | bruners | 2009-05-15 22:19:16 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

frFR update, Add spell "Fishing" to the localization table
------------------------------------------------------------------------
r12 | bruners | 2009-05-15 20:39:32 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/.pkgmeta
M /trunk/Fishbringer.toc
M /trunk/embeds.xml
M /trunk/fishy.lua
A /trunk/localization.lua

Add support for localization with AceLocale-3.0
------------------------------------------------------------------------
r11 | bruners | 2009-05-15 16:53:55 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

make font local
------------------------------------------------------------------------
r9 | bruners | 2009-05-15 15:47:05 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/.pkgmeta

fix .pkgmeta externals
------------------------------------------------------------------------
r7 | bruners | 2009-05-15 15:34:01 +0000 (Fri, 15 May 2009) | 4 lines
Changed paths:
M /trunk/.pkgmeta
M /trunk/Fishbringer.toc
A /trunk/embeds.xml
M /trunk/fishy.lua

- Rewritten management of the DB so that we can expand it later without to much clutter.
- Add support for LibSharedMedia-3.0 and slash commands to change font.
- Help text on /fbr help
- Redone displayed text to avoid some word wrapping
------------------------------------------------------------------------
r5 | bruners | 2009-05-12 12:55:08 +0000 (Tue, 12 May 2009) | 2 lines
Changed paths:
M /trunk/fishy.lua

Correctly remove % of % fish caught when at max rank
Fix FishFormula()
------------------------------------------------------------------------
r3 | bruners | 2009-05-12 12:09:02 +0000 (Tue, 12 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Fix UpdateSkill() bug
------------------------------------------------------------------------
r2 | bruners | 2009-05-12 12:01:40 +0000 (Tue, 12 May 2009) | 1 line
Changed paths:
A /trunk/.pkgmeta
A /trunk/Fishbringer.toc
A /trunk/fishy.lua

Update toc, new method for pole checking, new zones.
------------------------------------------------------------------------
r1 | root | 2008-12-13 22:19:58 +0000 (Sat, 13 Dec 2008) | 1 line
Changed paths:
A /branches
A /tags
A /trunk

"fishbringer/mainline: Initial Import"
------------------------------------------------------------------------

Comment Options

Page 2 of 3

05-20-09, 08:21 AM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Re: too Lazy

Originally posted by EnSabahNur
hi I am too lazy to translate all German Zones so for me I hacked in Bable
zone

Ok, i will let you know that not all zones are in LibBabble-Zone-3.0, about 8 (that i know of) are missing.

Last edited by Bruners : 05-20-09 at 08:23 AM.

05-20-09, 02:45 AM
EnSabahNur A Defias Bandit Forum posts: 3 File comments: 55 Uploads: 6	too Lazy hi I am too lazy to translate all German Zones so for me I hacked in Bable zone

05-19-09, 07:10 PM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Originally posted by Phanx
Maybe so, but when considering whether to use a library, I ask myself two questions:

1. Will it make things easier for me? In this case, yes, it would make things easier for you, as you wouldn't need to wait around for people to submit translations for 88 zone names for every locale before your addon would work in those locales.

2. Will it negatively impact performance for users? In this case, the answer is no. As previously mentioned, the additional static memory usage has no impact during gameplay, and only a negligible impact during the initial loading process. Furthermore, for any users who are already loading the library with other addons, loading your 88 translations is redundant and has the opposite impact of what you're arguing not using the library will have. Currently there are at least 54 addons using the library, and an additional, unknown, number of addons that aren't hosted on a WoWAce/CurseForge repository using it. Addons that do use it include BigWigs, Cartographer, AutoBar, AtlasLoot, and PitBull. How many people using your addon do you think don't have one of the addons on that list? I'd guess a very small percentage.

Anyway, it's your addon, so do what you want.

Its actually not my AddOn, I'm just maintaining it for Amnith.

I wouldn't say it makes it easier for me, all i have to do is to tag the repository once more when someone has updated the translations.
The import of the strings was done in less than one minute

I don't use any of those AddOns or anyone that uses LibBabbleZone.

I do get your point, but i don't feel that its necessary to use LibBabbleZone for this AddOn.

05-19-09, 06:12 PM

Phanx

Cat.

Forum posts: 5617

File comments: 2321

Uploads: 54

Originally posted by Bruners
Unnecessary data and a unnecessary lib is unnecessary

Maybe so, but when considering whether to use a library, I ask myself two questions:

1. Will it make things easier for me? In this case, yes, it would make things easier for you, as you wouldn't need to wait around for people to submit translations for 88 zone names for every locale before your addon would work in those locales.

2. Will it negatively impact performance for users? In this case, the answer is no. As previously mentioned, the additional static memory usage has no impact during gameplay, and only a negligible impact during the initial loading process. Furthermore, for any users who are already loading the library with other addons, loading your 88 translations is redundant and has the opposite impact of what you're arguing not using the library will have. Currently there are at least 54 addons using the library, and an additional, unknown, number of addons that aren't hosted on a WoWAce/CurseForge repository using it. Addons that do use it include BigWigs, Cartographer, AutoBar, AtlasLoot, and PitBull. How many people using your addon do you think don't have one of the addons on that list? I'd guess a very small percentage.

Anyway, it's your addon, so do what you want.

05-19-09, 01:14 PM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Originally posted by Phanx
The static memory usage of a static list of translations has zero impact on performance, outside of adding a few tenths of a second to your first loading screen, unless you're playing WoW on a 386.

Unnecessary data and a unnecessary lib is unnecessary

05-17-09, 10:05 PM

Phanx

Cat.

Forum posts: 5617

File comments: 2321

Uploads: 54

Originally posted by Bruners
LibBabbleZone-3.0 vs my data is 232 lines vs 88, and thats just the English locale.

The static memory usage of a static list of translations has zero impact on performance, outside of adding a few tenths of a second to your first loading screen, unless you're playing WoW on a 386.

05-16-09, 04:36 PM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Originally posted by ffxiedyn
can the fishbringer window be moved?

it pops middle of my screen when i fish, i would like it out of middle if possible?

i do not know lua, if that is how i can edit placement, please tell me line to edit?

thanks for addon!

Hold down alt and move the frame to where you want it

05-16-09, 04:19 PM
ffxiedyn A Chromatic Dragonspawn Forum posts: 165 File comments: 87 Uploads: 1	can the fishbringer window be moved? it pops middle of my screen when i fish, i would like it out of middle if possible? i do not know lua, if that is how i can edit placement, please tell me line to edit? thanks for addon!

05-15-09, 09:38 PM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Originally posted by Phanx
Rather than try to build and maintain your own database of zone name translations, why not just use the LibBabble-Zone-3.0 library?

I also see a few comments down that you're looking for translations for "Fishing". Why not just use GetSpellInfo(7620) to automatically get the localized name in any client?

LibBabbleZone-3.0 vs my data is 232 lines vs 88, and thats just the English locale.

GetSpellInfo is something i will look into.

05-15-09, 09:11 PM
Phanx Cat. Forum posts: 5617 File comments: 2321 Uploads: 54	Rather than try to build and maintain your own database of zone name translations, why not just use the LibBabble-Zone-3.0 library? I also see a few comments down that you're looking for translations for "Fishing". Why not just use GetSpellInfo(7620) to automatically get the localized name in any client? Last edited by Phanx : 05-15-09 at 09:14 PM.

05-15-09, 06:10 PM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Originally posted by Traulen
The french translation for Fishing is Pêche
Only missing one translation...

Its up on Curse and Curseforge now, just waiting for the slackers here at WoWInterface to confirm the file

05-15-09, 05:16 PM

Traulen

A Kobold Labourer

Forum posts: 0

File comments: 7

Uploads: 0

Originally posted by Bruners
Need one important one to make it work

http://wow.curseforge.com/projects/f...es/99-fishing/

The french translation for Fishing is Pêche
Only missing one translation...

Last edited by Traulen : 05-15-09 at 05:21 PM.

05-15-09, 04:15 PM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Originally posted by Bruners
Nice work! its 4 by the way. Will do some more testing and push a new beta with the translation

http://wow.curseforge.com/projects/f.../?untranslated

Need one important one to make it work

http://wow.curseforge.com/projects/f...es/99-fishing/

05-15-09, 03:50 PM

Bruners

A Flamescale Wyrmkin

Forum posts: 125

File comments: 69

Uploads: 11

Originally posted by Traulen
I've finished translating in french (except for two I can't find, if I remember well) under the name LoloMac...

Nice work!

its 4 by the way. Will do some more testing and push a new beta with the translation

http://wow.curseforge.com/projects/f.../?untranslated

05-15-09, 03:26 PM
Traulen A Kobold Labourer Forum posts: 0 File comments: 7 Uploads: 0	I've finished translating in french (except for two I can't find, if I remember well) under the name LoloMac...

Page 2 of 3

Report this File

Category Jump: