BuffEnough 

Re: AceLibrary
It's part of the Ace2 framework, and you don't need it at all. Dump the outdated Gratuity-2.0 library that requires it, and use the new LibGratuity-3.0 library that's based on LibStub and does not require any framework.

Re: LibLogger-1.0
Why does it need to be a requirement for the end-user to run this debugging library? You can easily make it optional (i.e. only used if already present on the user's system, and not included in the download) by doing something like this:

Elsewhere in the code you already check for the existence of the functions provided by the library before trying to execute them, so this is not an issue.

Re: Standalone Libraries
Nearly all libraries exist as standalone addons; exceptions include LibStub, CallbackHandler-1.0, and Astrolabe. For every library your addon needs to run, if that library is available as an addon, the addon's name must be listed in your addon's .toc file in the Optional Dependencies field. For the most part you're already doing this, but one glaring error exists: AceLibrary. There is no addon called "AceLibrary", yet you have this listed in OptDeps. AceLibrary comes bundled with all the other libraries that are part of the Ace2 framework in an addon named "Ace2"; if you indeed needed to include AceLibrary in your addon (although you don't) you would need to put Ace2 in OptDeps, not AceLibrary.

Latest Wowace r75153 (later than v4 here) of BuffEnough still fails to load. All standalone libs except LibLogger-1.0 & LibTalentQuery-1.0 (which are embedded). Same error message on load as previously reported twice. Its not a "mod conflict"; besides the libraries the only other thing running on the test character is BugGrabber/BugSack (so I can record the errors).

You shouldn't need to use Acelibrary (from Ace2) when the mod uses Ace3; LibStub should do all you use AceLibrary for.

Fiddled a bit with the TOC, changed OptDeps, changed embeds.xml around to point to LibStub (which is downloaded into \Libs from the SVN, despite no references to it) and so on. Same error at logon every time, same no loading.

Finally I downloaded off the SVN (using a SVN client) the mod with all its embedded libraries. Among the obvious Ace3 ones & the two I previously had embedded, the download includes AceLibrary, Gratuity-2.0 & LibStub. Sure enough, log on with everything embedded and it comes up without an error; can finally access the mod.

Sure hope you can fix this problem with it bugging out using standalone libraries. No other mod I currently use or can remember has had such a problem. Devs, testers & other "advanced" users often run libs standalone.

Some things are automatic - if you're a druid, you should have Mark of the Wild, for example - and the README file (and the documentation on this website) has the comprehensive list of what BuffEnough checks for. Other things are configurable - you may not want to check for consumables in a 5-man, but may want to in a 25-man, for example - and you can find those options in the config menu.

When you mouse over the frame, it should show you in the tooltip what it thinks you're missing. Right clicking will report buffs that others should cast on you, but won't report things that you cast on yourself - for example, if you're a warlock, it won't report to the raid that you need Fel Armor.

Is there a specific example of a buff that you have that it's not detecting? Or a buff that you don't have that it should detect?

Ok, so I figured that I would install this addon and I would be able to check to see if I had the "best" buffs (or I could select every buff that I wanted to check for from a list based on specific enchants, flasks, potions, etc...) but I can't.

is there any way to be able to add a tab that allows someone to check off the specific buffs that they want for their character? Right now, I get the red screen, and when i left click, it doesn't report to me which buffs I am missing and if I right click, it says all buffs accounted for though at the time I am not buffed.

That should be fixed in the newest update, Balsta.

Also, this addon is now available in the wowace SVN for those of you that would prefer to download it that way, or download it without the externals.

got these error when I logged my little rogue in.

[2008/05/24 22:37:27-349-x1]: BuffEnough\Classes\Rogue.lua:33: attempt to index global 'L' (a nil value)
BuffEnough\BuffEnough.lua:195: in function `RunCheck'
BuffEnough\BuffEnough.lua:130: in function `DoEnable'
BuffEnough\BuffEnough.lua:93: in function <Interface\AddOns\BuffEnough\BuffEnough.lua:91>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceAddon-3.0\AceAddon-3.0.lua:341: in function `EnableAddon'
AceAddon-3.0\AceAddon-3.0.lua:411: in function <...s\AckisRecipeList\libs\AceAddon-3.0\AceAddon-3.0.lua:397>
<in C code>: in function `LoadAddOn'
Interface\FrameXML\UIParent.lua:908: in function `UIParentLoadAddOn':
Interface\FrameXML\UIParent.lua:234: in function `CombatLog_LoadUI':
Interface\FrameXML\UIParent.lua:327: in function `UIParent_OnEvent':
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

---


[2008/05/24 22:37:31-349-x1]: BuffEnough\Classes\Rogue.lua:33: attempt to index global 'L' (a nil value)
BuffEnough\BuffEnough.lua:195: in function <Interface\AddOns\BuffEnough\BuffEnough.lua:182>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceBucket-3.0\AceBucket-3.0.lua:87: in function <...dOns\BuffEnough\Libs\AceBucket-3.0\AceBucket-3.0.lua:80>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceTimer-3.0\AceTimer-3.0.lua:142: in function <...rface\AddOns\Omen\Libs\AceTimer-3.0\AceTimer-3.0.lua:114>

---

Do let me know if issues persist.

Thanks for the hint, Phanx. I'm a relative Ace3 newbie (this addon actually began as just me experimenting with the Ace3 framework and messing around) so I wasn't sure what might be going wrong.

Zidomo, I'll see if I can get that issue cleared up with my next update, which will be in a day or two. I've added some additional stuff and cleaned up some code so I want to run it through a raid and make sure everything's working before I upload.

The problem with standalone libraries is that you did not add all of the libraries your addon requires to the OptionalDeps field in the toc, so the libraries are (generally) not loaded before the addon tries to load.

Still not loading properly. Log on with v3 and still getting this error at logon, as before:

BuffEnough-1.0\Config.lua:434: attempt to index field 'db' (a nil value)
BuffEnough-1.0\BuffEnough.lua:101: in function `DoEnable'
BuffEnough-1.0\BuffEnough.lua:91: in function <Interface\AddOns\BuffEnough\BuffEnough.lua:89>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceAddon-3.0\AceAddon-3.0.lua:341: in function `EnableAddon'
AceAddon-3.0\AceAddon-3.0.lua:411: in function <Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:397>
<in C code>: in function `LoadAddOn'
Interface\FrameXML\UIParent.lua:908: in function `UIParentLoadAddOn':
Interface\FrameXML\UIParent.lua:234: in function `CombatLog_LoadUI':
Interface\FrameXML\UIParent.lua:327: in function `UIParent_OnEvent':
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

After that error occurs, cannot bring up the mod's options with "/be" or "/buffenough", meaning it hasn't loaded. The error with LibSharedMedia is gone.

I put Thorns on my to do list to "figure out". Also updated with a few more features and some bug fixes. Thanks to everyone who's been providing feedback, much appreciated!

In that case (and you're right, thorns is a sticky one, pardon the pun), would you consider Thorns as a required buff for 'tanks' if the group has a druid present?

And thanks for the fast response to my other post.

Thanks for the detailed report, Zidomo. Not sure what the deal is there, but if the problem is limited to LibSharedMedia, I may just pull it for the time being. I had thrown it in there thinking I would have some sort of customization features, but there isn't exactly a lot to customize, aesthetically speaking.

Applied for an SVN account a week or so back. Apparently it takes some time. I'll definitely get in there when I'm allowed.

Wasn't quite sure what to do with thorns. Some people put it up on everyone, some people only put it up on the tanks, some people don't really use it at all. In cases where I wasn't sure what the 'obvious' behavior should be, I left it out, rather than imposing what I thought the behavior should be, or creating something overly complex. What I may end up doing in a future version is adding the ability to add custom buffs to monitor in cases where something doesn't work "out of the box".

Druid Thorns appears to be missing. I am not a hard core raider, not sure if this was left out on purpose.

Any chance to see this on the wowace svn for downloading without libraries?

I haven't tried the addon in a raid yet, but it sounds really promising.