Omen

[OldHarry]

Omen is constantly giving me constant error messages - even right after I update all add ons with curse client. So I am winding up pulling aggro off the tank at times and have wiped the raid a few times because I cant see when I am pulling too much aggro. I quit running gatherer because someone suggested it might not be working with omen and still wind up having to turn off omen ever single time I go into Naxx, VOA or Ulduar.

[ravagernl]

Please don't double post a thread with the same question

[Vis]

What's the constant error you are getting? Any visual indicators? Are you just going all out to early? Are threat bars not showing? Version numbers? Screenshot if it will help clarify exactly what is happening?

[Trond]

Try Tidy Threat?

[OldHarry]

Something about get shapeshift form info. And while I am on a dk.

[Xrystal]

Does the error message give you any other information such as a lua file name and a line number. It will help us track down the exact message you are getting.

If you keep getting the messages can you please take a screen shot and post it up so we can see exactly what you mean.

Rofl, must have been sleepy .. thought it was a nUI query Removed nUI related questions.

[incith]

Originally Posted by Trond Try Tidy Threat?

Been using this lately. It rocks.

[dystrophy]

I also receive this error message he is talking about even though my Omen is up to date also. The exact error message is this....

interface\addons\omen\omen.lua:1649: Usage: Getshapeshiftform Info(index)

Problem is I can't get rid of this error until the current fight ends, hitting OK just throws up the error again right away.

[Xrystal]

Originally Posted by dystrophy I also receive this error message he is talking about even though my Omen is up to date also. The exact error message is this.... interface\addons\omen\omen.lua:1649: Usage: Getshapeshiftform Info(index) Problem is I can't get rid of this error until the current fight ends, hitting OK just throws up the error again right away.

Thanks that helps somewhat. Hopefully the omen developers have been keeping track of this thread themselves but here is the block of code in question.

if lastWarn.mobGUID == mobGUID and myThreatPercent >= t.Threshold and t.Threshold > lastWarn.threatpercent then
	if not t.DisableWhileTanking or not (myClass == "WARRIOR" and GetBonusBarOffset() == 2 or
	  myClass == "DRUID" and GetBonusBarOffset() == 3 or
	  myClass == "PALADIN" and UnitAura("player", GetSpellInfo(25780)) or
	  myClass == "DEATHKNIGHT" and GetShapeshiftFormInfo(GetShapeshiftForm()) == "Interface\\Icons\\Spell_Deathknight_FrostPresence") then
		self:Warn(t.Sound, t.Flash, t.Shake, *****ssage and L["Passed %s%% of %s's threat!"]:format(t.Threshold, guidNameLookup[lastWarn.tankGUID]))
	end
end

Okay, looking at wowwiki the only thing that seems to be wrong here is the deathknight test section.

GetShapeshiftFormInfo needs to have its parameter set to nil or false to work with DEATHKNIGHT information as per this page:

http://www.wowwiki.com/API_GetShapeshiftForm

For those ambitious people out there or the developers themselves you might want to change that last part to:

or myClass == "DEATHKNIGHT" and GetShapeshiftFormInfo(nil) then

OR

or myClass == "DEATHKNIGHT" and GetShapeshiftFormInfo(false) then

and see if it solves the problem for you. I'd try it myself but I don't have a deathknight to test it with.

This is I think because the Aura and Presence information for DeathKnights and Paladins aren't classed as true Stances unlike the other classes stance bars

Edit: Actually, the code change is wrong after re-reading it.

Change it to :

or myClass == "DEATHKNIGHT" and (GetShapeshiftForm(false) == 2) then

or

or myClass == "DEATHKNIGHT" and (GetShapeshiftForm(nil) == 2) then

It in essence does the same thing without hardcoding the filename used for said presence. If you read the wowwiki page you can see why I changed it.