Reminders before 4.2 goes live

[Ketho]

Originally Posted by qod COMBAT_LOG_EVENT_UNFILTERED is not the only change that will affect addons when 4.2 goes live. I author an addon that used string.replace to remove unneeded spaces from a string, only to find that Blizzard decided to remove string.replace for some strange reason.

offtopic, but why didn't you just use strtrim / string.trim if you just wanted to remove "unneeded spaces"?

[Nibelheim]

Originally Posted by Ketho offtopic, but why didn't you just use strtrim / string.trim if you just wanted to remove "unneeded spaces"?

Trim only removes trailing and leading spaces. Replace was useful for converting "Buff Bar 1" to "BuffBar1".

[Vlad]

Simply converting all string.replace/strreplace/:replace into "gsub" won't do as you got to escape certain characters. Yet it appears that Blizzard just did a mass "find and replace" on the few lines I read but maybe not, in any case addon authors gotta watch this and get familiar with how gsub and patterns work with lua for 4.2 I figure.

Strange isn't it, removing string.replace? I wonder why...

[arith]

So is it confirmed the 4.2 will be on live server on June 28th?

[Verttex]

Originally Posted by arith So is it confirmed the 4.2 will be on live server on June 28th?

It has not been confirmed by Blizzard but we expect it to arrive then.

[qod]

Originally Posted by Ketho offtopic, but why didn't you just use strtrim / string.trim if you just wanted to remove "unneeded spaces"?

Originally Posted by Nibelheim Trim only removes trailing and leading spaces. Replace was useful for converting "Buff Bar 1" to "BuffBar1".

It was to only remove spaces in certain situations. Just the spaces before and after a dash, as in "Playername - Server Name" to "Playername-Server Name" because "Playername-ServerName" wouldn't work for me. I was using strreplace(stringname, " - ", "-") and now use string.gsub(stringname, "%s%-%s", "-") and get the same results.

I never came across the bug because my strings were never very long, as they were just a list of tanks that are currently in my party.

[Xrystal]

Hmm, darn windows search isn't finding a single COMBAT_LOG_EVENT_UNFILTERED in the addons folder. That simply cannot be right. I knew there was a reason I stopped using that search system.

Edit:
Ah, programmers notepad to the rescue, haha. But thankfully the only ones of my own addons that use it are about 4 years old and I'm sure they're no longer used by now unless they have miraculously been working all these years with no problems.

[Seerah]

There's a specific thing you need to do to make it search in Lua and XML files. Unfortunately, I forgot it as soon as I did it.

[Vlad]

Notepad++ is free and has a "find in files" feature, I don't think windows search is really designed to look into files for strings, never used it for that myself in any case. :P

Btw very unhappy that major interface changes aren't officially announced in a compilation on the official forums, even the MVP aren't really doing it and I reckon if you are a Interface/addons MVP you'd have to focus and try report API changes and such between major patches. I don't know, maybe I demand too much.

[Tekkub]

You could just get on the PTR yourself and see if your addons broked. It's not that hard to do.