Would using oUF to just replace a player's nameplate be overkill?

[Eungavi]

Originally Posted by runamonk Enhancement Request added to GitHub oUF repo.

Oh, Thanks mate!

I've recently lost my Github password and am being lazy to find it

Originally Posted by Cogwerkz As a workaround, you could always prehook oUF.DisableBlizzard, and only call it for the units you wish disabled. Then you don't have to directly change anything in the oUF code. Been doing this in some of mine for a while. Just add something like the following before your spawn code is run: local parent, ns = ... local oUF = ns.oUF local disableBlizzard = oUF.DisableBlizzard   -- table of units you wish to disable, -- all others blizzard frames will remain local framesToDisable = {    player = true,    target = true }   function oUF:DisableBlizzard(unit)    if unit and framesToDisable[unit] then       return disableBlizzard(self, unit)    end end

That's actually a great idea.

The question is...

Let's say you have two addons which embeds their own copy of oUF.

One will replace all the unitframes (A) while the other will just draw an extra player unitframe on the center of the screen (B).

Do you reckon overriding a DisableBlizzard function in B would also affect one in A?

oUF doesn't use a LibStub, so I'm guessing that it won't affect each other tho...
(I can't test it myself atm )

[p3lim]

Originally Posted by Eungavi Let's say you have two addons which embeds their own copy of oUF. One will replace all the unitframes (A) while the other will just draw an extra player unitframe on the center of the screen (B). Do you reckon overriding a DisableBlizzard function in B would also affect one in A? oUF doesn't use a LibStub, so I'm guessing that it won't affect each other tho... (I can't test it myself atm )

Embedded oUF instances are their own addons, with their own space. Overwriting oUF internal functions will only affect each one, not both/all.
The only way it'd affect everything is if multiple layouts use the same unembedded oUF instance (which is why you should never override colors globally).

Another way to get what you want without modifying oUF source:

-- store and disable the method
local orig = oUF.DisableBlizzard
oUF.DisableBlizzard = nop
 
-- spawn your frames
oUF:Spawn('player')
 
-- re-enable the method
oUF.DisableBlizzard = orig

[Eungavi]

Originally Posted by p3lim Embedded oUF instances are their own addons, with their own space. Overwriting oUF internal functions will only affect each one, not both/all. The only way it'd affect everything is if multiple layouts use the same unembedded oUF instance (which is why you should never override colors globally).

That makes sense

Originally Posted by p3lim Another way to get what you want without modifying oUF source: -- store and disable the method local orig = oUF.DisableBlizzard oUF.DisableBlizzard = nop   -- spawn your frames oUF:Spawn('player')   -- re-enable the method oUF.DisableBlizzard = orig

Damn... why did I not come up with this

Thanks for the tip!