Can't figure out why this is suddenly not working....

[Sythalin]

InIg = InIg or CreateFrame("Frame")
InIg:RegisterEvent("VARIABLES_LOADED")
InIg:SetScript("OnEvent", function(self, event, ...) if InIg[event] then return InIg[event](self, event, ...) end end)
 
function InIg:VARIABLES_LOADED(event)   
    self.ignore = self.ignore or {}
    print("self.ignore created")
end
 
-- CHECK IGNORE STATUS
function InIg:ignoreCheck(_,_,sender)
    for i = 1, #(InIg.ignore) do
        if InIg.ignore[i] == sender then
            print(sender.. " is ignored.")
            return true -- sender is on ignore list
        end
    end
    return false -- sender is not on ignore list
end
 
-- HOOK CHATS
local events = {
    "CHAT_MSG_CHANNEL",
    "CHAT_MSG_WHISPER",
    "CHAT_MSG_EMOTE",
    "CHAT_MSG_BATTLEGROUND",
    "CHAT_MSG_BATTLEGROUND_LEADER", 
    "CHAT_MSG_GUILD",
    "CHAT_MSG_PARTY",
    "CHAT_MSG_RAID",
    "CHAT_MSG_RAID_LEADER",
    "CHAT_MSG_SAY",
    "CHAT_MSG_RAID_WARNING",
    "CHAT_MSG_YELL", 
    "CHAT_MSG_OFFICER"}
    
for _,k in ipairs(events) do
    ChatFrame_AddMessageEventFilter(k, InIg.ignoreCheck)
end

Getting the following error:

Message: Interface\AddOns\InIg\InIg.lua:67: attempt to get length of field 'ignore' (a nil value)
Time: 01/17/10 13:56:26
Count: 30
Stack: Interface\AddOns\InIg\InIg.lua:67: in function `filterFunc'
Interface\FrameXML\ChatFrame.lua:2511: in function `ChatFrame_MessageEventHandler'
Interface\FrameXML\ChatFrame.lua:2318: in function `ChatFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>

Error is at line 12 in my paste above.

I added the print("self.ignore created") and finding that loading seems to be skipping VARIABLES_LOADED because it never prints on login/reload. I've used this setup a dozen times now with no issues, haven't noticed any typos and the frame creation/event registration are the first things to happen in the file.

[Akryn]

Are you using the frame itself as a saved variable?

[Phanx]

First, disable any chat frame addons. Many chat frame addons increase the number of lines retained, which wipes all messages currently in the frame when that action is performed. It's possible your print is occurring but getting wiped.

Second, the error will occur anyway, because your filter function tries to loop through a table the doesn't exist until your VARIABLES_LOADED handler fires, but you're using it to filter messages before that happens.

[Sythalin]

No other mods enabled during testing. Golden rule there mate.

That's assuming that chat begins before addons are even loaded, which I'm pretty sure isn't the case. I could be wrong though.

[Sythalin]

Ah, I see. I missed this on the 3.0 API notes:

Until 3.0, VARIABLES_LOADED used to fire upon completion of the addon loading process; since 3.0, it is fired in response to CVars, Keybindings and other associated "Blizzard" variables being loaded, and may therefore be delayed until after PLAYER_ENTERING_WORLD. The event may still be useful to override positioning data stored in layout-cache.txt

So yes, you would be correct. I'll try moving it to ADDON_LOADED and see what happens.


EDIT: Nope, no dice. Even after hardcoding InIg = {} at the very beginning of the file, still coming up with the same error. And still no message given at "ADDON_LOADED".

EDIT: I set up a seperate saved var than just InIg, seems to be happy now. I've done it the other way before with no issues, but meh. Long as it works.

[Starinnia]

This prolly isn't going to do anything, but did you try it without the parens around the table when you used the # operator?

Edit: Bah, missed your last edit....

[Akryn]

Originally Posted by ChaosInc EDIT: I set up a seperate saved var than just InIg, seems to be happy now. I've done it the other way before with no issues, but meh. Long as it works.

It might work if you didn't have any functions defined inside the frame as well, or if you defined them inside of your ADDON_LOADED handler, and only used references to the frame rather than a global name (which would get overridden when the saved vars loaded).

[Sythalin]

Was working on APC today and started getting spammed with chat errors all of a sudden when it worked perfectly on it's last update. Cleared the WTF save files, downloaded my last working version and still getting spammed with errors.

Something has changed and now I'm kinda pissed because I have to go reconfigure half my projects because suddenly this is breaking EVERYTHING.




EDIT: Test further prove that events are being passed up (addon:EVENT() aren't firing), leading me to believe that there's something wrong with my "OnEvent" handler, but ****ed if I know what it is at this point, and I'm too pissed to concentrate on it atm.

[Sythalin]

Calmed down now. Sorry for before.

After doing testing to better understand the load up process, I see what you're saying Akryn and finally see where my issue is when trying to use the addon table as the saved variable. Serves me right to try and shortcut things I don't fully understand.

Looks like I'm going to have a bit of work ahead of me to fix this screwup, resulting in people having to delete their saved vars. >.<

[Xrystal]

Is there anyway you can convert them though ? I managed to do that for one of my addons. Granted it was to merge 2 tables into 1 table but I told it to run when the wrong table was in existence which means the chosen data is fine and now in a format it wants to work with.

[Sythalin]

Originally Posted by Xrystal Is there anyway you can convert them though ? I managed to do that for one of my addons. Granted it was to merge 2 tables into 1 table but I told it to run when the wrong table was in existence which means the chosen data is fine and now in a format it wants to work with.

Been working on that, no success so far. All conversion attempts have been left with ACP_Settings = nil for the new settings until reloading:

if APC then
     APC_Settings = CopyTable(APC["settings"])
     APC = nil
end
-- rest of addon code

if APC then
     APC_Settings = CopyTable(APC["settings"])
    APC = nil
    ReloadUI()
end
-- rest of addon code

EDIT: Correcting mod initials.

[Xrystal]

Hmm, probably because you're setting APC to nil which in essence is pointing to the same as the new table. Not sure though as I haven't used CopyTable but thought all variables were by reference.

[Sythalin]

Originally Posted by Xrystal Hmm, probably because you're setting APC to nil which in essence is pointing to the same as the new table. Not sure though as I haven't used CopyTable but thought all variables were by reference.

I used CopyTable on other addons where I've screwed up/changed the saved var format (same as you). Always worked fine. I know why it's not working, but I'm trying to decide if I really want to go through the hassle of creating a second frame to trigger ADDON_LOADED off of the make the fix (since it currently gets overridden, thus never fired) or just have users delete the saved vars. A second frame would require either a reload or a lot of duplicate code to reinstate APC correctly.

[Xrystal]

Ah, well probably best to get the users to wipe out the files then.

[Akryn]

You can probably just name the frame something else, and declare the name of the frame as an empty table at the top of your .lua. Then you can use that name as your settings table and not have to change the .toc.

[Phanx]

Only tables are passed by reference when assigning variables.

Anyway, the cleanest solution is definitely to use a separate name for your saved variables table as for your addon table. Realistically, your addon table doesn't need to be global at all.

If you really want to use the same name and have a global table, you could do something like this (drycoded):

local InIg = CreateFrame("Frame") -- local for now, so isn't immediately overwritten when saved variables load
InIg:SetScript("OnEvent", function(self, event, ...) return self[event] and self[event](self, ...) end)
InIg:RegisterEvent("ADDON_LOADED")

function InIg:ADDON_LOADED(addon)
	if addon ~= "InIg" then return end -- change this to match the addon's folder/TOC name!
	
	local db = _G.InIg -- this refers to the global table of your saved variables
	if not db then
		-- create the global table if it doesn't exist yet (first run)
		_G.InIg = {}
		db = _G.InIg
	end

	local function safecopytable(a, b)
		if not a then return {} end
		if not b then b = {} end
		for k,v in pairs(a) do
			if type(v) == "table" then
				b[k] = safecopytable(v, b[k])
			if type(b[k]) ~= type(v) then
				b[k] = v
			end
		end
		return b
	end
	
	safecopytable(db, self) -- values that already exist (eg. functions
							-- defined in the main chunk of this file)
							-- won't be overwritten

	_G.InIg = self -- and now copy back to global namespace
end

[Recluse]

Originally Posted by ChaosInc I used CopyTable on other addons where I've screwed up/changed the saved var format (same as you).

A function I wrote a few years ago to "fix" saved vars when i changed the table layout (and it -is- recursive). Maybe it'll help ya.

--[[
TableMigrate
Notes:  This function accepts two tables.  It ensures that the old table and the new table
    are identical in layout.
    1. Any keys which exist in both tables have their data preserved in the new table.
    2. Any keys which no longer exist in the new table are removed from the old table.
        A. Data which existed in those keys will be lost.
    3. Any keys which do not exist in the old table but do in the new table are added
        A. Newly added keys are given a default value set by the new table.
Reference:
    curT/newT = current and new table.
    curK/newK = current and new key.
    curV/newV = current and new value.
Example Usage:
    myTable = { a = "foo", b = "bar" }
    myDesiredTable = { a = "red", c = "green" }
    TableMigrate(myTable, myDesiredTable)
    result --> myTable = { a = "foo", c = "green" }
]]
local function TableMigrate(curT, newT)
    --[[First, we need to add keys to the current table which need to be added.
    If a new key is added, we assign the default value provided by the new table passed in.
    After checking, determine if we are looking at a table, and if so, recurse into it.]]
    for newK, newV in pairs(newT) do
        if curT[newK] == nil then
            curT[newK] = newT[newK]
        end
        if (type(newT[newK]) == "table") then
            TableMigrate(curT[newK], newT[newK])
        end
    end
    --[[Second, we need to remove keys and their values which do not exist in the new table.
    After checking, determine if we are looking at a table, and if so, recurse into it.]]
    for curK, curV in pairs(curT) do
        if newT[curK] == nil then
            curT[curK] = nil
        end
        if (type(curT[curK]) == "table") then
            TableMigrate(curT[curK], newT[curK])
        end
    end
end