Get raid target icon from destGUID

[daylesan]

I want to check if a unit (identified through the destGUID parameter) from a COMBAT_LOG_EVENT_UNFILTERED event has been marked with a raid marker.

Is there a better/simpler way of doing it than this?
1) upon receiving the combat log event, go through all unitID's and check if they are raid marked
2) if a raid marked unitID has been found, get its unitGUID
3) compare the destGUID from the combat log event with the unitGUID from step 2. If they match, destGUID is raid marked.

[Nobgul]

As there is no api call for IsRaidMarked, I don't think there is a easier way =(

[oomp]

Don't use destGUID, use destFlags...

local function GetIconIndex(flags)
    local number, mask, mark
    if bit.band(flags, COMBATLOG_OBJECT_SPECIAL_MASK) ~= 0 then
        for i=1,8 do
            mask = COMBATLOG_OBJECT_RAIDTARGET1 * (2 ^ (i - 1))
            mark = bit.band(flags, mask) == mask
            if mark then number = i break end
        end
    end
    return number
end

This will return a number from 1 to 8 corresponding to each mark, or nil if the target doesn't have a mark, see here for more information. However, if you are intent on using destGUID, I suppose you could do the following, assuming the unit you are checking is a player with a valid unitId:

local function GetRaidTargetIndexFromGUID(guid)
    local name = select(6, GetPlayerInfoByGUID(guid)) -- Get the unit's name; works globally
    local icon = GetRaidTargetIndex(name) -- Returns a number from 1 to 8, or nil
    return icon
end

[daylesan]

Originally Posted by oomp Don't use destGUID, use destFlags... local function GetIconIndex(flags)     local number, mask, mark     if bit.band(flag, COMBATLOG_OBJECT_SPECIAL_MASK) ~= 0 then         for i=1,8 do             mask = COMBATLOG_OBJECT_RAIDTARGET1 * (2 ^ (i - 1))             mark = bit.band(flags, mask) == mask             if mark then number = i break end         end     end     return number end This will return a number from 1 to 8 corresponding to each mark, or nil if the target doesn't have a mark, see here for more information. However, if you are intent on using destGUID, I suppose you could do the following, assuming the unit you are checking is a player with a valid unitId:

Thank you, that looks a lot cleaner than what I had in mind.

[daylesan]

There's a small error: bit.band(flag, COMBATLOG_OBJECT_SPECIAL_MASK) should be bit.band(flags, COMBATLOG_OBJECT_SPECIAL_MASK)

Even after fixing that, the function always returns nil though. Here's the code for review

function ezInterrupt:COMBAT_LOG_EVENT_UNFILTERED(_,_,event,sourceGUID,_,_,_,destName,destFlags,spellID,_,_,extraID, ...)
    if event == "SPELL_INTERRUPT" and (sourceGUID == UnitGUID("player") or sourceGUID == UnitGUID("pet")) then
        local raidIconIndex = self:GetRaidIconIndex(destFlags)
        print(tostring(raidIconIndex))
-- cut off the rest of the code

and

function ezInterrupt:GetRaidIconIndex(flags)
    local number, mask, mark
    if bit.band(flags, COMBATLOG_OBJECT_SPECIAL_MASK) ~= 0 then
        for i=1,8 do
            mask = COMBATLOG_OBJECT_RAIDTARGET1 * (2 ^ (i - 1))
            mark = bit.band(flags, mask) == mask
            if mark then number = i break end
        end
    end
    return number
end

[Vrul]

Combat log processing has the potential to be executed very frequently so I would suggest changing what you've posted to:

local bit_and = bit.band

local RaidIconMaskToIndex = {
	[COMBATLOG_OBJECT_RAIDTARGET1] = 1,
	[COMBATLOG_OBJECT_RAIDTARGET2] = 2,
	[COMBATLOG_OBJECT_RAIDTARGET3] = 3,
	[COMBATLOG_OBJECT_RAIDTARGET4] = 4,
	[COMBATLOG_OBJECT_RAIDTARGET5] = 5,
	[COMBATLOG_OBJECT_RAIDTARGET6] = 6,
	[COMBATLOG_OBJECT_RAIDTARGET7] = 7,
	[COMBATLOG_OBJECT_RAIDTARGET8] = 8
}

function ezInterrupt:COMBAT_LOG_EVENT_UNFILTERED(_, _, event, sourceGUID, _, sourceFlags, _, destName, destFlags, spellID, _, _, extraID, ...)
	if event == "SPELL_INTERRUPT" and bit_and(sourceFlags, COMBATLOG_OBJECT_AFFILIATION_MINE) then
		local raidIconIndex = RaidIconMaskToIndex[bit_and(destFlags, COMBATLOG_OBJECT_RAIDTARGET_MASK)]
		print(tostring(raidIconIndex))