beta - Page 6

Daveo77 · 08-10-12, 07:56 PM

With latest patch, Dungeon Finder icon isn't showing at all when queued for a random dungeon/raid or in a random dungeon/raid.

Also, if you do a reload of the UI whilst grouped, then nUI doesn't reload correctly (missing party/raid frames and 'Map/Combat Log' & 'Solo/Party/Raid' buttons).

Xrystal · 08-11-12, 04:15 AM

Originally Posted by Daveo77

With latest patch, Dungeon Finder icon isn't showing at all when queued for a random dungeon/raid or in a random dungeon/raid.

Also, if you do a reload of the UI whilst grouped, then nUI doesn't reload correctly (missing party/raid frames and 'Map/Combat Log' & 'Solo/Party/Raid' buttons).

Does it kick up any errors? Do you have error display on ?

didn't think of reloading the UI when I was grouped with someone last week .. d'oh

I don't like random queuing so not sure how I can test why the icon isn't showing, but then it could be because I have the icon showing in the icon bag instead as it is the same one as the one that used to be in the bag. will have to investigate that bit a bit more.

Xrystal · 08-11-12, 04:38 AM

oh and did it work on the last patch ? gives me an idea if it is to do with a change they did rather than something I may have missed

Daveo77 · 08-11-12, 03:54 PM

No errors shown, as had 'Display LUA errors' turned off, so I could concentrate on clearing the dungeon. Will look to see if it appears in Button Bag instead of the usual position it shows on Live.

No idea if it worked last patch or not, as first instance on Beta for me.

Daveo77 · 08-11-12, 03:58 PM

Clicking Button Bag, gives error 'Message: Interface\AddOns\nUI\Plugins\nUI_ButtonBag.lua:277: attempt to call global 'updateContainerFrameAnchors' (a nil value)'.

Simple fix to change the 'u' to a 'U' on both lines 277 & 278 in nUI_ButtonBag.lua.

Dungeon Finder icon is in Button Bag, along with Calendar icon.

Button Bag doesn't display properly in latest beta patch, see attached images (green squares for Calendar & Dungeon Finder icons).

Xrystal · 08-12-12, 12:15 PM

Thanks, have the simple updateContainer.... Change ready to set up. Only 2 files affected.

Not sure about the green icon problem. There's mention that it could be to do with how the path is set but I did think Scott had that done right. So, something to check again.

The dungeon icon I thought I had coded onto the map as it and the battlefield one I think are merged. But, it's possible that a later change has overridden it. Will check again.

Xrystal · 08-12-12, 12:50 PM

Hmm, definitely can't understand why the eye isn't on the minimap.

nUI_Minimap.lua

Code:

QueueStatusMinimapButton:SetParent( Minimap );
QueueStatusMinimapButton:SetScale( 0.8 );
QueueStatusMinimapButton:ClearAllPoints();
QueueStatusMinimapButton:RegisterForDrag();
QueueStatusMinimapButton:SetScript( "OnDragStart", nil );
QueueStatusMinimapButton:SetScript( "OnDragStop", nil );
QueueStatusMinimapButton:SetPoint( "BOTTOM", Minimap, "TOP", 0, -10 );
QueueStatusMinimapButton:SetFrameStrata( Minimap:GetFrameStrata() );
QueueStatusMinimapButton:SetFrameLevel( Minimap:GetFrameLevel()+5 );

replacing old code of :

Code:

--MiniMapLFGFrame:SetParent( Minimap );
--MiniMapLFGFrame:SetScale( 0.8 );
--MiniMapLFGFrame:ClearAllPoints();
--MiniMapLFGFrame:RegisterForDrag();
--MiniMapLFGFrame:SetScript( "OnDragStart", nil );
--MiniMapLFGFrame:SetScript( "OnDragStop", nil );
--MiniMapLFGFrame:SetPoint( "BOTTOM", Minimap, "TOP", 0, -10 );
--MiniMapLFGFrame:SetFrameStrata( Minimap:GetFrameStrata() );
--MiniMapLFGFrame:SetFrameLevel( Minimap:GetFrameLevel()+5 );

nUI_Buttonbag.lua

Code:

Excludes = 
{		
	["MiniMapMailFrame"] = true,

	-- 5.0.1 Change Start - Frame name changes
	--["MiniMapBattlefieldFrame"] = true,	
	--["MiniMapLFGFrame"] = true,		

	["QueueStatusMinimapButton"] = true,	
	-- 5.0.1 change End

	["MinimapBackdrop"] = true,

As you can see all I have done is tell it to use the QueueStatus button instead of the LFG button. Its placed in the same location and ignored at the same time from the button bag. I just can't figure out why that isn't doing what it is supposed to be. Unless the textures being messed up is making it worse.

Xrystal · 08-12-12, 12:58 PM

Aha, think I found it ...

Try changing line 814 or thereabouts in nUI_Buttonbag.lua.

Because the battlefield icon and the lfg icon were separate before I forgot to take that into account and ignore the battlefield new setting ... it looks like its putting the icon on the map for the LFG and then putting it in the bag for the battlefield side of it ... add -- in front of that line to comment it out and it should *touch wood* work properly now.

Code:

-- if top_row["QueueStatusMinimapButton"] then table.insert( fix_buttons, top_row["QueueStatusMinimapButton"] ); end

Daveo77 · 08-12-12, 04:05 PM

OK. Made change in nUI_ButtonBag.lua, will test when on beta later tonight and report back.

Daveo77 · 08-12-12, 06:16 PM

No joy. Icon appears above map initially but after opening ButtonBag it gets moved there.

Also, still have green squares instead of Dungeon Finder & Calendar icons in ButtonBag.

Xrystal · 08-12-12, 06:19 PM

I have no idea how to fix the green icons things. Never had that happen in any of my addons. I can't see anything wrong with the image paths Scott uses but they're not even for the individual icons from what I can see anyway.

Ah, will look at the code that happens when you open the buttonbag. Perhaps some extra code in there I didn't spot earlier.

Xrystal · 08-12-12, 06:46 PM

Well definitely can't see any special code in there that would make the icon appear in there for some reason. Especially cosidering it is in the exclude list rather than include list. I'll have to wait for some strange time where I can test it out without needing to go into a dungeon rofl.

Daveo77 · 08-13-12, 09:06 AM

I tested it by just joining the queue, seeing icon above map, then I opened ButtonBag, and saw icon disappear from above map, and appear in ButtonBag (as green square).

If it helps I'm using nUI Lite v5.07.24 (patched for 5.0.4).

Xrystal · 08-13-12, 02:17 PM

d'oh, looks like I missed a change in nUI Lite.

Look at Integration/nUI_ButtonBag.lua and look for something similar to the following:

Code:

	Excludes = 
	{		
		["MiniMapMailFrame"] = true,

		-- 5.0.1 Change Start - Frame name changes
		--["MiniMapBattlefieldFrame"] = true,	
		--["MiniMapLFGFrame"] = true,		
		["QueueStatusMinimapButton"] = true,	
		-- 5.0.1 change End

I can see I commented out the old Minimap frames but forgot to set the new QueueStatus frame as a buttonbag excluded item. I'm guessing it will work as expected with that change in.

Daveo77 · 08-13-12, 03:40 PM

Done change to Plugins/nUI_ButtonBag.lua, it doesn't exist in the Integration folder.

Will test when I log into beta later tonight.

Xrystal · 08-13-12, 03:52 PM

sorry was getting mixed up with the location of minimap .. buttonbag is the right file so hopefully that will explain the problem...

Daveo77 · 08-14-12, 06:59 AM

That fix has fixed the Dungeon Finder. It now stays above the minimap

Just the green blocks within ButtonBag to fix now, and one of them represents the Calendar button.

Xrystal · 08-14-12, 01:35 PM

Thanks dave, I'll take another browse through the main beta thread and see if I missed any possible causes for the green images. And then tonight I'll post an update to both versions for the latest patch. I suspect the green icon problem will still be there but hopefully not.

Seer · 08-14-12, 02:02 PM

Green images in WoW usually indicate texture (or just gfx) problems of some sort right? Unable to find the correct ones or so perhaps? (no idea how that would occurs since you grab the icons by name, not by image or however I should word it..)

Anyway, the glyph problem was solved in the previous patch by Blizz. Seems the biggest problems have been tackled by you.

Xrystal · 08-14-12, 02:55 PM

oh cool seer, the last update I did seemed to resolve the glyph errors I got. But my change was just to replace _ with a local dummy variable.

I almost forgot though that apparently a reloadui while in group messes the UI up. not been able to test that myself yet and not sure what could be causing that off the top of my head.