Unit Tooltip

kenoboll · 08-25-09, 02:59 PM

Hi, I'm using the addon TipTac and I was wondering if there's a way to remove the info that nUI shows in the tooltip: Health, Mana, Talent Build and Range, becuase sometimes nUI shows its info when I mouse over a player and sometimes it don't. It also shows wrong talent builds sometimes.

I can post some pics if you doesn't know what the hell I'm talking about :P

Xrystal · 08-25-09, 03:32 PM

The talent build info being incorrect is most likely a problem due to conflicting addons trying to grab info from the talent info and returning the wrong info. I get the same thing happening because my altoholic does talent lookups. The important talent trees ( my alts ) work fine but anyone in the raid or party may or may not appear with the correct info.

As to removing the information. Unfortunately it won't be possible unless Scott changes the source code.

Petrah · 08-25-09, 04:56 PM

There's an option in TipTac to disable it's talent views. Disable those so that you won't have a conflict.

kenoboll · 08-25-09, 05:10 PM

Originally Posted by Silenia

There's an option in TipTac to disable it's talent views. Disable those so that you won't have a conflict.

thx for the tip, tho I like tiptacs talent views since nUIs might be showing wrong... or sometimes not show up at all so I have to mouse over the player again and again until it shows. (same with hp/mana/range) :s

spiel2001 · 08-25-09, 05:37 PM

When you mouse over a player, rather than look at the tooltip, look at the mouseover unit frame at the bottom center of your dashboard. And if you do turn the talent option off in TipTac then nUI won't give you incorrect talent builds.

kenoboll · 08-25-09, 07:05 PM

Originally Posted by spiel2001

When you mouse over a player, rather than look at the tooltip, look at the mouseover unit frame at the bottom center of your dashboard. And if you do turn the talent option off in TipTac then nUI won't give you incorrect talent builds.

Sometime its working and sometimes its not :/

this is with TipTac talent option is off

this is with TipTac talent option is on

TipTac on again

TipTac off again (with reload UI)

Off (and reload UI)

spiel2001 · 08-25-09, 08:03 PM

You have to reload the UI after you turn the TipTac option off... nUI caches the talent builds it sees, so if you inspect a unit via TipTac and nUI inspects it and gets bad data as a result, then turn TipTac's inspections off, nUI *still* has the bad data saved. You would have to reload before nUI would recheck the unit.

kenoboll · 08-25-09, 08:11 PM

Originally Posted by spiel2001

You have to reload the UI after you turn the TipTac option off... nUI caches the talent builds it sees, so if you inspect a unit via TipTac and nUI inspects it and gets bad data as a result, then turn TipTac's inspections off, nUI *still* has the bad data saved. You would have to reload before nUI would recheck the unit.

The 2 last pics is on a DK I didn't inspect or mouse overed earlier, with TipTac off and a reload UI after. It's showing the talents from a Warlock I did inspect before the DK after reload UI.

This also happend before when I didn't even had TipTac addon installed

This shows my friends specc as Arms, I had target a Arms Warrior earlier

This is on a Druid showing his specc is elemental.

neuralassassin · 08-25-09, 08:16 PM

Could be another mod you use calling for inspections also there are quite a few of them that do, and that is the issue with any two mods calling it doesn't know which one actually called or when so until blizz decides to fix that if you can disable all but nUI it will work correctly

spiel2001 · 08-25-09, 08:17 PM

Okay... all I can tell you is this... the *only* way nUi can get the talent inspection wrong is if there is another mod running that is doing inspections at the same time as nUI. It's because of the way Blizzard has coded the talent inspection system. And, as it happens, having the inspection window open while you mouse over another mob counts as having two things inspecting at once.

I have found a fix for this, but I have not implemented it in 5.05 -- it will be implemented in 6.0 -- until then, you are limited to having nUI be the only mod that inspects other players or access that the information will be wrong.

kenoboll · 08-25-09, 08:39 PM

Originally Posted by spiel2001

Okay... all I can tell you is this... the *only* way nUi can get the talent inspection wrong is if there is another mod running that is doing inspections at the same time as nUI. It's because of the way Blizzard has coded the talent inspection system. And, as it happens, having the inspection window open while you mouse over another mob counts as having two things inspecting at once.

I have found a fix for this, but I have not implemented it in 5.05 -- it will be implemented in 6.0 -- until then, you are limited to having nUI be the only mod that inspects other players or access that the information will be wrong.

Ok, thx for the help. I think it's the addon Talented that might fck up so I'm gonna test it tomorrow when the servers are up.

Also, when I mouse over a player it sometimes doesn't show the info (hp,mana,talents,range) in the tooltip so I have to mouse over him again and again until it shows. This also getting fixed? (I wanted to remove them (see my first post) becuase of this but since I can't it's better to get it fixed

)

spiel2001 · 08-26-09, 04:05 AM

It will be fixed. However, as I said in my prior post, use the mouseover unit frame instead of the tooltip. The unit frame always works.

Petrah · 08-26-09, 06:34 AM

If you have addons that do talent inspections and those addons have an option to turn those inspections off then turn em off.

Otherwise it will be as I said before, a huge conflict. I have run TipTac and Talented both with those functions off and not had any issues.

kenoboll · 08-26-09, 08:38 AM

Removed both Talented and TipTac and its still showing wrong talents for some players. Gonna see if there's another addon that might have something to do with talents. Else I'll just try with only nUI activated. Or just use the mouseover unit frame instead.

Aezay · 08-26-09, 11:02 AM

In the nUI code, are you calling GetActiveTalentGroup() to check the inspected player's active spec, because it just looks like you're reading their inactive spec in those screenshots.

Xrystal · 08-26-09, 11:20 AM

Just took a quick look at the code and at first glance it looks like it is just grabbing the info. So, is it grabbing Spec 1 info or Active Spec Info *shrugs* Will have to check on shammy as her active spec is her secondary one.

spiel2001 · 08-26-09, 11:36 AM

That is a possible issue when players change between their primary and secondary talent specs after nUI has inspected them because at present Blizz has no mechanism in place that allows mods to know when a raid or party member has changed specs.

Since nUI caches the spec once it is read, it could report the wrong spec if the player changes between primary and secondary. This is an issue I'm also looking for a solution to without having to reinspect the player every time you look at it... probably a cache that expires after X amount of time.

Two things I've asked Blizzard for is (1) the GUID of the unit being inspected to be returned in the TALENT_INSPECT_READY event so the readers can all be 100% certain which mob they are inspecting, and, (2) an event to alert mods when a raid or party member's talent points change.

Originally Posted by Aezay

In the nUI code, are you calling GetActiveTalentGroup() to check the inspected player's active spec, because it just looks like you're reading their inactive spec in those screenshots.

**Seerah** · 08-26-09, 11:42 AM

Originally Posted by Aezay

In the nUI code, are you calling GetActiveTalentGroup() to check the inspected player's active spec, because it just looks like you're reading their inactive spec in those screenshots.

This is what I was asking in the other thread, spiel2001, but I was not aware that nUI also caches talents. Does this also mean that talents would be incorrect if the character leveled and spent a talent point since their talents were cached? Or do you check level to see if you need to scan again?

For now, I would check GetActiveTalentGroup() and cache that along with their talents. Then check that (along with level, if you don't already) to see if you can just show what's cached or scan again.

spiel2001 · 08-26-09, 12:47 PM

Yeah --

I'm heavily reworking this whole section for 6.0 to try and get around the conflicts including hooking the NotifyInspect, testing to see if the inspection window is open in Blizz and caching the active talent group and catching the level up event to flag the cache... in this case I have to start inspecting repeatedly until the total number of talent points changes so I can update the build.

This whole system is a PITA imo. Though I do think that given the GUID in the TALENT_INSPECT_READY event and an event to notify when a units talent points change would "fix" it enough that these sorts of issues would go away.