Run secure code

[Resike]

Is it possible to securely run a code snippet based on events like "GROUP_ROSTER_UPDATE" in combat and modify a position of another secure frame? I've tried everything but no luck so far.

[Fizzlemizz]

I would imagine that is exactly the kind of thing they don't want you to do so you can't move buttons and the like under your cursor etc.

[semlar]

Originally Posted by Resike Is it possible to securely run a code snippet based on events like "GROUP_ROSTER_UPDATE" in combat and modify a position of another secure frame? I've tried everything but no luck so far.

You can run code in response to someone joining or leaving the group because you can set a unit watch or state driver for any valid unit ID, eg. [raid1,exists].

If this is for unit frames you can just use a group header to control the layout.

[Resike]

Originally Posted by semlar You can run code in response to someone joining or leaving the group because you can set a unit watch or state driver for any valid unit ID, eg. [raid1,exists]. If this is for unit frames you can just use a group header to control the layout.

Hmm gonna try this. I guess you just have to set up the snippet descending like raid40 to raid1.

[Fizzlemizz]

Would this be able to actually move a secure frame in combat?

[Resike]

Originally Posted by Fizzlemizz Would this be able to actually move a secure frame in combat?

Yes, but only when a player joins/leaves the group.

I basically want to use this to setpoint the pet header frames based on the size/width of the current raid frame.

[Fizzlemizz]

Well there you go, I must stop doing that assuming thingy.

[Resike]

Originally Posted by Fizzlemizz Well there you go, I must stop doing that assuming thingy.

It's still not perfect because the state driver won't get triggered when someone rearrange the groups, like when you have 3 full groups and someone gets pulled to the group 4.

[Fizzlemizz]

Originally Posted by Resike It's still not perfect because the state driver won't get triggered when someone rearrange the groups, like when you have 3 full groups and someone gets pulled to the group 4.

Good to know, something to play with.

[kurapica.igas]

The SecureGroupHeader is using "GROUP_ROSTER_UPDATE" to update itself, you may give it's unit buttons a "refreshUnitChange" snippet where you can move other secure frames.

You can create a SecureGroupHeader and throw it out of the screen, it's what I do for my raid panels, I don't want to use it, but based on it, I can refresh the raid panels without taint.

[Resike]

Originally Posted by kurapica.igas The SecureGroupHeader is using "GROUP_ROSTER_UPDATE" to update itself, you may give it's unit buttons a "refreshUnitChange" snippet where you can move other secure frames. You can create a SecureGroupHeader and throw it out of the screen, it's what I do for my raid panels, I don't want to use it, but based on it, I can refresh the raid panels without taint.

Could you give an example for this? To be honest this was the first way i tried to do it, however the group headers won't accept a :SetFrameRef, and :Execute snippets by default, so that was my main issue.

[kurapica.igas]

Since the group header is a strict secure frame, don't know why you can't use SecureHandlerExecute.

My code is at IGAS-IFGroup, but it may be hard for reading.

I'll try to explain the details :

Don't use the group header's auto generated unit buttons, control them is too difficult. I only use them to notify me their units is changed or more unit buttons is created.

Here is the code for the group header(I try to convert my code to common one and only those code related to the group header, so it is not run-able) :

local grpHeader = CreateFrame("Frame", "MyGrpHeader", UIParent, "SecureGroupHeaderTemplate")
 
-- Some helper methods
function grpHeader:Execute(body) return SecureHandlerExecute(self, body) end
function grpHeader:WrapScript(frame, script, preBody, postBody) return SecureHandlerWrapScript(frame, script, self, preBody, postBody) end
function grpHeader:SetFrameRef(label, refFrame) return SecureHandlerSetFrameRef(self, label, refFrame) end
 
-- Init the header
grpHeader:Execute[=[
    Manager = self -- Register self to avoid some bugs
 
    UnitFrames = newtable()  -- Our own unit buttons, may be your secure frames
    ShadowFrames = newtable()-- The auto-generated unit buttons
 
    -- The snippet for auto-generated unit buttons's unit changed event
    -- This is only used when you entering the game world during a combat
    refreshUnitChange = [[
        local unit = self:GetAttribute("unit")
        local frame = self:GetAttribute("UnitFrame")
 
        -- Here you can handle the thing like moving, refreshing and etc
        -- I just refresh the real unit button's unit
        if frame then
            frame:SetAttribute("unit", unit) -- Refresh the real unit button's unit
        end
    ]]
]=]
 
-- Use SecureHandlerAttributeTemplate for unit buttons
grpHeader:SetAttribute("template", "SecureHandlerAttributeTemplate")
 
-- The init code for each auto-generated unit buttons
grpHeader:SetAttribute("initialConfigFunction", [[
    tinsert(ShadowFrames, self)
 
    -- I don't really need to show those auto-generated buttons
    self:SetWidth(0)
    self:SetHeight(0)
    self:SetID(#ShadowFrames)
 
    -- Binding
    local frame = UnitFrames[#ShadowFrames]
 
    self:SetAttribute("Manager", Manager)
 
    if frame then
        self:SetAttribute("UnitFrame", frame)
    end
 
    -- Only for entering game during combat
    -- refreshUnitChange won't fire when the unit is set to nil, so it's not a good choice
    self:SetAttribute("refreshUnitChange", refreshUnitChange)
 
    -- Call an un-secure method to notify new unit button is generated
    Manager:CallMethod("UpdateUnitCount", #ShadowFrames)
]])
 
-- Throw out of the screen, but keep it shown
grpHeader:SetPoint("TOPRIGHT", WorldFrame, "TOPLEFT")
 
-- The real snippet for unit changing
-- We don't use refreshUnitChange because it won't fire when the unit is changed to nil
local _Onattributechanged = [[
    if name == "unit" then
        if type(value) == "string" then
            value = strlower(value)
        else
            value = nil
        end
 
        local frame = self:GetAttribute("UnitFrame")
 
        -- Here you can handle the thing like moving, refreshing and etc
        if frame then
            frame:SetAttribute("unit", value)
        end
    end
]]
 
local function GenerateUnitFrames(self, count)
    -- re-init the auto-generated unit button
    local child = self:GetAttribute("child"..count)
 
    child:SetAttribute("refreshUnitChange", nil)    -- only used for the entering game combat
    child:SetAttribute("_onattributechanged", _Onattributechanged)
 
    -- Other code to generate the unit frames, just ignored here
end
 
function grpHeader:UpdateUnitCount(count)
    if InCombatLockdown() then
        -- Task.NoCombatCall is used to call the function wit args until the player is out of combat
        return Task.NoCombatCall(GenerateUnitFrames, self, count)
    else
        -- Wait the SecureGroupHeader finished the init
        -- Task.DelayCall is used to call the function with args after several time
        return Task.DelayCall(0.1, Task.NoCombatCall, GenerateUnitFrames, self, count)
    end
end

Here is code for register other secure frames :

function grpHeader:RegisterUnitFrame(frame)
    self:SetFrameRef("UnitFrame", frame)
    self:Execute[=[
        local frame = Manager:GetFrameRef("UnitFrame")
 
        if frame then
            tinsert(UnitFrames, frame)
 
            -- Binding
            local shadow = ShadowFrames[#UnitFrames]
 
            if shadow then
                shadow:SetAttribute("UnitFrame", frame)
                frame:SetAttribute("unit", shadow:GetAttribute("unit"))
            end
        end
    ]=]
end

Here I only use them to refresh their units, I use other features(like wrap the OnShow and OnHide) to control their positions.

[Resike]

Okay everything seems to be working, up to where you get the child value with self:GetAttribute("child"..count), but the child there is nil for some reason.

[kurapica.igas]

When the UpdateUnitCount is called, the "child"..count attribute is not set, so you only get nil value

You could see I have a delay to call the GenerateUnitFrames.

if InCombatLockdown() then
        -- Task.NoCombatCall is used to call the function wit args until the player is out of combat
        return Task.NoCombatCall(GenerateUnitFrames, self, count)
    else
        -- Wait the SecureGroupHeader finished the init
        -- Task.DelayCall is used to call the function with args after several time
        return Task.DelayCall(0.1, Task.NoCombatCall, GenerateUnitFrames, self, count)
    end

If the player is in combat, I can just wait the combat is ended and do the call. If the player is not in combat, I wait 0.1 sec then call the function.

[Resike]

Originally Posted by kurapica.igas When the UpdateUnitCount is called, the "child"..count attribute is not set, so you only get nil value You could see I have a delay to call the GenerateUnitFrames. if InCombatLockdown() then         -- Task.NoCombatCall is used to call the function wit args until the player is out of combat         return Task.NoCombatCall(GenerateUnitFrames, self, count)     else         -- Wait the SecureGroupHeader finished the init         -- Task.DelayCall is used to call the function with args after several time         return Task.DelayCall(0.1, Task.NoCombatCall, GenerateUnitFrames, self, count)     end If the player is in combat, I can just wait the combat is ended and do the call. If the player is not in combat, I wait 0.1 sec then call the function.

I see, the problem was with my throttle updater. But as i see at the end of the day, the _Onattributechanged can't get triggered in combat without taint. And that would be the whole point.

[kurapica.igas]

No, it's set to "_onattributechanged", so it's secure snippet called by the auto-generated unit buttons, and it'll be triggered during combat(since you can't re-define it during combat).

It's environment is the button's, so you can't access the table like UnitFrames. You should get the Manager and use the Manager to run snippets in the manager's environment like :

grpHeader:SetAttribute("refreshUnitFrames", [[
    for _, frm in ipairs(UnitFrames) do
        -- ...
    end
]])
 
local _Onattributechanged = [[
    if name == "unit" then
        if type(value) == "string" then
            value = strlower(value)
        else
            value = nil
        end
 
        -- Use Manager to call the snippet that in the manager's secure environment
        self:GetAttribute("Manager"):RunAttribute("refreshUnitFrames")
    end
]]

[kurapica.igas]

If you _Onattributechanged is not running, you may check the line

grpHeader:SetAttribute("template", "SecureHandlerAttributeTemplate")

It's used to make sure the unit buttons will fire the _Onattributechanged

[Resike]

I still get taint in combat:

local grpHeader = CreateFrame("Frame", "MyGrpHeader", UIParent, "SecureGroupHeaderTemplate")
 
grpHeader:SetAttribute("showRaid", true)
 
--grpHeader:SetAttribute("useparent-unit", true)
grpHeader:SetAttribute("strictFiltering", nil)
grpHeader:SetAttribute("startingIndex", 1)
grpHeader:SetAttribute("maxColumns", 8)
grpHeader:SetAttribute("unitsPerColumn", 5)
 
grpHeader:SetAttribute("sortMethod", nil)
--grpHeader:SetAttribute("sortMethod", "NAME")
 
--grpHeader:SetAttribute("minWidth", 50)
--grpHeader:SetAttribute("minHeight", 25)
grpHeader:SetAttribute("minWidth", 0)
grpHeader:SetAttribute("minHeight", 0)
 
grpHeader:SetAttribute("xOffset", 0)
grpHeader:SetAttribute("yOffset", 0)
grpHeader:SetAttribute("point", "TOP")
 
grpHeader:SetAttribute("columnSpacing", 1)
grpHeader:SetAttribute("columnAnchorPoint", "LEFT")
 
--grpHeader:SetAttribute("groupBy", "ASSIGNEDROLE")
--grpHeader:SetAttribute("groupingOrder", "TANK,HEALER,DAMAGER,NONE")
grpHeader:SetAttribute("groupBy", "GROUP")
grpHeader:SetAttribute("groupingOrder", "1,2,3,4,5,6,7,8")
--grpHeader:SetAttribute("groupBy", nil)
--grpHeader:SetAttribute("groupingOrder", nil)
 
grpHeader:SetAttribute("groupFilter", nil)
 
grpHeader:SetAttribute("template", "SecureHandlerAttributeTemplate")
 
grpHeader:SetAttribute("initial-unitWatch", true)
 
grpHeader:SetAttribute("style-width", 68)
grpHeader:SetAttribute("style-height", 41)
grpHeader:SetAttribute("style-scale", 1)
 
-- Some helper methods
function grpHeader:Execute(body) return SecureHandlerExecute(self, body) end
function grpHeader:WrapScript(frame, script, preBody, postBody) return SecureHandlerWrapScript(frame, script, self, preBody, postBody) end
function grpHeader:SetFrameRef(label, refFrame) return SecureHandlerSetFrameRef(self, label, refFrame) end
 
-- Init the header
grpHeader:Execute[=[
    Manager = self -- Register self to avoid some bugs
 
    UnitFrames = newtable()  -- Our own unit buttons, may be your secure frames
    ShadowFrames = newtable()-- The auto-generated unit buttons
 
    -- The snippet for auto-generated unit buttons's unit changed event
    -- This is only used when you entering the game world during a combat
    refreshUnitChange = [[
        local unit = self:GetAttribute("unit")
        local frame = self:GetAttribute("UnitFrame")
 
        -- Here you can handle the thing like moving, refreshing and etc
        -- I just refresh the real unit button's unit
        if frame then
            frame:SetAttribute("unit", unit) -- Refresh the real unit button's unit
        end
    ]]
]=]
 
-- Use SecureHandlerAttributeTemplate for unit buttons
grpHeader:SetAttribute("template", "SecureHandlerAttributeTemplate")
 
-- The init code for each auto-generated unit buttons
grpHeader:SetAttribute("initialConfigFunction", [[
    tinsert(ShadowFrames, self)
 
    -- I don't really need to show those auto-generated buttons
    self:SetWidth(0)
    self:SetHeight(0)
    self:SetID(#ShadowFrames)
 
    -- Binding
    local frame = UnitFrames[#ShadowFrames]
 
    self:SetAttribute("Manager", Manager)
 
    if frame then
        self:SetAttribute("UnitFrame", frame)
    end
 
    -- Only for entering game during combat
    -- refreshUnitChange won't fire when the unit is set to nil, so it's not a good choice
    self:SetAttribute("refreshUnitChange", refreshUnitChange)
 
    -- Call an un-secure method to notify new unit button is generated
    Manager:CallMethod("UpdateUnitCount", #ShadowFrames)
]])
 
-- Throw out of the screen, but keep it shown
grpHeader:SetPoint("TOPRIGHT", WorldFrame, "TOPLEFT")
 
grpHeader:SetAttribute("refreshUnitFrames", [[
    print("HELLO")
]])
 
-- The real snippet for unit changing
-- We don't use refreshUnitChange because it won't fire when the unit is changed to nil
local _Onattributechanged = [[
    if name == "unit" then
        if type(value) == "string" then
            value = strlower(value)
        else
            value = nil
        end
        print(value)
        self:GetAttribute("Manager"):RunAttribute("refreshUnitFrames")
    end
]]
 
local function GenerateUnitFrames(self, count)
    -- re-init the auto-generated unit button
    local child = self:GetAttribute("child"..count)
 
    child:SetAttribute("refreshUnitChange", nil)    -- only used for the entering game combat
    child:SetAttribute("_onattributechanged", _Onattributechanged)
 
    -- Other code to generate the unit frames, just ignored here
end
 
function grpHeader:UpdateUnitCount(count)
    local timer = 0
    grpHeader:SetScript("OnUpdate", function(self, elapsed)
        timer = timer + elapsed
        if timer < 1 then
            return
        end
        timer = 0
        
        GenerateUnitFrames(self, count)
    end)
end
 
grpHeader:Show()

What i ment when someone joins my group while i'm in combat, then you can't set it's child:SetAttribute("_onattributechanged", _Onattributechanged).

[Resike]

I found a way to do this:

You set your frame references to the header [SecureRaidGroupHeaderTemplate] frame itself, then and you wrap a script to every UnitFrame [SecureUnitButtonTemplate] created by initialConfigFunction, then you can reach you reference frames with the :GetParent() call like this:

SecureHandlerWrapScript(frame, "OnAttributeChanged", header, [[
    local petheader1 = self:GetParent():GetFrameRef("ZPerlRaidPetsGroup1")
    if not petheader1 then
        return
    end
    --print(self:GetName(), petheader1)
 
    local groups = 0
 
    for i = 1, 8 do
        if self:GetParent():GetFrameRef("ZPerlRaidHeader"..i.."UnitButton1"):IsShown() then
            groups = groups + 1
        end
    end
 
    local x = (8 - groups) / 10
    print(groups, x)
 
    local point, relativeTo, relativePoint, xOfs, yOfs = petheader1:GetPoint(1)
 
    if xOfs ~= x then
        petheader1:SetPoint("TOPLEFT", self:GetParent():GetFrameRef("ZPerlRaidHeader8"), "TOPRIGHT", -x, 0)
    end
]])

You just need to make sure to pre-create every UnitFrame OnLoad with this trick:

local maxColumns = self.header:GetAttribute("maxColumns") or 1
local unitsPerColumn = self.header:GetAttribute("unitsPerColumn") or 5
local startingIndex = self.header:GetAttribute("startingIndex")
local maxUnits = maxColumns * unitsPerColumn
 
self.self.header:Show()
self.self.header:SetAttribute("startingIndex", - maxUnits + 1)
self.self.header:SetAttribute("startingIndex", startingIndex)

This method triggers the changes with every joined/left and moved units. However it gets triggered fuckzillion times and me no likey that.

Then boom you can do any secure changes you want on "GROUP_ROSTER_UPDATE". Just need to look into that how to filter that swarming OnAttributeChanged a bit more.

I'm also not sure yet if this shit worth the hassle performace wise.

[kurapica.igas]

Well, you can't call the GenerateUnitFrames during combat, the GenerateUnitFrames is used to replace the "refreshUnitChange" to "_onattributechanged", here is a simple version

local _Task = {}
 
grpHeader:SetScript("OnUpdate", function(self, elapsed)
    if not InCombatLockdown() and #_Task > 0 then
        for _, cnt in ipairs(_Task) do
            GenerateUnitFrames(self, count)
        end
        wipe(_Task)
    end
end)
 
function grpHeader:UpdateUnitCount(count)
    tinsert(_Task, count)
end

If you don't create buttons based on the auto-generated unit buttons, the refreshUnitChange and _onattributechanged will do the same work, only the refreshUnitChange won't be fired when a unit is set to nil, so I replace it with a better one when out of combat.