Showing/Hiding frames

[Dreadlorde]

I'm trying to hide and show some art based one whether DUF_FocusFrame and DUF_TargetOfTargetFrame is visible. The first thing I could think of was the following code.

local UrkFocus = CreateFrame("Frame",UrkFocus,UIParent)
UrkFocus:SetFrameStrata("BACKGROUND")
UrkFocus:SetWidth(341.5)
UrkFocus:SetHeight(341.5)

local o = UrkFocus:CreateTexture(UrkFocus,"LOW")
o:SetTexture("Interface\\AddOns\\Urk\\Custom\\focus.tga")
o:SetAllPoints(UrkFocus)
UrkFocus.texture = o

UrkFocus:SetPoint("BOTTOM",100,13)
UrkFocus:Show()

local UrkTot = CreateFrame("Frame",urkTot,UIParent)
UrkTot:SetFrameStrata("BACKGROUND")
UrkTot:SetWidth(341.5)
UrkTot:SetHeight(341.5)

local p = UrkTot:CreateTexture(Urk,"LOW")
p:SetTexture("Interface\\AddOns\\Urk\\Custom\\tot.tga")
p:SetAllPoints(UrkTot)
UrkTot.texture = p

UrkTot:SetPoint("BOTTOM",-100,13)
UrkTot:Show()

--toggle arts
function UrkFocus_Toggle()
   if ( DUF_FocusFrame:IsShown() ) then
      UrkFocus:Show();
   else
      UrkFocus:Hide();
   end
end

function UrkTot_Toggle()
   if ( DUF_TargetOfTargetFrame:IsShown() ) then
      UrkTot:Show();
   else
      UrkTot:Hide();
   end
end

The problem is, this doesn't work; and I was hoping someone could help me figure out how to do it.

Thanks for any help.

[Slakah]

you could set it as a parent to the other frames in CreateFrame or use onshow/onhide handlers.

for parenting replace

local UrkFocus = CreateFrame("Frame",UrkFocus,UIParent)

with

local UrkFocus = CreateFrame("Frame",UrkFocus,DUF_FocusFrame)

or with the onhide/onshow approach which is slighly more complex do

local onshow = DUF_FocusFrame:GetScript("OnShow")
DUF_FocusFrame:SetScript("OnShow", function(...)
   UrkFocus:Show()
   return onshow(...)
end

local onhide = DUF_FocusFrame:GetScript("OnHide")
DUF_FocusFrame:SetScript("OnHide", function(...)
   UrkFocus:Hide()
   return onhide(...)
end)

should work.

[Dreadlorde]

I get the following error when I use the OnHide/OnShow approach:

Interface\AddOns\Urk\Core.lua:231: ')' expected (to close '(' at line 226) near 'local'

Line 226 is:

DUF_FocusFrame:SetScript("OnShow", function(...)

I can't figure out how to fix this either..

[Slakah]

I missed a ")" at the end of the onshow function. It should be this

DUF_FocusFrame:SetScript("OnShow", function(...)
   UrkFocus:Show()
   return onshow(...)
end)

[Dreadlorde]

Doh! I think I tried adding ) everywhere but there.

Thanks Slakah.

[erica647]

Hey Dreadlorde... not sure what editor you use but you might wanna check out Komodo editor. It will highlight syntax errors and may find little things like that for you.

http://www.activestate.com/Products/komodo_edit/

[Dreadlorde]

I've been using notepad++, but komodo looks nice. I'll try it out.

Thanks for showing me that erica.

[Tristanian]

Originally Posted by Dreadlorde I'm trying to hide and show some art based one whether DUF_FocusFrame and DUF_TargetOfTargetFrame is visible. The first thing I could think of was the following code. local UrkFocus = CreateFrame("Frame",UrkFocus,UIParent) UrkFocus:SetFrameStrata("BACKGROUND") UrkFocus:SetWidth(341.5) UrkFocus:SetHeight(341.5) local o = UrkFocus:CreateTexture(UrkFocus,"LOW") o:SetTexture("Interface\\AddOns\\Urk\\Custom\\focus.tga") o:SetAllPoints(UrkFocus) UrkFocus.texture = o UrkFocus:SetPoint("BOTTOM",100,13) UrkFocus:Show() local UrkTot = CreateFrame("Frame",urkTot,UIParent) UrkTot:SetFrameStrata("BACKGROUND") UrkTot:SetWidth(341.5) UrkTot:SetHeight(341.5) local p = UrkTot:CreateTexture(Urk,"LOW") p:SetTexture("Interface\\AddOns\\Urk\\Custom\\tot.tga") p:SetAllPoints(UrkTot) UrkTot.texture = p UrkTot:SetPoint("BOTTOM",-100,13) UrkTot:Show() --toggle arts function UrkFocus_Toggle() if ( DUF_FocusFrame:IsShown() ) then UrkFocus:Show(); else UrkFocus:Hide(); end end function UrkTot_Toggle() if ( DUF_TargetOfTargetFrame:IsShown() ) then UrkTot:Show(); else UrkTot:Hide(); end end The problem is, this doesn't work; and I was hoping someone could help me figure out how to do it. Thanks for any help.

You can try using IsVisible() methods instead of IsShown for UrkFocus_Toggle and UrkTot_Toggle. Just because an object is shown, doesn't necessarily imply it's also visible. It depends on the parents as well.