API/Addon for new combat resurrection mechanic available?

[semlar]

Here's a dry-coded example, so I have no idea if it works.

-- todo: Track that someone in the raid is actually capable of battle rezzing and alive
local WhoDead, SecondsPerRez, ElapsedTime, NumRezzed = {}, 1, 0, 0
local f = CreateFrame('frame') f:Hide()
f:SetScript('OnEvent', function(self, event, ...) return self[event] and self[event](self, ...) end)
 
function f:ENCOUNTER_START(encounterID, encounterName, difficultyID, raidSize)
    if difficultyID < 3 then return end
    wipe(WhoDead)
    SecondsPerRez, ElapsedTime, NumRezzed = 5400 / raidSize, 0, 0
    self:RegisterEvent('INCOMING_RESURRECT_CHANGED')
    self:Show()
end
f:RegisterEvent('ENCOUNTER_START')
 
function f:ENCOUNTER_END()
    self:Hide()
    self:UnregisterEvent('INCOMING_RESURRECT_CHANGED')
end
f:RegisterEvent('ENCOUNTER_END')
 
function f:INCOMING_RESURRECT_CHANGED(unit) -- Track who has received a rez within range
    local name = UnitName(unit)
    if name and not WhoDead[name] and UnitHasIncomingResurrection(unit) then
        WhoDead[name] = true
    end
end
 
f:SetScript('OnUpdate', function(self, elapsed)
    ElapsedTime = ElapsedTime + elapsed
    
    for name in pairs(WhoDead) do
        if not UnitIsDeadOrGhost(name) and UnitIsConnected(name) then -- Dead unit is no longer dead
            WhoDead[name] = nil
            NumRezzed = NumRezzed + 1
        end
    end
    
    local availableRezzes = 1 + floor(ElapsedTime / SecondsPerRez) - NumRezzed
    -- Do something to display this number somewhere..
end)

It doesn't actually do anything with the "availableRezzes" number, so if you want this for an LDB display or something you'll need to add the appropriate code for that.

I have no idea how reincarnation is factored into the new rules, and I don't know if reincarnation or soulstones trigger an incoming rez event, so it might just be simpler to check UNIT_HEALTH to track when they've died or rezzed.

[Phanx]

Originally Posted by semlar I don't know if reincarnation or soulstones trigger an incoming rez event, ...

They don't. The event only indicates that a res spell started or stopped being cast on someone; there's no event that specifically notifies you when (or if) they actually ressurect, so you have to watch UNIT_HEALTH or just poll OnUpdate as in your example. The event also doesn't fire for Mass Res, though I suppose that's not relevant if you're only tracking in combat.

[semlar]

I'm trying to decide how best to determine that the people in the raid are also in the current boss fight and not outside the instance.

You could loop over the raid on ENCOUNTER_START and put everyone who's in the same zone as you into a table to reference throughout the fight, or you could compare their zone (from GetRaidRosterInfo) to yours when they're resurrected.. but I'm not sure if phasing could potentially cause problems with that.

I was thinking something like this..

for i = 1, GetNumGroupMembers() do
    local name, _, _, _, _, class, zone, online, isDead, _, _, role = GetRaidRosterInfo(i)
    if zone == OurZone and online then
        if not isDead and WhoDead[name] then -- unit no longer dead, presumed rezzed
            WhoDead[name] = nil
            NumRezzed = NumRezzed + 1
        elseif isDead and not WhoDead[name] then -- someone died
            WhoDead[name] = true
        end
    end
end

[cremor]

Isn't the raidSize parameter of the ENCOUNTER_START event that value? I assumed so because you used it in your first example instead of GetNumGroupMembers().

[semlar]

Originally Posted by cremor Isn't the raidSize parameter of the ENCOUNTER_START event that value? I assumed so because you used it in your first example instead of GetNumGroupMembers().

Presumably the raid size argument from ENCOUNTER_START tells us how many people are engaged with the boss, but it doesn't tell us who they are.

Since there isn't an event specifically for detecting when someone comes back to life, we have to infer that someone has been resurrected based on the fact that the encounter is still in progress and someone has gone from "dead" to "alive".

The combat log can tell us when someone has died, and if someone has cast a resurrection spell on them, but not whether they've taken it. It also is the least reliable method for tracking that someone has been rezzed, because it can occasionally malfunction, and it would completely fail if you're in a different phase than the person who died.

In the worst-case-scenario we can't detect whether a player has been rezzed, but we can detect that they've come back to life. This is a tricky distinction because there have been fights where players are killed and resurrected as part of the fight itself (eg. the final phase of the lich king), but it's not something we should really worry too much about.

So, ultimately I think the best solution is to make a table of who's in the same zone at the start of the encounter, and either OnUpdate or on UNIT_HEALTH scan for dead and potentially resurrected raid members.

I think it's a toss-up whether UNIT_HEALTH or OnUpdate is more efficient in a raid; either way you're going to be calling a lot of functions. UNIT_HEALTH is probably slightly better, but you have to use OnUpdate anyway because the available number of charges is based on elapsed time, assuming you want to update a display as soon as the number changes.

There is one other aspect that I picked up from the blizzard post on the subject, and it's that dead players with pending resurrections have a debuff. I don't know what that debuff is called, but it could be used to distinguish between people who have died in the boss fight and people who died outside of it, unless it doesn't show for people with self-resurrections, in which case it isn't terribly helpful.

[ykiigor]

CLEU event: SPELL_RESURRECT for start watching
And UNIT_FLAGS event with func UnitIsDead for tracking successful resurrection
Don't know how fast this, but it works

[InKahootz]

Originally Posted by semlar There is one other aspect that I picked up from the blizzard post on the subject, and it's that dead players with pending resurrections have a debuff. I don't know what that debuff is called, but it could be used to distinguish between people who have died in the boss fight and people who died outside of it, unless it doesn't show for people with self-resurrections, in which case it isn't terribly helpful.

This is where I come in as I've been trying to solve the battle rez for my addon.
The debuff is called "Resurrecting". Seen here: http://wod.wowhead.com/spell=160029
There is a pretty big bug though, it applies in the CLEU but when raid testing was going on, there was no spell_aura_removed for it. One more big caveat, it doesn't work for warlocks who use soulstone.
Blizz has some big oversights here and we just have to figure out a way to work around them.

[InKahootz]

I logged a dungeon and the time that a battle rez was used, the resurrecting debuff had a CLEU for removal. So there might be hope yet.